Uh oh!
There was an error while loading. Please reload this page.
feat: add telemetry notice and preference management - #797
Merged
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-797-tarball/aws-agentcore-0.7.1.tgz |
Hweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 14:40
67f27fa to
580fae2CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 14:44
580fae2 to
b82a818CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 14:51
b82a818 to
c97d12dCompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 14:54
c97d12d to
7cdbba8CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 14:58
7cdbba8 to
a10aa17CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 15:05
a10aa17 to
e965b09CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 15:10
e965b09 to
3ec7c3aCompareaidandaly24
requested changes
Apr 9, 2026
aidandaly24
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good just some comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 17:19
0f537a5 to
05a592dCompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 17:22
05a592d to
38d56d7CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 17:39
38d56d7 to
0e8998aCompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 17:41
0e8998a to
7517d84CompareHweinstockforce-pushed
the
feat/telemetry-phase1
branch
from
April 9, 2026 17:42
7517d84 to
6bd1445CompareHweinstock
commented
Apr 9, 2026
ContributorAuthor
lint failure from #697, will fix in a follow-up. |
aidandaly24
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add first-run telemetry notice and preference management commands to the CLI.
installationIdin~/.agentcore/config.json), a yellow notice informs users about upcoming anonymous usage analytics and how to opt out.agentcore telemetry disable|enable|statussubcommands for managing preferencesAGENTCORE_TELEMETRY_DISABLED) > global config > default (enabled)~/.agentcore/config.jsonfor persistent global config (installationId, telemetry preferences)Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsplayed around with packaged tarball to verify it works e2e.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.