Uh oh!
There was an error while loading. Please reload this page.
#142: add Automatic-Module-Name during build - #469
Open
SingingBush wants to merge 2 commits into
Open
Conversation
msailes
commented
Sep 3, 2024
Contributor
Hi @SingingBush, Would you be able to resolve the conflicts with this PR? Thanks, |
SingingBushforce-pushed
the
feature/JPMS_automatic_module_name
branch
from
September 3, 2024 13:41
83e98d1 to
2ded191CompareSingingBush
commented
Sep 3, 2024
Author
I'm looking into the failing tests and will push another commit |
smirnoal
approved these changes
Sep 4, 2024
SingingBushforce-pushed
the
feature/JPMS_automatic_module_name
branch
from
October 3, 2024 22:52
61dfd99 to
c3c1cbbCompareSingingBush
commented
Oct 3, 2024
Author
I've rebased on the latest changes in main. Please re-run workflows. @maxday any chance of getting a second review |
update surefire & failsafe plugins update Junit
SingingBushforce-pushed
the
feature/JPMS_automatic_module_name
branch
from
August 11, 2025 08:24
c3c1cbb to
98ee838CompareSingingBush
commented
Aug 11, 2025
Author
I've rebased again, please can someone run the workflow and review the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:#142
Description of changes: Support JPMS by using maven-jar-plugin to add Automatic-Module-Name during build
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.