Uh oh!
There was an error while loading. Please reload this page.
New ScheduledV2Event implementation - #480
Conversation
and fix for APIGatewayV2CustomAuthorizerEventTest when running on the non-US locale machine
smirnoal
left a comment
There was a problem hiding this comment.
please add a test to aws-lambda-java-tests covering this event
| @@ -0,0 +1,366 @@ | |||
| /* | |||
There was a problem hiding this comment.
please update the header to
/*
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0
*/
| @BeforeAll | ||
| static void beforeAll() { | ||
| Locale.setDefault(new Locale("en", "US")); |
peniakoff
commented
May 7, 2024
@smirnoal, done with my last commit. |
| import java.util.List; | ||
| /** | ||
| * represents a scheduled V2 event |
There was a problem hiding this comment.
Can you add a link to the documentation in the header please.
Uh oh!
There was an error while loading. Please reload this page.
| private String region; | ||
| private String detail; |
There was a problem hiding this comment.
I think we (AWS) needs to validate that there will be no events where detail will be anything other than a String for scheduled task use cases.
Uh oh!
There was an error while loading. Please reload this page.
msailes
commented
Jun 24, 2024
We also probably want to consider how we explain the difference between |
peniakoff
commented
Jul 9, 2024
PR updated. Sorry for delay. |
| * @see Object#toString() | ||
| */ | ||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
https://projectlombok.org/features/Data includes toString, hashcode and equals, you can remove those, and the clone method.
| /** | ||
| * Represents a Scheduled V2 event sent to Lambda | ||
| * <a href="https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-function-schedulev2.html">ScheduleV2</a> |
There was a problem hiding this comment.
I think this is a link to the wrong page.
Uh oh!
There was an error while loading. Please reload this page.
and fix for APIGatewayV2CustomAuthorizerEventTest when running on the non-US locale machine.
Issue #, if available:
No. 479: #479
Description of changes:
New Java class ScheduledV2Event has been added. Additionally change is related to APIGatewayV2CustomAuthorizerEventTest which didn't pass on non-US locale Java machine. Now default locale for both tests from this class are running under US-en locale.
Target (OCI, Managed Runtime, both):
both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.