Skip to content

#142 Add module descriptors with moditect - #510

Open
SentryMan wants to merge 9 commits into
aws:mainfrom
SentryMan:modules
Open

#142 Add module descriptors with moditect#510
SentryMan wants to merge 9 commits into
aws:mainfrom
SentryMan:modules

Conversation

@SentryMan

@SentryManSentryMan commented Sep 3, 2024•
edited
Loading

Copy link
Copy Markdown

Issue #, if available:
resolves#142

Description of changes:
Uses moditect maven plugin to add a module-info.class without breaking Java 8 compatibility.

Target (OCI, Managed Runtime, both):
Both

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SentryManSentryMan changed the title Add module descriptor with moditectAdd module descriptor to core module with moditectSep 3, 2024
@SentryManSentryMan changed the title Add module descriptor to core module with moditect#142 Add module descriptor to core module with moditectSep 3, 2024
@SentryManSentryMan changed the title #142 Add module descriptor to core module with moditect#142 Add module descriptors with moditectSep 4, 2024
maxday
maxday reviewed Sep 16, 2024
View reviewed changes
Comment threadaws-lambda-java-core/pom.xml Outdated
Comment threadaws-lambda-java-events-sdk-transformer/pom.xml Outdated
Comment threadaws-lambda-java-events/pom.xml Outdated
Comment threadaws-lambda-java-log4j2/pom.xml Outdated
Comment threadaws-lambda-java-runtime-interface-client/pom.xml Outdated
Comment threadaws-lambda-java-serialization/pom.xml Outdated
@SentryMan

SentryMan commented Nov 22, 2024

Copy link
Copy Markdown
Author

@smirnoal, @maxday Please review when you find the time

@SentryMan

SentryMan commented Nov 3, 2025

Copy link
Copy Markdown
Author

man this is taking quite some time

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxdaymaxdayAwaiting requested review from maxday
@smirnoalsmirnoalAwaiting requested review from smirnoal

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 'Automatic-Module-Name' property to aws-lambda-java-core MANIFEST.MF

3 participants

@SentryMan@maxday@smirnoal