Uh oh!
There was an error while loading. Please reload this page.
Paginator definitions for CostExplorer API - #3041
Conversation
Thanks for opening a pull request. Unfortunately these need to be merged upstream by the service team. I can inform them of the work you've done and they will prioritize this accordingly. V1413840028 |
e166a7c to
0259892Compare1f588fa to
0ddf23fCompare0ddf23f to
c754786Comparec754786 to
6e737a7Compare6e737a7 to
e68c342Comparee68c342 to
3be93b6Compare3be93b6 to
68b52b7Compare68b52b7 to
9819bc5Compare9819bc5 to
9497202Compare9497202 to
f92fd09Comparef92fd09 to
9dfd1d9Compare9dfd1d9 to
fc4dff2Comparefc4dff2 to
56a8f8bCompare56a8f8b to
a63c98aComparea63c98a to
bfcc837Comparebfcc837 to
02ff62aComparepas256
commented
Feb 5, 2025
02ff62a to
e33e9d4Compare@mullermp Could you check the status of the ticket you opened to get these changes merged upstream? Still need to use and frequently rebase this fork to actually have cost explorer API pagination work correctly. If you'd like to use this fork @pas256: # Gemfilegem"aws-sdk-costexplorer",github: "thomasklemm/aws-sdk-ruby",glob: "gems/aws-sdk-costexplorer/*.gemspec",branch: "feat/paginator-definitions-for-cost-explorer-api" |
mullermp
commented
Feb 10, 2025
I believe @jterapin opened the internal ticket. I agree though, this is getting ridiculous and is poor customer obsession from the service team. Adding the pagination traits to the model and releasing it is not complex work. We will forward along your frustration, again. |
e33e9d4 to
508d8d5Compare508d8d5 to
91ea464Compare91ea464 to
e787086Comparejterapin
commented
Mar 19, 2025
I'm so sorry about this. The service teams has not prioritized the work yet but what I can do now is to forward your feedback to them and voice the inconsistency between the service api and the outdated service model. I will circle back if I hear anything back. |
pas256
commented
Mar 19, 2025
Thanks @jterapin, we appreciate it. Please be sure to use a stern font and a frowning emoji when you give them the feedback. |
thomasklemm
commented
Mar 19, 2025
Thanks for following up @jterapin! |
mullermp
commented
Mar 21, 2025
The biggest issue we are running into is that apparently this service model is composed of 4 big teams. We've gotten a commitment from one team to add pagination to their APIs but we are working on getting the other three. I'm just as frustrated as you about this. |
mullermp
commented
Mar 21, 2025
By chance do you have premium support? |
As mullermp mentioned above, the service model is broken down to few different teams so these updates will come in separate pieces. In addition to the committed team above, we have another team that is close to committing. I'm following up with them today and then, the last two teams ... I'm still working on them. I will keep y'all updated. |
900f252 to
b198239Compareb198239 to
83ff7c5Compare83ff7c5 to
2f0b1b5Compare- Includes the new paginator definitions for the Cost Explorer API, so #next_page?, #next_page and other pagination methods are now properly working on the response
2f0b1b5 to
3388120Compare
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!