Skip to content

feat: get secrets by versionId or versionStage (#19) - #153

Open
ThirdEyeSqueegee wants to merge 6 commits into
aws:v2from
ThirdEyeSqueegee:v2
Open

feat: get secrets by versionId or versionStage (#19)#153
ThirdEyeSqueegee wants to merge 6 commits into
aws:v2from
ThirdEyeSqueegee:v2

Conversation

@ThirdEyeSqueegee

Copy link
Copy Markdown
Member

Issue #, if available:
#19

Description of changes:

  • Add optional versionId and versionStage args to GetSecretString and GetSecretBinary to allow retrieving secrets by version ID or version stage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ThirdEyeSqueegee
ThirdEyeSqueegee requested a review from a team as a code ownerApril 10, 2025 21:56
Comment threadsrc/main/java/com/amazonaws/secretsmanager/caching/SecretCache.java Outdated
Comment threadsrc/main/java/com/amazonaws/secretsmanager/caching/SecretCache.java Outdated
@codecov

codecovBot commented Jul 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.65%. Comparing base (db8a853) to head (36a08ac).

Files with missing linesPatch %Lines
.../secretsmanager/caching/cache/SecretCacheItem.java52.94%5 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## v2 #153 +/- ##
============================================
- Coverage 90.86% 87.65% -3.22% - Complexity 90 93 +3 
============================================
Files 6 6 Lines 230 243 +13 Branches 24 29 +5 ============================================
+ Hits 209 213 +4 - Misses 18 24 +6 - Partials 3 6 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ThirdEyeSqueegee@simonmarty