fix(security): Handle multi-token command substitution in sendText sanitizer

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207

[aakashmandavilli96]

Problem

The terminal sendText sanitizer only escaped $() within single whitespace-delimited tokens. Multi-token payloads like $(curl google.com)/test.py span two tokens ($(curl and google.com)/test.py), so the $( was never matched and the command substitution executed:

/opt/conda/bin/python "/home/sagemaker-user/$(curl google.com)/test.py"

Fix

Adds a first-pass regex that matches complete$(...), ${...}, and backtick constructs (including internal spaces) followed by / before per-token processing.

Three-pass approach:

1. Escape complete substitution constructs followed by / (handles multi-token payloads)
2. Escape patterns inside double-quoted paths containing /
3. Escape residual patterns in unquoted path-like tokens containing /

Testing

• Patch applies cleanly via sh ./scripts/install.sh
• Compilation succeeds
• Manually verified: $(curl google.com)/test.py → \$(curl google.com)/test.py

Related: aws/code-editor#207