Uh oh!
There was an error while loading. Please reload this page.
added split path function and tests, inserted into _process.py - #244
added split path function and tests, inserted into _process.py#244loodvn wants to merge 2 commits into
Conversation
sagemaker-bot
commented
Feb 5, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
As described in https://github.com/aws/sagemaker-containers/issues/245, I can't seem to use an entry point that's nested inside my package. In _process.py, we trim the ".py" extension from e.g. python -m train When the user-given entry point contains path seperators, this becomes python -m my_package/train , which causes an ImportError. I have two proposed ideas for a fix:
I'm just not sure what side effects the second would have (by changing the entry point type), so I implemented the first so long. |
Oops, I just realised that with something like The above change would still give me src.my_package.train, instead of my_package.train. Do you have any thoughts on this? |
laurenyu
commented
Feb 17, 2020
going to close this in favor of aws/sagemaker-python-sdk#941 (see #245) |
Issue #, if available:
#245
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.