Support recipes and scheduler in Hyperpod CLI by xiaoxshe · Pull Request #41 · aws/sagemaker-hyperpod-cli

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxshe · 2024-12-04T15:22:38Z

PR Approval Steps

For Requester

Description
- Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
- Ensure that the PR follows the contribution guidelines, if applicable.
Security requirements
- Ensure that a Pull Request (PR) does not expose passwords and other sensitive information by using git-secrets and upload relevant evidence: https://github.com/awslabs/git-secrets
- Ensure commit has GitHub Commit Signature
Manual review
1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
  - Code Quality: Check for coding standards, naming conventions, and readability.
  - Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
  - Security: Check for any security issues or vulnerabilities.
  - Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
Check for Merge Conflicts:
- Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

Go through For Requester section to double check each item.
Request Changes or Approve the PR:
1. If the PR is ready to be merged, click Review changes and select Approve.
2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
Merging the PR
1. Check the Merge Method:
  1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
2. Merge the PR:
  1. Click the Merge pull request button.
  2. Confirm the merge by clicking Confirm merge.

add recipes feature for distributed training

* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding

add recipes into help menu and add changelog for distributed training recipes

change submodule to public repo of recipes

* QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com>

Remove custom_launcher folder

Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

xiaoxsheand others added 14 commits November 4, 2024 10:49

add recipes feature for distributed training
ad54030

improve unit test coverage for recipes feature
cf45d11

add support recipes along with command line args
7fa16df

Merge pull requestaws#14from xiaoxshe/main
d230926
add recipes feature for distributed training

add recipes
a470417

Merge branch 'aws:main' into main
fe6622e

add changelog for distributed training
a4ab56b

Merge pull requestaws#18from xiaoxshe/main
d831bfd
add recipes into help menu and add changelog for distributed training recipes

change to public submodules
dc4879b

Merge pull requestaws#20from xiaoxshe/main
8c8ade9
change submodule to public repo of recipes

Remove custom_launcher folder
3f8698d

Merge pull requestaws#23from can-sun/delete-nemo
5a84b37
Remove custom_launcher folder

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:22 — with GitHub Actions Inactive

can-sun approved these changes Dec 4, 2024
View reviewed changes

haohanchen-aws approved these changes Dec 4, 2024
View reviewed changes

sync with mainline
b353254

xiaoxshe force-pushed the main branch from 14fd6da to b353254Compare December 4, 2024 15:33

xiaoxshe temporarily deployed to auto-approve December 4, 2024 15:34 — with GitHub Actions Inactive

ArjunKrishnak approved these changes Dec 4, 2024
View reviewed changes

xiaoxshe merged commit bb25aed into aws:mainDec 4, 2024

nargokul pushed a commit that referenced this pull request Jul 10, 2025
Merge pull request#41from zhaoqizqwang/add-inference-classes
6acb6f6
Fix bugs for inference endpoint

Uh oh!

Conversation

xiaoxshe commented Dec 4, 2024

PR Approval Steps

For Requester

For Reviewer

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xiaoxshe commented Dec 4, 2024

PR Approval Steps

For Requester

For Reviewer

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xiaoxshe commented Dec 4, 2024

PR Approval Steps

For Requester

For Reviewer

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xiaoxshe commented Dec 4, 2024

PR Approval Steps

For Requester

For Reviewer

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xiaoxshe commented Dec 4, 2024

PR Approval Steps

For Requester

For Reviewer

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xiaoxshe commented Dec 4, 2024

PR Approval Steps

For Requester