[v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

Description

@humanzz

PySDK Version

  • PySDK V2 (2.x)
  • PySDK V3 (3.x)

Additional context

The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


Describe the bug

Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

System information

  • SageMaker Python SDK version: 3.7.1
  • Framework name: PyTorch
  • Framework version: 2.10
  • Python version: 3.13
  • CPU or GPU: Both
  • Custom Docker image: N

Bug 1: wait=True does not respect sagemaker session

Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

To reproduce:

importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
creds=assumed["Credentials"]
assumed_session=boto3.Session(
aws_access_key_id=creds["AccessKeyId"],
aws_secret_access_key=creds["SecretAccessKey"],
aws_session_token=creds["SessionToken"],
region_name="us-west-2",
)
sm_session=Session(boto_session=assumed_session)
# FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
command=["python3"],
role="arn:aws:iam::123456789:role/MyRole",
instance_count=1,
instance_type="ml.m5.xlarge",
sagemaker_session=sm_session,
)
processor.run(code="my_script.py", source_dir="src", wait=True)
# → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
role="arn:aws:iam::123456789:role/MyRole",
source_code=SourceCode(entry_script="train.py", source_dir="src"),
compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
sagemaker_session=sm_session,
)
trainer.train(wait=True)
# → NoCredentialsError

Root cause (sagemaker/core/resources.py):

# ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

v2 behaviourProcessingJob.wait() used the session directly:

defwait(self, logs=True):
iflogs:
self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
else:
self.sagemaker_session.wait_for_processing_job(self.job_name)

Bug 2: FrameworkProcessor.code_location is accepted but ignored

FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

To reproduce:

processor=FrameworkProcessor(
image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
command=["python3"],
role="arn:aws:iam::123456789:role/MyRole",
instance_count=1,
instance_type="ml.m5.xlarge",
code_location="s3://my-custom-bucket", # ← ignored
)
processor.run(code="my_script.py", source_dir="src", wait=False)
# Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

s3_uri=s3.s3_path_join(
"s3://",
self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
job_name, "source", "sourcedir.tar.gz",
)

self.code_location is never referenced.

v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

# v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
...
code_location=self.code_location,
...
)

Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

  1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
  2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


Bug 3: CodeArtifact support missing from FrameworkProcessor

In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

To reproduce:

processor=FrameworkProcessor(
image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
command=["python3"],
role="arn:aws:iam::123456789:role/MyRole",
instance_count=1,
instance_type="ml.m5.xlarge",
)
# v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
# Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
fi
pip install -r requirements.txt
fi

Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

The v3 sm_train.sh template for requirements installation is a bare pip install:

# from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

To reproduce:

fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
role="arn:aws:iam::123456789:role/MyRole",
source_code=SourceCode(
entry_script="train.py",
source_dir="src",
requirements="requirements.txt", # ← installed without CodeArtifact
),
compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
)
trainer.train(wait=False)
# Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
       blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      
      Skip to content

      [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

      Description

      @humanzz

      PySDK Version

      • PySDK V2 (2.x)
      • PySDK V3 (3.x)

      Additional context

      The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


      Describe the bug

      Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

      System information

      • SageMaker Python SDK version: 3.7.1
      • Framework name: PyTorch
      • Framework version: 2.10
      • Python version: 3.13
      • CPU or GPU: Both
      • Custom Docker image: N

      Bug 1: wait=True does not respect sagemaker session

      Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

      ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

      To reproduce:

      importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
      assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
      creds=assumed["Credentials"]
      assumed_session=boto3.Session(
      aws_access_key_id=creds["AccessKeyId"],
      aws_secret_access_key=creds["SecretAccessKey"],
      aws_session_token=creds["SessionToken"],
      region_name="us-west-2",
      )
      sm_session=Session(boto_session=assumed_session)
      # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
      image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
      command=["python3"],
      role="arn:aws:iam::123456789:role/MyRole",
      instance_count=1,
      instance_type="ml.m5.xlarge",
      sagemaker_session=sm_session,
      )
      processor.run(code="my_script.py", source_dir="src", wait=True)
      # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
      training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
      role="arn:aws:iam::123456789:role/MyRole",
      source_code=SourceCode(entry_script="train.py", source_dir="src"),
      compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
      sagemaker_session=sm_session,
      )
      trainer.train(wait=True)
      # → NoCredentialsError

      Root cause (sagemaker/core/resources.py):

      # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

      v2 behaviourProcessingJob.wait() used the session directly:

      defwait(self, logs=True):
      iflogs:
      self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
      else:
      self.sagemaker_session.wait_for_processing_job(self.job_name)

      Bug 2: FrameworkProcessor.code_location is accepted but ignored

      FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

      To reproduce:

      processor=FrameworkProcessor(
      image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
      command=["python3"],
      role="arn:aws:iam::123456789:role/MyRole",
      instance_count=1,
      instance_type="ml.m5.xlarge",
      code_location="s3://my-custom-bucket", # ← ignored
      )
      processor.run(code="my_script.py", source_dir="src", wait=False)
      # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

      Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

      s3_uri=s3.s3_path_join(
      "s3://",
      self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
      job_name, "source", "sourcedir.tar.gz",
      )

      self.code_location is never referenced.

      v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

      # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
      ...
      code_location=self.code_location,
      ...
      )

      Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


      Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

      1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
      2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

      For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


      Bug 3: CodeArtifact support missing from FrameworkProcessor

      In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

      In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

      To reproduce:

      processor=FrameworkProcessor(
      image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
      command=["python3"],
      role="arn:aws:iam::123456789:role/MyRole",
      instance_count=1,
      instance_type="ml.m5.xlarge",
      )
      # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
      # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

      v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

      if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
      aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
      fi
      pip install -r requirements.txt
      fi

      Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


      Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

      Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

      ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

      The v3 sm_train.sh template for requirements installation is a bare pip install:

      # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

      It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

      To reproduce:

      fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
      training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
      role="arn:aws:iam::123456789:role/MyRole",
      source_code=SourceCode(
      entry_script="train.py",
      source_dir="src",
      requirements="requirements.txt", # ← installed without CodeArtifact
      ),
      compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
      environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
      )
      trainer.train(wait=False)
      # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

      v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

      Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

          Description

          @humanzz

          PySDK Version

          • PySDK V2 (2.x)
          • PySDK V3 (3.x)

          Additional context

          The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


          Describe the bug

          Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

          System information

          • SageMaker Python SDK version: 3.7.1
          • Framework name: PyTorch
          • Framework version: 2.10
          • Python version: 3.13
          • CPU or GPU: Both
          • Custom Docker image: N

          Bug 1: wait=True does not respect sagemaker session

          Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

          ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

          To reproduce:

          importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
          assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
          creds=assumed["Credentials"]
          assumed_session=boto3.Session(
          aws_access_key_id=creds["AccessKeyId"],
          aws_secret_access_key=creds["SecretAccessKey"],
          aws_session_token=creds["SessionToken"],
          region_name="us-west-2",
          )
          sm_session=Session(boto_session=assumed_session)
          # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
          image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
          command=["python3"],
          role="arn:aws:iam::123456789:role/MyRole",
          instance_count=1,
          instance_type="ml.m5.xlarge",
          sagemaker_session=sm_session,
          )
          processor.run(code="my_script.py", source_dir="src", wait=True)
          # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
          training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
          role="arn:aws:iam::123456789:role/MyRole",
          source_code=SourceCode(entry_script="train.py", source_dir="src"),
          compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
          sagemaker_session=sm_session,
          )
          trainer.train(wait=True)
          # → NoCredentialsError

          Root cause (sagemaker/core/resources.py):

          # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

          v2 behaviourProcessingJob.wait() used the session directly:

          defwait(self, logs=True):
          iflogs:
          self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
          else:
          self.sagemaker_session.wait_for_processing_job(self.job_name)

          Bug 2: FrameworkProcessor.code_location is accepted but ignored

          FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

          To reproduce:

          processor=FrameworkProcessor(
          image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
          command=["python3"],
          role="arn:aws:iam::123456789:role/MyRole",
          instance_count=1,
          instance_type="ml.m5.xlarge",
          code_location="s3://my-custom-bucket", # ← ignored
          )
          processor.run(code="my_script.py", source_dir="src", wait=False)
          # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

          Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

          s3_uri=s3.s3_path_join(
          "s3://",
          self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
          job_name, "source", "sourcedir.tar.gz",
          )

          self.code_location is never referenced.

          v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

          # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
          ...
          code_location=self.code_location,
          ...
          )

          Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


          Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

          1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
          2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

          For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


          Bug 3: CodeArtifact support missing from FrameworkProcessor

          In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

          In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

          To reproduce:

          processor=FrameworkProcessor(
          image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
          command=["python3"],
          role="arn:aws:iam::123456789:role/MyRole",
          instance_count=1,
          instance_type="ml.m5.xlarge",
          )
          # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
          # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

          v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

          if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
          aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
          fi
          pip install -r requirements.txt
          fi

          Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


          Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

          Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

          ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

          The v3 sm_train.sh template for requirements installation is a bare pip install:

          # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

          It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

          To reproduce:

          fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
          training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
          role="arn:aws:iam::123456789:role/MyRole",
          source_code=SourceCode(
          entry_script="train.py",
          source_dir="src",
          requirements="requirements.txt", # ← installed without CodeArtifact
          ),
          compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
          environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
          )
          trainer.train(wait=False)
          # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

          v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

          Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

              Description

              @humanzz

              PySDK Version

              • PySDK V2 (2.x)
              • PySDK V3 (3.x)

              Additional context

              The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


              Describe the bug

              Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

              System information

              • SageMaker Python SDK version: 3.7.1
              • Framework name: PyTorch
              • Framework version: 2.10
              • Python version: 3.13
              • CPU or GPU: Both
              • Custom Docker image: N

              Bug 1: wait=True does not respect sagemaker session

              Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

              ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

              To reproduce:

              importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
              assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
              creds=assumed["Credentials"]
              assumed_session=boto3.Session(
              aws_access_key_id=creds["AccessKeyId"],
              aws_secret_access_key=creds["SecretAccessKey"],
              aws_session_token=creds["SessionToken"],
              region_name="us-west-2",
              )
              sm_session=Session(boto_session=assumed_session)
              # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
              image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
              command=["python3"],
              role="arn:aws:iam::123456789:role/MyRole",
              instance_count=1,
              instance_type="ml.m5.xlarge",
              sagemaker_session=sm_session,
              )
              processor.run(code="my_script.py", source_dir="src", wait=True)
              # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
              training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
              role="arn:aws:iam::123456789:role/MyRole",
              source_code=SourceCode(entry_script="train.py", source_dir="src"),
              compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
              sagemaker_session=sm_session,
              )
              trainer.train(wait=True)
              # → NoCredentialsError

              Root cause (sagemaker/core/resources.py):

              # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

              v2 behaviourProcessingJob.wait() used the session directly:

              defwait(self, logs=True):
              iflogs:
              self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
              else:
              self.sagemaker_session.wait_for_processing_job(self.job_name)

              Bug 2: FrameworkProcessor.code_location is accepted but ignored

              FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

              To reproduce:

              processor=FrameworkProcessor(
              image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
              command=["python3"],
              role="arn:aws:iam::123456789:role/MyRole",
              instance_count=1,
              instance_type="ml.m5.xlarge",
              code_location="s3://my-custom-bucket", # ← ignored
              )
              processor.run(code="my_script.py", source_dir="src", wait=False)
              # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

              Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

              s3_uri=s3.s3_path_join(
              "s3://",
              self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
              job_name, "source", "sourcedir.tar.gz",
              )

              self.code_location is never referenced.

              v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

              # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
              ...
              code_location=self.code_location,
              ...
              )

              Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


              Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

              1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
              2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

              For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


              Bug 3: CodeArtifact support missing from FrameworkProcessor

              In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

              In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

              To reproduce:

              processor=FrameworkProcessor(
              image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
              command=["python3"],
              role="arn:aws:iam::123456789:role/MyRole",
              instance_count=1,
              instance_type="ml.m5.xlarge",
              )
              # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
              # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

              v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

              if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
              aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
              fi
              pip install -r requirements.txt
              fi

              Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


              Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

              Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

              ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

              The v3 sm_train.sh template for requirements installation is a bare pip install:

              # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

              It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

              To reproduce:

              fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
              training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
              role="arn:aws:iam::123456789:role/MyRole",
              source_code=SourceCode(
              entry_script="train.py",
              source_dir="src",
              requirements="requirements.txt", # ← installed without CodeArtifact
              ),
              compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
              environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
              )
              trainer.train(wait=False)
              # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

              v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

              Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

                  Description

                  @humanzz

                  PySDK Version

                  • PySDK V2 (2.x)
                  • PySDK V3 (3.x)

                  Additional context

                  The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


                  Describe the bug

                  Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

                  System information

                  • SageMaker Python SDK version: 3.7.1
                  • Framework name: PyTorch
                  • Framework version: 2.10
                  • Python version: 3.13
                  • CPU or GPU: Both
                  • Custom Docker image: N

                  Bug 1: wait=True does not respect sagemaker session

                  Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

                  ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

                  To reproduce:

                  importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
                  assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
                  creds=assumed["Credentials"]
                  assumed_session=boto3.Session(
                  aws_access_key_id=creds["AccessKeyId"],
                  aws_secret_access_key=creds["SecretAccessKey"],
                  aws_session_token=creds["SessionToken"],
                  region_name="us-west-2",
                  )
                  sm_session=Session(boto_session=assumed_session)
                  # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
                  image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                  command=["python3"],
                  role="arn:aws:iam::123456789:role/MyRole",
                  instance_count=1,
                  instance_type="ml.m5.xlarge",
                  sagemaker_session=sm_session,
                  )
                  processor.run(code="my_script.py", source_dir="src", wait=True)
                  # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
                  training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                  role="arn:aws:iam::123456789:role/MyRole",
                  source_code=SourceCode(entry_script="train.py", source_dir="src"),
                  compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                  sagemaker_session=sm_session,
                  )
                  trainer.train(wait=True)
                  # → NoCredentialsError

                  Root cause (sagemaker/core/resources.py):

                  # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

                  v2 behaviourProcessingJob.wait() used the session directly:

                  defwait(self, logs=True):
                  iflogs:
                  self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
                  else:
                  self.sagemaker_session.wait_for_processing_job(self.job_name)

                  Bug 2: FrameworkProcessor.code_location is accepted but ignored

                  FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

                  To reproduce:

                  processor=FrameworkProcessor(
                  image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                  command=["python3"],
                  role="arn:aws:iam::123456789:role/MyRole",
                  instance_count=1,
                  instance_type="ml.m5.xlarge",
                  code_location="s3://my-custom-bucket", # ← ignored
                  )
                  processor.run(code="my_script.py", source_dir="src", wait=False)
                  # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

                  Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

                  s3_uri=s3.s3_path_join(
                  "s3://",
                  self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
                  job_name, "source", "sourcedir.tar.gz",
                  )

                  self.code_location is never referenced.

                  v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

                  # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
                  ...
                  code_location=self.code_location,
                  ...
                  )

                  Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


                  Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

                  1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
                  2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

                  For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


                  Bug 3: CodeArtifact support missing from FrameworkProcessor

                  In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

                  In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

                  To reproduce:

                  processor=FrameworkProcessor(
                  image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                  command=["python3"],
                  role="arn:aws:iam::123456789:role/MyRole",
                  instance_count=1,
                  instance_type="ml.m5.xlarge",
                  )
                  # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
                  # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

                  v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

                  if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
                  aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
                  fi
                  pip install -r requirements.txt
                  fi

                  Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


                  Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

                  Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

                  ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

                  The v3 sm_train.sh template for requirements installation is a bare pip install:

                  # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

                  It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

                  To reproduce:

                  fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
                  training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                  role="arn:aws:iam::123456789:role/MyRole",
                  source_code=SourceCode(
                  entry_script="train.py",
                  source_dir="src",
                  requirements="requirements.txt", # ← installed without CodeArtifact
                  ),
                  compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                  environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
                  )
                  trainer.train(wait=False)
                  # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

                  v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

                  Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

                      Description

                      @humanzz

                      PySDK Version

                      • PySDK V2 (2.x)
                      • PySDK V3 (3.x)

                      Additional context

                      The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


                      Describe the bug

                      Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

                      System information

                      • SageMaker Python SDK version: 3.7.1
                      • Framework name: PyTorch
                      • Framework version: 2.10
                      • Python version: 3.13
                      • CPU or GPU: Both
                      • Custom Docker image: N

                      Bug 1: wait=True does not respect sagemaker session

                      Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

                      ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

                      To reproduce:

                      importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
                      assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
                      creds=assumed["Credentials"]
                      assumed_session=boto3.Session(
                      aws_access_key_id=creds["AccessKeyId"],
                      aws_secret_access_key=creds["SecretAccessKey"],
                      aws_session_token=creds["SessionToken"],
                      region_name="us-west-2",
                      )
                      sm_session=Session(boto_session=assumed_session)
                      # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
                      image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                      command=["python3"],
                      role="arn:aws:iam::123456789:role/MyRole",
                      instance_count=1,
                      instance_type="ml.m5.xlarge",
                      sagemaker_session=sm_session,
                      )
                      processor.run(code="my_script.py", source_dir="src", wait=True)
                      # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
                      training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                      role="arn:aws:iam::123456789:role/MyRole",
                      source_code=SourceCode(entry_script="train.py", source_dir="src"),
                      compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                      sagemaker_session=sm_session,
                      )
                      trainer.train(wait=True)
                      # → NoCredentialsError

                      Root cause (sagemaker/core/resources.py):

                      # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

                      v2 behaviourProcessingJob.wait() used the session directly:

                      defwait(self, logs=True):
                      iflogs:
                      self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
                      else:
                      self.sagemaker_session.wait_for_processing_job(self.job_name)

                      Bug 2: FrameworkProcessor.code_location is accepted but ignored

                      FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

                      To reproduce:

                      processor=FrameworkProcessor(
                      image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                      command=["python3"],
                      role="arn:aws:iam::123456789:role/MyRole",
                      instance_count=1,
                      instance_type="ml.m5.xlarge",
                      code_location="s3://my-custom-bucket", # ← ignored
                      )
                      processor.run(code="my_script.py", source_dir="src", wait=False)
                      # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

                      Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

                      s3_uri=s3.s3_path_join(
                      "s3://",
                      self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
                      job_name, "source", "sourcedir.tar.gz",
                      )

                      self.code_location is never referenced.

                      v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

                      # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
                      ...
                      code_location=self.code_location,
                      ...
                      )

                      Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


                      Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

                      1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
                      2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

                      For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


                      Bug 3: CodeArtifact support missing from FrameworkProcessor

                      In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

                      In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

                      To reproduce:

                      processor=FrameworkProcessor(
                      image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                      command=["python3"],
                      role="arn:aws:iam::123456789:role/MyRole",
                      instance_count=1,
                      instance_type="ml.m5.xlarge",
                      )
                      # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
                      # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

                      v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

                      if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
                      aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
                      fi
                      pip install -r requirements.txt
                      fi

                      Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


                      Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

                      Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

                      ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

                      The v3 sm_train.sh template for requirements installation is a bare pip install:

                      # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

                      It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

                      To reproduce:

                      fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
                      training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                      role="arn:aws:iam::123456789:role/MyRole",
                      source_code=SourceCode(
                      entry_script="train.py",
                      source_dir="src",
                      requirements="requirements.txt", # ← installed without CodeArtifact
                      ),
                      compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                      environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
                      )
                      trainer.train(wait=False)
                      # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

                      v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

                      Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

                          Description

                          @humanzz

                          PySDK Version

                          • PySDK V2 (2.x)
                          • PySDK V3 (3.x)

                          Additional context

                          The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


                          Describe the bug

                          Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

                          System information

                          • SageMaker Python SDK version: 3.7.1
                          • Framework name: PyTorch
                          • Framework version: 2.10
                          • Python version: 3.13
                          • CPU or GPU: Both
                          • Custom Docker image: N

                          Bug 1: wait=True does not respect sagemaker session

                          Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

                          ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

                          To reproduce:

                          importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
                          assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
                          creds=assumed["Credentials"]
                          assumed_session=boto3.Session(
                          aws_access_key_id=creds["AccessKeyId"],
                          aws_secret_access_key=creds["SecretAccessKey"],
                          aws_session_token=creds["SessionToken"],
                          region_name="us-west-2",
                          )
                          sm_session=Session(boto_session=assumed_session)
                          # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
                          image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                          command=["python3"],
                          role="arn:aws:iam::123456789:role/MyRole",
                          instance_count=1,
                          instance_type="ml.m5.xlarge",
                          sagemaker_session=sm_session,
                          )
                          processor.run(code="my_script.py", source_dir="src", wait=True)
                          # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
                          training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                          role="arn:aws:iam::123456789:role/MyRole",
                          source_code=SourceCode(entry_script="train.py", source_dir="src"),
                          compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                          sagemaker_session=sm_session,
                          )
                          trainer.train(wait=True)
                          # → NoCredentialsError

                          Root cause (sagemaker/core/resources.py):

                          # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

                          v2 behaviourProcessingJob.wait() used the session directly:

                          defwait(self, logs=True):
                          iflogs:
                          self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
                          else:
                          self.sagemaker_session.wait_for_processing_job(self.job_name)

                          Bug 2: FrameworkProcessor.code_location is accepted but ignored

                          FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

                          To reproduce:

                          processor=FrameworkProcessor(
                          image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                          command=["python3"],
                          role="arn:aws:iam::123456789:role/MyRole",
                          instance_count=1,
                          instance_type="ml.m5.xlarge",
                          code_location="s3://my-custom-bucket", # ← ignored
                          )
                          processor.run(code="my_script.py", source_dir="src", wait=False)
                          # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

                          Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

                          s3_uri=s3.s3_path_join(
                          "s3://",
                          self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
                          job_name, "source", "sourcedir.tar.gz",
                          )

                          self.code_location is never referenced.

                          v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

                          # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
                          ...
                          code_location=self.code_location,
                          ...
                          )

                          Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


                          Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

                          1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
                          2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

                          For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


                          Bug 3: CodeArtifact support missing from FrameworkProcessor

                          In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

                          In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

                          To reproduce:

                          processor=FrameworkProcessor(
                          image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                          command=["python3"],
                          role="arn:aws:iam::123456789:role/MyRole",
                          instance_count=1,
                          instance_type="ml.m5.xlarge",
                          )
                          # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
                          # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

                          v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

                          if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
                          aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
                          fi
                          pip install -r requirements.txt
                          fi

                          Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


                          Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

                          Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

                          ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

                          The v3 sm_train.sh template for requirements installation is a bare pip install:

                          # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

                          It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

                          To reproduce:

                          fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
                          training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                          role="arn:aws:iam::123456789:role/MyRole",
                          source_code=SourceCode(
                          entry_script="train.py",
                          source_dir="src",
                          requirements="requirements.txt", # ← installed without CodeArtifact
                          ),
                          compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                          environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
                          )
                          trainer.train(wait=False)
                          # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

                          v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

                          Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              [v3] FrameworkProcessor and ModelTrainer: 4 regressions (including dropping CodeArtifact support) from v2 migration #5765

                              Description

                              @humanzz

                              PySDK Version

                              • PySDK V2 (2.x)
                              • PySDK V3 (3.x)

                              Additional context

                              The following four issues were found during a migration from sagemaker==2.257.1 to sagemaker==3.7.1, moving training jobs from sagemaker.pytorch.PyTorch to sagemaker.train.ModelTrainer and processing jobs from sagemaker.pytorch.processing.PyTorchProcessor to sagemaker.core.processing.FrameworkProcessor.


                              Describe the bug

                              Four regressions found when migrating from v2 to v3, specifically around FrameworkProcessor (processing jobs) and ModelTrainer (training jobs). All four worked correctly in v2.

                              System information

                              • SageMaker Python SDK version: 3.7.1
                              • Framework name: PyTorch
                              • Framework version: 2.10
                              • Python version: 3.13
                              • CPU or GPU: Both
                              • Custom Docker image: N

                              Bug 1: wait=True does not respect sagemaker session

                              Affects:ModelTrainer.train(wait=True) and FrameworkProcessor.run(wait=True)

                              ProcessingJob.refresh() and TrainingJob.refresh() use Base.get_sagemaker_client() — a global/default client — instead of the sagemaker_session passed to the processor/trainer. This fails with NoCredentialsError when using assumed-role sessions (via STS).

                              To reproduce:

                              importboto3fromsagemaker.core.helper.session_helperimportSessionfromsagemaker.core.processingimportFrameworkProcessorfromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCode# Assumed-role sessionsts=boto3.client("sts")
                              assumed=sts.assume_role(RoleArn="arn:aws:iam::123456789:role/MyRole", RoleSessionName="test")
                              creds=assumed["Credentials"]
                              assumed_session=boto3.Session(
                              aws_access_key_id=creds["AccessKeyId"],
                              aws_secret_access_key=creds["SecretAccessKey"],
                              aws_session_token=creds["SessionToken"],
                              region_name="us-west-2",
                              )
                              sm_session=Session(boto_session=assumed_session)
                              # FrameworkProcessor — job created OK, wait failsprocessor=FrameworkProcessor(
                              image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                              command=["python3"],
                              role="arn:aws:iam::123456789:role/MyRole",
                              instance_count=1,
                              instance_type="ml.m5.xlarge",
                              sagemaker_session=sm_session,
                              )
                              processor.run(code="my_script.py", source_dir="src", wait=True)
                              # → NoCredentialsError# ModelTrainer — same issuetrainer=ModelTrainer(
                              training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                              role="arn:aws:iam::123456789:role/MyRole",
                              source_code=SourceCode(entry_script="train.py", source_dir="src"),
                              compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                              sagemaker_session=sm_session,
                              )
                              trainer.train(wait=True)
                              # → NoCredentialsError

                              Root cause (sagemaker/core/resources.py):

                              # ProcessingJob.refresh() / TrainingJob.refresh()client=Base.get_sagemaker_client() # ← ignores the sessionresponse=client.describe_processing_job(**operation_input_args)

                              v2 behaviourProcessingJob.wait() used the session directly:

                              defwait(self, logs=True):
                              iflogs:
                              self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
                              else:
                              self.sagemaker_session.wait_for_processing_job(self.job_name)

                              Bug 2: FrameworkProcessor.code_location is accepted but ignored

                              FrameworkProcessor.__init__ accepts code_location and stores it as self.code_location. The docstring states it controls where code is uploaded. However, _package_code ignores it and always uploads to self.sagemaker_session.default_bucket().

                              To reproduce:

                              processor=FrameworkProcessor(
                              image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                              command=["python3"],
                              role="arn:aws:iam::123456789:role/MyRole",
                              instance_count=1,
                              instance_type="ml.m5.xlarge",
                              code_location="s3://my-custom-bucket", # ← ignored
                              )
                              processor.run(code="my_script.py", source_dir="src", wait=False)
                              # Code uploads to s3://sagemaker-us-west-2-123456789/... instead of s3://my-custom-bucket/...

                              Root cause (sagemaker-core/src/sagemaker/core/processing.py, _package_code):

                              s3_uri=s3.s3_path_join(
                              "s3://",
                              self.sagemaker_session.default_bucket(), # ← always uses default bucketself.sagemaker_session.default_bucket_prefixor"",
                              job_name, "source", "sourcedir.tar.gz",
                              )

                              self.code_location is never referenced.

                              v2 behaviourFrameworkProcessor delegated to an estimator that honored code_location:

                              # v2 FrameworkProcessor._create_estimatorreturnself.estimator_cls(
                              ...
                              code_location=self.code_location,
                              ...
                              )

                              Note:ModelTrainer does not offer code_location at all — it always uses session.default_bucket(). Suggested fix: either remove code_location from FrameworkProcessor to align with ModelTrainer, or update _package_code to use it when set.


                              Bugs 3 and 4 are both about losing the ability to install requirements.txt dependencies from a CodeArtifact repository.

                              1. PyTorch training and inference containers supported this via the CA_REPOSITORY_ARN environment variable (see [feature-request] Support installing dependencies in requirements.txt from CodeArtifact for both training/inference SageMaker Containers deep-learning-containers#2509 for details)
                              2. feature: Add optional CodeArtifact login to FrameworkProcessing job script #4145 extended that support to processing jobs by exposing codeartifact_repo_arn on FrameworkProcessor.run()

                              For context, the new ray-based inference containers are also adding codeartifact support via CA_REPOSITORY_ARN environment variable as can be seen in https://github.com/aws/deep-learning-containers/blob/0fc07f317a4db68ff728274070fbe332dde1ca26/scripts/ray/sagemaker_serve.py#L68


                              Bug 3: CodeArtifact support missing from FrameworkProcessor

                              In v2, FrameworkProcessor.run() accepted codeartifact_repo_arn (added in PR #4145). This configured pip inside the container to authenticate with CodeArtifact before installing requirements.txt.

                              In v3, FrameworkProcessor.run() does not accept codeartifact_repo_arn, and _generate_framework_script has no CodeArtifact support. The generated runproc.sh runs pip install -r requirements.txt without authentication, failing for packages hosted on private CodeArtifact repositories.

                              To reproduce:

                              processor=FrameworkProcessor(
                              image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                              command=["python3"],
                              role="arn:aws:iam::123456789:role/MyRole",
                              instance_count=1,
                              instance_type="ml.m5.xlarge",
                              )
                              # v2 supported: processor.run(..., codeartifact_repo_arn="arn:aws:codeartifact:us-west-2:123:repository/domain/repo")# v3 does not — parameter doesn't existprocessor.run(code="my_script.py", source_dir="src", wait=False)
                              # Container fails: pip install -r requirements.txt → package not found (private CodeArtifact repo)

                              v2 behaviour_generate_framework_script injected CodeArtifact login into runproc.sh:

                              if [[ -f'requirements.txt' ]];thenif!hash aws 2>/dev/null;thenecho"AWS CLI is not installed. Skipping CodeArtifact login."else
                              aws codeartifact login --tool pip --domain {domain} --domain-owner {owner} --repository {repository} --region {region}
                              fi
                              pip install -r requirements.txt
                              fi

                              Suggested fix: Port codeartifact_repo_arn and _get_codeartifact_command from v2's PR #4145 into v3's FrameworkProcessor.


                              Bug 4: ModelTrainer bypasses sagemaker-training-toolkit, losing CodeArtifact support for requirements.txt

                              Affects:ModelTrainer.train() with SourceCode(requirements="requirements.txt")

                              ModelTrainer overrides the container's ENTRYPOINT with its own sm_train.sh driver script. This bypasses the sagemaker-training-toolkit installed in the container, which handled requirements.txt installation with CodeArtifact support (via the CA_REPOSITORY_ARN environment variable, added in sagemaker-training-toolkit#187).

                              The v3 sm_train.sh template for requirements installation is a bare pip install:

                              # from sagemaker.train.templates.INSTALL_REQUIREMENTSecho"Installing requirements"$SM_PIP_CMD install -r {requirements_file}

                              It does not check for CA_REPOSITORY_ARN or configure pip to use CodeArtifact. The env var is passed to the container but nothing reads it.

                              To reproduce:

                              fromsagemaker.trainimportModelTrainerfromsagemaker.core.training.configsimportCompute, SourceCodetrainer=ModelTrainer(
                              training_image="763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-training:2.10-cpu-py313",
                              role="arn:aws:iam::123456789:role/MyRole",
                              source_code=SourceCode(
                              entry_script="train.py",
                              source_dir="src",
                              requirements="requirements.txt", # ← installed without CodeArtifact
                              ),
                              compute=Compute(instance_type="ml.m5.xlarge", instance_count=1),
                              environment={"CA_REPOSITORY_ARN": "arn:aws:codeartifact:us-west-2:123:repository/domain/repo"},
                              )
                              trainer.train(wait=False)
                              # Container runs: pip install -r requirements.txt (using public PyPI, not CodeArtifact)# Fails in VPC-isolated environments where PyPI is unreachable

                              v2 behaviour — the PyTorch estimator used the container's native entrypoint, which invoked sagemaker-training-toolkit. The toolkit checked CA_REPOSITORY_ARN, ran aws codeartifact login --tool pip, then installed requirements. This was added in sagemaker-training-toolkit v4.7.0 and tracked in deep-learning-containers#2509.

                              Suggested fix: The INSTALL_REQUIREMENTS template in sagemaker.train.templates should check for CA_REPOSITORY_ARN and configure pip accordingly before installing, matching the behaviour of sagemaker-training-toolkit.

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions