Use custom user agent string at all times

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.

[laurenyu]

The previous implementation allowed for our user agent string to be overridden if the user supplied a boto3 session, SageMaker client, or SageMaker runtime client.

[owen-t]

The user agent string construction should be in its own module. It's right to construct it at import time though.

The module could expose a function that returns the user agent string, built at line 84 and 85 of session.py in this PR.

[owen-t]

If no OS name can be resolved, platform.system() will return an empty string. Can this be something like:

OS_NAME = platform.system() or 'UnresolvedOS'

Same for OS_VERSION

[laurenyu]

done. Also moved everything to a new module.

[owen-t]

Is there a reason we don't preserve the original user agent string as well. Why not just append the SageMaker string to the end?

[laurenyu]

The default user agent string is 'Boto3/1.4.8 Python/3.6.3 Darwin/15.6.0 Botocore/1.8.6', which is why I just added the Boto and Botocore versions to the end. It needs to start with 'AWS-SageMaker' and be followed by 'language/version OS/version' for parsing. Appending the original user agent string here is a good call, though.