Skip to content

Fix "ValueError: too many values to unpack (expected 2)" is occurred in windows local mode#1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurenyu merged 7 commits into from
Dec 9, 2019
Merged

Fix "ValueError: too many values to unpack (expected 2)" is occurred in windows local mode #1125

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9091802
Fix aws#847
Nov 18, 2019
d097e52
Fix on regular expression
Nov 19, 2019
643a520
Merge branch 'master' into master
chuyang-deng Dec 2, 2019
f9fc3fe
Merge branch 'master' into master
laurenyu Dec 2, 2019
19e5163
Merge branch 'master' into master
manvento Dec 5, 2019
91e9ce2
Merge remote-tracking branch 'sagemaker-original/master'
Dec 9, 2019
266d027
Merge branch 'master' into master
laurenyu Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/sagemaker/local/image.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,7 +43,6 @@
DOCKER_COMPOSE_HTTP_TIMEOUT_ENV = "COMPOSE_HTTP_TIMEOUT"
DOCKER_COMPOSE_HTTP_TIMEOUT = "120"


# Environment variables to be set during training
REGION_ENV_NAME = "AWS_REGION"
TRAINING_JOB_NAME_ENV_NAME = "TRAINING_JOB_NAME"
Expand DownExpand Up@@ -256,7 +255,11 @@ def retrieve_artifacts(self, compose_data, output_data_config, job_name):
for host in self.hosts:
volumes = compose_data["services"][str(host)]["volumes"]
for volume in volumes:
host_dir, container_dir = volume.split(":")
if re.search(r"^[A-Za-z]:", volume):
unit, host_dir, container_dir = volume.split(":")
host_dir = unit + ":" + host_dir
else:
host_dir, container_dir = volume.split(":")
if container_dir == "/opt/ml/model":
sagemaker.local.utils.recursive_copy(host_dir, model_artifacts)
elif container_dir == "/opt/ml/output":
Expand DownExpand Up@@ -639,9 +642,7 @@ def __init__(self, host_dir, container_dir=None, channel=None):
if container_dir and channel:
raise ValueError("container_dir and channel cannot be declared together.")

self.container_dir = (
container_dir if container_dir else os.path.join("/opt/ml/input/data", channel)
)
self.container_dir = container_dir if container_dir else "/opt/ml/input/data/" + channel
self.host_dir = host_dir
if platform.system() == "Darwin" and host_dir.startswith("/var"):
self.host_dir = os.path.join("/private", host_dir)
Expand Down