Skip to content

fix: use format strings instead of os.path.join for S3 URI in S3Downloader#1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurenyu merged 1 commit into from
May 21, 2020
Merged

fix: use format strings instead of os.path.join for S3 URI in S3Downloader #1520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/sagemaker/s3.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@
from __future__ import print_function, absolute_import

import logging
import os

from six.moves.urllib.parse import urlparse
from sagemaker.session import Session
Expand DownExpand Up@@ -184,4 +183,4 @@ def list(s3_uri, session=None):
bucket, key_prefix = parse_s3_url(url=s3_uri)

file_keys = sagemaker_session.list_s3_files(bucket=bucket, key_prefix=key_prefix)
return [os.path.join("s3://", bucket, file_key) for file_key in file_keys]
return ["s3://{}/{}".format(bucket, file_key) for file_key in file_keys]