feature: Support for multi variant endpoint invocation with target variant param - #1571

Merged
chuyang-deng merged 1 commit into
aws:masterfrom
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged

feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom
aakashpydi:feature-invocation-with-target-variant

Conversation

@aakashpydi

@aakashpydiaakashpydi commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.

Testing done:

  • Unit Tests:

unt-tests

  • Integration tests:

integ-tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

chuyang-deng
chuyang-deng reviewed Jun 10, 2020
View reviewed changes

@chuyang-dengchuyang-deng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.

@sagemaker-bot

sagemaker-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@chuyang-deng
chuyang-deng merged commit b481c36 into aws:masterJun 10, 2020
chuyang-deng added a commit that referenced this pull request Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng mentioned this pull request Jun 11, 2020
Merged
chuyang-deng added a commit that referenced this pull request Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi mentioned this pull request Jun 11, 2020
Merged
7 tasks
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit that referenced this pull request Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit that referenced this pull request Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feature: Support for multi variant endpoint invocation with target variant param - #1571
Merged
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Jun 10, 2020
Merged
feature: Support for multi variant endpoint invocation with target variant param#1571
chuyang-deng merged 1 commit into
aws:masterfrom 
aakashpydi:feature-invocation-with-target-variant
Conversation
@aakashpydi
@aakashpydiaakashpydi
commented
Jun 10, 2020

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Add support for specifying a target variant parameter when invoking a SageMaker endpoint with multiple production variants.
Testing done:
  • Unit Tests:
unt-tests
  • Integration tests:
integ-tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to any/all clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
chuyang-deng
chuyang-deng
reviewed
Jun 10, 2020
View reviewed changes
@chuyang-dengchuyang-deng
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are tested in staging repo.
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jun 10, 2020

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 87f1920
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@chuyang-deng
chuyang-deng
merged commit b481c36
into
aws:masterJun 10, 2020
chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
7f59e14
…arget variant param (#1571)"
This reverts commit b481c36.
@chuyang-dengchuyang-deng
mentioned this pull request
Jun 11, 2020
 Merged

chuyang-deng added a commit
that referenced
this pull request
Jun 11, 2020
@chuyang-deng
Revert "feature: Support for multi variant endpoint invocation with t…
0bbcd07
…arget variant param (#1571)" (#1574)
This reverts commit b481c36.
@aakashpydiaakashpydi
mentioned this pull request
Jun 11, 2020
 Merged

7 tasks
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@aakashpydi@metrizable
feature: Support for multi variant endpoint invocation with target va…
fad5c0d
…riant param (aws#1571)
metrizable pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jun 15, 2020
@chuyang-deng@metrizable
Revert "feature: Support for multi variant endpoint invocation with t…
fb5d7a3
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
8cf9631
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
pintaoz-aws added a commit
that referenced
this pull request
Dec 4, 2024
@pintaoz-aws@erickb336
@nargokul@pravali96
Support building image from Dockerfile (#1571)
fcae9f7
* Base model trainer (#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (#1541)
* Cleanup ModelTrainer (#1542)
* General image builder (#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (#1552)
* feat: add pre-processing and post-processing logic to inference_spec (#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (#1536)
* Add path to set Additional Settings in ModelTrainer (#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
feature: Support for multi variant endpoint invocation with target va…
15766e9
…riant param (aws#1571)
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
Revert "feature: Support for multi variant endpoint invocation with t…
d8b2678
…arget variant param (aws#1571)" (aws#1574)
This reverts commit b481c36.
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@erickb336
@nargokul@pravali96
Support building image from Dockerfile (aws#1571)
a3d9e92
* Base model trainer (aws#1521)
* Base model trainer
* flake8
* add testing notebook
* add param validation & set defaults
* Implement simple train method
* feature: support script mode with local train.sh (aws#1523)
* feature: support script mode with local train.sh
* Stop tracking train.sh and add it to .gitignore
* update message
* make dir if not exist
* fix docs
* fix: docstyle
* Address comments
* fix hyperparams
* Revert pydantic custom error
* pylint
* Image Spec refactoring and updates (aws#1525)
* Image Spec refactoring and updates
* Unit tests and update function for Image Spec
* Fix hugging face test
* Fix Tests
* Add unit tests for ModelTrainer (aws#1527)
* Add unit tests for ModelTrainer
* Flake8
* format
* Add example notebook (aws#1528)
* Add testing notebook
* format
* use smaller data
* remove large dataset
* update
* pylint
* flake8
* ignore docstyle in directories with test
* format
* format
* Add enviornment variable bootstrapping script (aws#1530)
* Add enviornment variables scripts
* format
* fix comment
* add docstrings
* fix comment
* feature: add utility function to capture local snapshot (aws#1524)
* local snapshot
* Update pip list command
* Remove function calls
* Address comments
* Address comments
* Support intelligent parameters (aws#1540)
* Support intelligent parameters
* fix codestyle
* Revert Image Spec (aws#1541)
* Cleanup ModelTrainer (aws#1542)
* General image builder (aws#1546)
* General image builder
* General image builder
* Fix codestyle
* Fix codestyle
* Move location
* Add warnings
* Add integ tests
* Fix integ test
* Fix integ test
* Fix region error
* Add region
* Latest Container Image (aws#1545)
* Latest Container Image
* Test Fixes
* Parameterized tests and some logic updates
* Test fixes
* Move to Image URI
* Fixes for unit test
* Fixes for unit test
* Fix codestyle error checks
* Cleanup ModelTrainer code (aws#1552)
* feat: add pre-processing and post-processing logic to inference_spec (aws#1560)
* add pre-processing and post-processing logic to inference_spec
* fix format
* make accept_type and content_type optional
* remove accept_type and content_type from pre/post processing
* correct typo
* Add Distributed Training Support Model Trainer (aws#1536)
* Add path to set Additional Settings in ModelTrainer (aws#1555)
* Support building image from Dockerfile
* Fix test
* Fix test
* Rename functions
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Pravali Uppugunduri <46845440+pravali96@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@chuyang-dengchuyang-dengchuyang-deng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@aakashpydi@sagemaker-bot@chuyang-deng