Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.3k
breaking: Move _CsvDeserializer to sagemaker.deserializers and rename to CSVDeserializer#1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
05c8e61
Rename _CsvDeserializer to CSVDeserializer
29581bb
Address review comments
c393d9b
Merge branch 'zwei' into add-csv-deserializer
bveeramani 450e084
Merge branch 'zwei' into add-csv-deserializer
bveeramani d62cc8f
Address review comments
b5525a5
Merge branch 'add-csv-deserializer' of github.com:bveeramani/sagemake…
9ef4e9a
Merge branch 'zwei' into add-csv-deserializer
bveeramani 72fee9e
Merge branch 'zwei' into add-csv-deserializer
bveeramani 6bacb9e
Appease black check
f9217ba
Merge branch 'zwei' into add-csv-deserializer
5befbe5
Appease black format
b8b5ce6
Merge branch 'zwei' into add-csv-deserializer
bveeramani 6aabe77
Apease flake8
62263b7
Merge branch 'zwei' into add-csv-deserializer
bveeramani 5309fa7
Fix typo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -20,6 +20,7 @@ | ||
| from sagemaker.deserializers import ( | ||
| StringDeserializer, | ||
| BytesDeserializer, | ||
| CSVDeserializer, | ||
| StreamDeserializer, | ||
| NumpyDeserializer, | ||
| ) | ||
| @@ -41,6 +42,31 @@ def test_bytes_deserializer(): | ||
| assert result == b"[1, 2, 3]" | ||
| @pytest.fixture | ||
| def csv_deserializer(): | ||
| return CSVDeserializer() | ||
| def test_csv_deserializer_single_element(csv_deserializer): | ||
| result = csv_deserializer.deserialize(io.BytesIO(b"1"), "text/csv") | ||
| assert result == [["1"]] | ||
bveeramani marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| def test_csv_deserializer_array(csv_deserializer): | ||
| result = csv_deserializer.deserialize(io.BytesIO(b"1,2,3"), "text/csv") | ||
| assert result == [["1", "2", "3"]] | ||
| def test_csv_deserializer_2dimensional(csv_deserializer): | ||
| result = csv_deserializer.deserialize(io.BytesIO(b"1,2,3\n3,4,5"), "text/csv") | ||
| assert result == [["1", "2", "3"], ["3", "4", "5"]] | ||
| def test_csv_deserializer_posix_compliant(csv_deserializer): | ||
| result = csv_deserializer.deserialize(io.BytesIO(b"1,2,3\n3,4,5\n"), "text/csv") | ||
| assert result == [["1", "2", "3"], ["3", "4", "5"]] | ||
| def test_stream_deserializer(): | ||
| deserializer = StreamDeserializer() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.