fix: use SecurityConfig dict key#2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahsan-z-khan merged 3 commits into from
Jan 5, 2021
Merged

fix: use SecurityConfig dict key #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e892862
fix: use SecurityConfig dict key
ajaykarpur Dec 31, 2020
49ffbab
Merge branch 'master' into security-config
ahsan-z-khan Jan 5, 2021
9aaa13d
update unit test
ajaykarpur Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/feature_store/inputs.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ def to_dict(self) -> Dict[str, Any]:
"""
return Config.construct_dict(
EnableOnlineStore=self.enable_online_store,
OnlineStoreSecurityConfig=self.online_store_security_config,
SecurityConfig=self.online_store_security_config,
)


Expand Down
2 changes: 1 addition & 1 deletion tests/unit/sagemaker/feature_store/test_inputs.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ def test_online_store_config():
assert ordered(config_with_kms.to_dict()) == ordered(
{
"EnableOnlineStore": True,
"OnlineStoreSecurityConfig": {
"SecurityConfig": {
"KmsKeyId": "kms",
},
}
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); })();
Skip to content

fix: use SecurityConfig dict key#2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahsan-z-khan merged 3 commits into from
Jan 5, 2021
Merged

fix: use SecurityConfig dict key #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e892862
fix: use SecurityConfig dict key
ajaykarpur Dec 31, 2020
49ffbab
Merge branch 'master' into security-config
ahsan-z-khan Jan 5, 2021
9aaa13d
update unit test
ajaykarpur Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/feature_store/inputs.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,7 +103,7 @@ def to_dict(self) -> Dict[str, Any]:
"""
return Config.construct_dict(
EnableOnlineStore=self.enable_online_store,
OnlineStoreSecurityConfig=self.online_store_security_config,
SecurityConfig=self.online_store_security_config,
)


Expand Down
2 changes: 1 addition & 1 deletion tests/unit/sagemaker/feature_store/test_inputs.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,7 @@ def test_online_store_config():
assert ordered(config_with_kms.to_dict()) == ordered(
{
"EnableOnlineStore": True,
"OnlineStoreSecurityConfig": {
"SecurityConfig": {
"KmsKeyId": "kms",
},
}
Expand Down