Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sagemaker/xgboost/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,13 +145,16 @@ def prepare_container_def(self, instance_type=None, accelerator_type=None):
)

deploy_key_prefix = model_code_key_prefix(self.key_prefix, self.name, deploy_image)
self._upload_code(deploy_key_prefix)
self._upload_code(key_prefix=deploy_key_prefix, repack=self.enable_network_isolation())
deploy_env = dict(self.env)
deploy_env.update(self._framework_env_vars())

if self.model_server_workers:
deploy_env[MODEL_SERVER_WORKERS_PARAM_NAME.upper()] = str(self.model_server_workers)
return sagemaker.container_def(deploy_image, self.model_data, deploy_env)
model_data = (
self.repacked_model_data if self.enable_network_isolation() else self.model_data
)
return sagemaker.container_def(deploy_image, model_data, deploy_env)

def serving_image_uri(self, region_name, instance_type):
"""Create a URI for the serving image.
Expand Down
50 changes: 50 additions & 0 deletions tests/data/xgboost_abalone/abalone.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
import argparse
import os

from sagemaker_xgboost_container.data_utils import get_dmatrix

import xgboost as xgb

model_filename = "xgboost-model"

if __name__ == "__main__":
parser = argparse.ArgumentParser()

# Sagemaker specific arguments. Defaults are set in the environment variables.
parser.add_argument(
"--model_dir", type=str, default=os.environ.get("SM_MODEL_DIR", "/opt/ml/model")
)
parser.add_argument(
"--train",
type=str,
default=os.environ.get("SM_CHANNEL_TRAIN", "/opt/ml/input/data/abalone"),
)

args, _ = parser.parse_known_args()

dtrain = get_dmatrix(args.train, "libsvm")

params = {
"max_depth": 5,
"eta": 0.2,
"gamma": 4,
"min_child_weight": 6,
"subsample": 0.7,
"verbosity": 2,
"objective": "reg:squarederror",
"tree_method": "auto",
"predictor": "auto",
}

booster = xgb.train(params=params, dtrain=dtrain, num_boost_round=50)
booster.save_model(args.model_dir + "/" + model_filename)


def model_fn(model_dir):
"""Deserialize and return fitted model.

Note that this should have the same name as the serialized model in the _xgb_train method
Comment thread
mufaddal-rohawala marked this conversation as resolved.
"""
booster = xgb.Booster()
booster.load_model(os.path.join(model_dir, model_filename))
return booster
34 changes: 34 additions & 0 deletions tests/integ/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,8 @@

import os
import pytest
from sagemaker.utils import unique_name_from_base
from sagemaker.xgboost import XGBoost
from sagemaker.xgboost.processing import XGBoostProcessor
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout
Expand DownExpand Up@@ -48,3 +50,35 @@ def test_framework_processing_job_with_deps(
inputs=[],
wait=True,
)


def test_training_with_network_isolation(
sagemaker_session,
xgboost_latest_version,
xgboost_latest_py_version,
cpu_instance_type,
):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
base_job_name = "test-network-isolation-xgboost"

xgboost = XGBoost(
entry_point=os.path.join(DATA_DIR, "xgboost_abalone", "abalone.py"),
role=ROLE,
instance_type=cpu_instance_type,
instance_count=1,
framework_version=xgboost_latest_version,
py_version=xgboost_latest_py_version,
base_job_name=base_job_name,
sagemaker_session=sagemaker_session,
enable_network_isolation=True,
)

train_input = xgboost.sagemaker_session.upload_data(
path=os.path.join(DATA_DIR, "xgboost_abalone", "abalone"),
key_prefix="integ-test-data/xgboost_abalone/abalone",
)
job_name = unique_name_from_base(base_job_name)
xgboost.fit(inputs={"train": train_input}, job_name=job_name)
assert sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=job_name)[
"EnableNetworkIsolation"
]
21 changes: 21 additions & 0 deletions tests/unit/test_xgboost.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,7 @@
from packaging.version import Version


from sagemaker.fw_utils import UploadedCode
from sagemaker.xgboost import XGBoost, XGBoostModel, XGBoostPredictor


Expand DownExpand Up@@ -180,6 +181,26 @@ def test_create_model(sagemaker_session, xgboost_framework_version):
assert model_values["Image"] == default_image_uri


@patch("sagemaker.model.FrameworkModel._upload_code")
def test_create_model_with_network_isolation(upload, sagemaker_session, xgboost_framework_version):
source_dir = "s3://mybucket/source"
repacked_model_data = "s3://mybucket/prefix/model.tar.gz"

xgboost_model = XGBoostModel(
model_data=source_dir,
role=ROLE,
sagemaker_session=sagemaker_session,
entry_point=SCRIPT_PATH,
framework_version=xgboost_framework_version,
enable_network_isolation=True,
)
xgboost_model.uploaded_code = UploadedCode(s3_prefix=repacked_model_data, script_name="script")
xgboost_model.repacked_model_data = repacked_model_data
model_values = xgboost_model.prepare_container_def(CPU)
assert model_values["Environment"]["SAGEMAKER_SUBMIT_DIRECTORY"] == "/opt/ml/model/code"
assert model_values["ModelDataUrl"] == repacked_model_data


@patch("sagemaker.estimator.name_from_base")
def test_create_model_from_estimator(name_from_base, sagemaker_session, xgboost_framework_version):
container_log_level = '"logging.INFO"'
Expand Down