fix: fix PySparkProcessor __init__ params type - #3354

Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom
andre-marcos-perez:master
Dec 2, 2022
Merged

fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom
andre-marcos-perez:master

Conversation

@andre-marcos-perez

@andre-marcos-perezandre-marcos-perez commented Sep 8, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:

  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andre-marcos-perezandre-marcos-perez changed the title fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot

sagemaker-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter

codecov-commenter commented Sep 23, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.
The diff coverage is 88.30%.

@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot

sagemaker-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 24, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Sep 29, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

vikas0203
vikas0203 reviewed Oct 19, 2022
View reviewed changes

@vikas0203vikas0203 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot

sagemaker-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Oct 20, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@vikas0203
vikas0203 requested review from a team, knikure and mufaddal-rohawala and removed request for a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala approved these changes Nov 24, 2022
View reviewed changes

@mufaddal-rohawalamufaddal-rohawala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot

sagemaker-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala
mufaddal-rohawala reviewed Nov 24, 2022
View reviewed changes

@mufaddal-rohawalamufaddal-rohawala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot

sagemaker-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala
mufaddal-rohawala reviewed Dec 2, 2022
View reviewed changes

@mufaddal-rohawalamufaddal-rohawala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot

sagemaker-bot commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
mufaddal-rohawala merged commit de58941 into aws:masterDec 2, 2022
mufaddal-rohawala added a commit that referenced this pull request Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala mentioned this pull request Dec 9, 2022
Closed
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit to gradientsky/sagemaker-python-sdk that referenced this pull request Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit to gradientsky/sagemaker-python-sdk that referenced this pull request Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit to hballuru/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit to Shegufta/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit that referenced this pull request Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit that referenced this pull request Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit to jmahlik/sagemaker-python-sdk that referenced this pull request Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit to wcarpenter1-godaddy/sagemaker-python-sdk that referenced this pull request Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit to tejaschumbalkar/sagemaker-python-sdk that referenced this pull request Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit to tejaschumbalkar/sagemaker-python-sdk that referenced this pull request Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks
+1 more reviewer
@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix: fix PySparkProcessor __init__ params type - #3354
Merged
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Dec 2, 2022
Merged
fix: fix PySparkProcessor __init__ params type#3354
mufaddal-rohawala merged 1 commit into
aws:masterfrom 
andre-marcos-perez:master
Conversation
@andre-marcos-perez
@andre-marcos-perezandre-marcos-perez
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes: In the sagemaker.spark.processing module, the PySparkProcessor object constructor params instance_type and instance_count params have wrong typing:
  • instance_type is a str but is being typed as int;
  • instance_count is an int but is being typed as str.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@andre-marcos-perezandre-marcos-perez
changed the title
fix: fix PySparkPySparkProcessor __init__ params typefix: fix PySparkProcessor __init__ params typeSep 16, 2022
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Sep 23, 2022•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3354 (37d503b) into master (1fa2377) will decrease coverage by 0.20%.

The diff coverage is 88.30%.
@@ Coverage Diff @@## master #3354 +/- ##
==========================================
- Coverage 89.17% 88.96% -0.21% 
==========================================
Files 204 212 +8 Lines 18979 20435 +1456 ==========================================
+ Hits 16924 18180 +1256 - Misses 2055 2255 +200 
Impacted FilesCoverage Δ
src/sagemaker/feature_store/feature_group.py76.52% <ø> (ø)
src/sagemaker/huggingface/model.py89.87% <ø> (ø)
src/sagemaker/pipeline.py85.33% <ø> (ø)
src/sagemaker/sklearn/model.py92.98% <ø> (-1.76%)⬇️
...sagemaker/workflow/monitor_batch_transform_step.py0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py96.36% <ø> (-1.82%)⬇️
...agemaker/model_monitor/clarify_model_monitoring.py89.84% <27.58%> (-5.09%)⬇️
src/sagemaker/training_compiler/config.py80.43% <60.00%> (-2.90%)⬇️
src/sagemaker/pytorch/estimator.py94.73% <63.63%> (-5.27%)⬇️
src/sagemaker/sklearn/estimator.py93.93% <63.63%> (-6.07%)⬇️
... and 49 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 23, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e1642d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 30d0d3b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Sep 29, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 30d0d3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
vikas0203
vikas0203
reviewed
Oct 19, 2022
View reviewed changes
@vikas0203vikas0203
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: de02cde
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 19, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Oct 20, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: de02cde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@vikas0203
vikas0203
requested review from
a team, knikure and mufaddal-rohawala
and removed request for
a teamNovember 23, 2022 20:42
mufaddal-rohawala
mufaddal-rohawala
approved these changes
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Nov 24, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Nov 24, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 0cc38db
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
mufaddal-rohawala
mufaddal-rohawala
reviewed
Dec 2, 2022
View reviewed changes
@mufaddal-rohawalamufaddal-rohawala
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Dec 2, 2022

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 37d503b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
merged commit de58941
into
aws:masterDec 2, 2022
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 9, 2022
@mufaddal-rohawala
Revert "fix: fix PySparkProcessor __init__ params type (#3354)"
19ae8a6
This reverts commit de58941.
@mufaddal-rohawalamufaddal-rohawala
mentioned this pull request
Dec 9, 2022
 Closed

mizanfiu pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
@andre-marcos-perez@mizanfiu
fix: fix PySparkProcessor __init__ params type (aws#3354)
942361b
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
17af232
gradientsky pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
@andre-marcos-perez@gradientsky
fix: fix PySparkProcessor __init__ params type (aws#3354)
ff5268e
hballuru pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perez@hballuru
fix: fix PySparkProcessor __init__ params type (aws#3354)
704d1d5
Shegufta pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@andre-marcos-perezShegufta Ahsan
fix: fix PySparkProcessor __init__ params type (aws#3354)
a965c4c
claytonparnell pushed a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (#3544)
48c13e9
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e114b22
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
mufaddal-rohawala added a commit
that referenced
this pull request
Dec 21, 2022
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@mufiAmazon
feature: AutoGluon 0.6.1 image_uris (#3544)
d995d70
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* fix: type hint of PySparkProcessor __init__ (#3297)
* fix: fix PySparkProcessor __init__ params type (#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jmahlik pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
@andre-marcos-perez@jmahlik
fix: fix PySparkProcessor __init__ params type (aws#3354)
7249638
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6fb2920
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
6c3c7bc
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
gwang111 added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
@gwang111@NivekNey
@andre-marcos-perezRaymond Liu
feature: add verbose logging from cloudwatch for IR job (aws#790)
25997eb
* feature: Add create inf rec api to session
* save
* fix error handling in submit. update docstring
* add in job_name param
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* feature: add describe inf rec api to session
* add verbose logging in wait_for_inference_recommendations_job
* improve unit tests
* switch to cloudwatch logs
* add unit tests
* fix unit test
* make default logging level to Verbose
* address comments in PR
* address some comments
* fix typo missing s
* add initial print because it took a while for cw logstream to appear
* print and conditional optimizations and update tests
* optimize log print
* fix polling for logs empty events
* cover empty event case
* add spacing
Co-authored-by: Gary Wang <garywan@amazon.com>
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Raymond Liu <tzujui@amazon.com>
wcarpenter1-godaddy pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
@andre-marcos-perez@wcarpenter1-godaddy
fix: fix PySparkProcessor __init__ params type (aws#3354)
2cc4d47
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@andre-marcos-perez@JoseJuan98
fix: fix PySparkProcessor __init__ params type (aws#3354)
b5d0042
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
ca671ae
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawala@JoseJuan98
feature: AutoGluon 0.6.1 image_uris (aws#3544)
fc23a25
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
b760181
tejaschumbalkar pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
@andre-marcos-perez@tejaschumbalkar
fix: fix PySparkProcessor __init__ params type (aws#3354)
1f4f396
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perez@mufiAmazon
fix: fix PySparkProcessor __init__ params type (aws#3354)
36e5fb1
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@gradientsky@NivekNey
@andre-marcos-perez@mufaddal-rohawalaNamrata Madan
feature: AutoGluon 0.6.1 image_uris (aws#3544)
e9afdaf
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
c651b22
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@andre-marcos-perezNamrata Madan
fix: fix PySparkProcessor __init__ params type (aws#3354)
1fe7a0c
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@NivekNey
@andre-marcos-perez@mufaddal-rohawala
feature: AutoGluon 0.6.1 image_uris (aws#3544)
04424c8
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* fix: type hint of PySparkProcessor __init__ (aws#3297)
* fix: fix PySparkProcessor __init__ params type (aws#3354)
* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)
* feature: AutoGluon 0.6.1 image_uris
* feature: AutoGluon 0.6.1 image_uris
* Added processors for training images for consistency
* Formatting
* Formatting
Co-authored-by: Kevin <yenkevin1203@gmail.com>
Co-authored-by: André Perez <andre.marcos.perez@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@knikureknikureAwaiting requested review from knikureknikure was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@vikas0203vikas0203vikas0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mufaddal-rohawalamufaddal-rohawala

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andre-marcos-perez@sagemaker-bot@codecov-commenter@vikas0203@mufaddal-rohawala