Do not use print function. Use logger instead - #3591

Merged
claytonparnell merged 2 commits into
aws:masterfrom
Guillem96:patch-1
Jan 27, 2023
Merged

Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom
Guillem96:patch-1

Conversation

@Guillem96

@Guillem96Guillem96 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Use logger instead of print function.
This allow developers using the library to silenc undesired output

Description of changes:

Remove print function and use logger.debug instead.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96 requested a review from a team as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96 requested review from navinsoni and removed request for a teamJanuary 16, 2023 12:02
@Guillem96Guillem96 changed the title Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96

Guillem96 commented Jan 23, 2023

Copy link
Copy Markdown
ContributorAuthor

@navinsoni did you have the opportunity to take a look at this?

claytonparnell
claytonparnell reviewed Jan 27, 2023
View reviewed changes

@claytonparnellclaytonparnell left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter

codecov-commenter commented Jan 27, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@claytonparnell

claytonparnell commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

Hi @Guillem96 - Navin is out of office for a bit but I am taking a look

@claytonparnellclaytonparnell self-assigned this Jan 27, 2023
@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@claytonparnell
claytonparnell merged commit 76d9c5a into aws:masterJan 27, 2023
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha mentioned this pull request Jun 16, 2023
Closed
@martinRenoumartinRenou mentioned this pull request Sep 21, 2023
Merged
9 tasks
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks
1 more reviewer
@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni

@claytonparnellclaytonparnell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Do not use print function. Use logger instead - #3591
Merged
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Jan 27, 2023
Merged
Do not use print function. Use logger instead#3591
claytonparnell merged 2 commits into
aws:masterfrom 
Guillem96:patch-1
Conversation
@Guillem96
@Guillem96Guillem96
commented
Jan 16, 2023

Copy link


Copy Markdown

Contributor
Use logger instead of print function.

This allow developers using the library to silenc undesired output
Description of changes:
Remove print function and use logger.debug instead.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@Guillem96
Do not use print function. User logger instead
36b7a27
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@Guillem96
Guillem96
requested a review
from a team
as a code ownerJanuary 16, 2023 12:02
@Guillem96
Guillem96
requested review from
navinsoni
and removed request for
a teamJanuary 16, 2023 12:02
@Guillem96Guillem96
changed the title
Do not use print function. User logger insteadDo not use print function. Use logger insteadJan 19, 2023
@Guillem96
Guillem96
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
@navinsoni did you have the opportunity to take a look at this?
claytonparnell
claytonparnell
reviewed
Jan 27, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run slow-tests
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Jan 27, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.

The diff coverage is 100.00%.
@@ Coverage Diff @@## master #3591 +/- ##
==========================================
- Coverage 89.59% 88.80% -0.80% 
==========================================
Files 968 227 -741 Lines 89536 22140 -67396 ==========================================
- Hits 80219 19661 -60558 + Misses 9317 2479 -6838 
Impacted FilesCoverage Δ
src/sagemaker/processing.py94.23% <100.00%> (ø)
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
commented
Jan 27, 2023

Copy link


Copy Markdown

Contributor
Hi @Guillem96 - Navin is out of office for a bit but I am taking a look
@claytonparnellclaytonparnell
self-assigned this
Jan 27, 2023
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6bf4752
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@claytonparnell
claytonparnell
merged commit 76d9c5a
into
aws:masterJan 27, 2023
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
@Guillem96@JoseJuan98
fix: Do not use print function. User logger instead (aws#3591)
9752a89
Use logger instead of print function.
This allow developers using the library to silenc undesired output
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
@Guillem96Namrata Madan
fix: Do not use print function. User logger instead (aws#3591)
42547a1
Use logger instead of print function.
This allow developers using the library to silenc undesired output
@anjali-chadhaanjali-chadha
mentioned this pull request
Jun 16, 2023

Closed

@martinRenoumartinRenou
mentioned this pull request
Sep 21, 2023
 Merged

9 tasks
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Do not use print function. User logger instead (aws#3591)
d798f29
Use logger instead of print function.
This allow developers using the library to silenc undesired output
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@navinsoninavinsoniAwaiting requested review from navinsoninavinsoni was automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@claytonparnellclaytonparnellclaytonparnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@navinsoninavinsoni
@claytonparnellclaytonparnell

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@Guillem96@sagemaker-bot@codecov-commenter@claytonparnell@navinsoni@knikure