Sagemaker Config for SDK Defaults - #3757

Merged
claytonparnell merged 40 commits into
aws:masterfrom
rubanh:master
Mar 29, 2023
Merged

Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom
rubanh:master

Conversation

@rubanh

@rubanhrubanh commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

balajisankar15and others added 30 commits March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh requested a review from a team as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh requested review from claytonparnell and removed request for a teamMarch 28, 2023 20:51
@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@balajisankar15

balajisankar15 commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

/bot run pr

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 29, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 29, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter

codecov-commenter commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.
The diff coverage is 96.20%.

@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more

... and 1170 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot

sagemaker-bot commented Mar 29, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell
claytonparnell reviewed Mar 29, 2023
View reviewed changes

@claytonparnellclaytonparnell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr

@claytonparnell
claytonparnell merged commit 0473a8e into aws:masterMar 29, 2023
@sagemaker-bot

sagemaker-bot commented Mar 29, 2023

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi pushed a commit to evakravi/sagemaker-python-sdk that referenced this pull request Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit to doddaspk-amzn/sagemaker-python-sdk that referenced this pull request Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Sagemaker Config for SDK Defaults - #3757
Merged
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Mar 29, 2023
Merged
Sagemaker Config for SDK Defaults#3757
claytonparnell merged 40 commits into
aws:masterfrom 
rubanh:master
Conversation
@rubanh
@rubanhrubanh
commented
Mar 28, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
balajisankar15and others
added 30 commits
March 28, 2023 13:48
@balajisankar15Balaji SankarRuban Hussain
feature: Added Config parser for SageMaker Python SDK (aws#840)
cc090d4
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@rubanhRuban Hussain
intelligent defaults - tags and encryption (aws#842)
6c9bc6a
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@rubanhRuban Hussain
intelligent defaults - custom parameters and small fixes (aws#845)
67e8d94
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
feature: Added support for VPC Config, EnableNetworkIsolation, KMS Ke…
67fc282
…y ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Balaji SankarRuban Hussain
fix: Make Key, Value as required fields for each "Tags" entry in the …
669e5a6
…config file.
@balajisankar15Balaji SankarRuban Hussain
fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModel…
29c9728
…Monitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
@balajisankar15Balaji SankarRuban Hussain
Fix: Certain unit tests aren't passing sagemaker_session. Modify the …
09cc530
…logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Ruban Hussain
fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_…
ce90eda
…monitoring
Ruban Hussain
change: Sagemaker Config - improved readability of print statements a…
24b681f
…nd simplified its code
Ruban Hussain
fix: Sagemaker Config - Reduce duplicate and misleading config-relate…
6b6e44c
…d print statements
Ruban Hussain
fix: Sagemaker Config - add function description
cb66d7b
Ruban Hussain
fix: Sagemaker Config - Fix failing Integ tests, fix backwards incomp…
ceecae5
…atible behavior, and improved some unit tests
Ruban Hussain
change: new integ test for sagemaker_config
018d682
Ruban Hussain
fix: Sagemaker Config - fleshed out unit tests and fixed bugs
514618b
Balaji SankarRuban Hussain
fix: Sagemaker Config - Removed hard coded config values in the unit …
3dac2d3
…tests
Ruban Hussain
fix: inject from config into existing ProductionVariants inside creat…
e62a378
…e_endpoint_config_from_existing
Balaji SankarRuban Hussain
change: added unit test for verifying yaml safe_load method
2baeab0
Balaji SankarRuban Hussain
change: addressed PR comments for SageMaker Config
43492a6
Ruban Hussain
change: Sagemaker Config - minor clarification
53ca7fc
Balaji SankarRuban Hussain
change: ModelMonitoring and Processing now use helper methods for upd…
70056aa
…ating NetworkConfig
Balaji SankarRuban Hussain
change: Refactoring session.py and added additional schema validation…
51190cc
… for ValidationProfiles
Ruban Hussain
update: expand one unit test
dba07fa
Ruban Hussain
update: new integ test for cross context injection
95bc7de
Balaji SankarRuban Hussain
change: remove unwanted method and replace it with a different method…
19e185a
… for config injection
Balaji SankarRuban Hussain
fix: Address documentation errors and removed unnecessary properties …
3bd3a94
…and setters
Balaji SankarRuban Hussain
fix: moving certain config file helper methods to utils.py
d4905c9
Balaji SankarRuban Hussain
change: Add a separate helper to merge list of objects
f02131b
Balaji SankarRuban Hussain
fix: Documentation updates for SageMakerConfig
ada7ddc
Balaji SankarRuban Hussain
fix: bubble up exceptions from S3 while fetching the Config
1ec0563
Balaji SankarRuban Hussain
fix: Added additional test cases for config helper methods. Also made…
263594a
… minor documentation updates.
@rubanh
rubanh
requested a review
from a team
as a code ownerMarch 28, 2023 20:51
@rubanh
rubanh
requested review from
claytonparnell
and removed request for
a teamMarch 28, 2023 20:51
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 99660ca
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 99660ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@balajisankar15
balajisankar15
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
/bot run pr
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 28, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: ee93e3f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov-commenter
codecov-commenter
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #3757 (ee93e3f) into master (07dd8ba) will decrease coverage by 0.40%.

The diff coverage is 96.20%.
@@ Coverage Diff @@## master #3757 +/- ##
==========================================
- Coverage 89.85% 89.45% -0.40% 
==========================================
Files 984 233 -751 Lines 92388 23379 -69009 ==========================================
- Hits 83012 20914 -62098 + Misses 9376 2465 -6911 
Impacted FilesCoverage Δ
src/sagemaker/algorithm.py90.96% <ø> (ø)
src/sagemaker/amazon/amazon_estimator.py87.89% <ø> (ø)
src/sagemaker/amazon/factorization_machines.py100.00% <ø> (ø)
src/sagemaker/amazon/ipinsights.py100.00% <ø> (ø)
src/sagemaker/amazon/kmeans.py100.00% <ø> (ø)
src/sagemaker/amazon/knn.py100.00% <ø> (ø)
src/sagemaker/amazon/lda.py98.03% <ø> (ø)
src/sagemaker/amazon/linear_learner.py100.00% <ø> (ø)
src/sagemaker/amazon/ntm.py100.00% <ø> (ø)
src/sagemaker/amazon/object2vec.py99.05% <ø> (ø)
... and 37 more
... and 1170 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
claytonparnell
claytonparnell
reviewed
Mar 29, 2023
View reviewed changes
@claytonparnellclaytonparnell
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr
@claytonparnell
claytonparnell
merged commit 0473a8e
into
aws:masterMar 29, 2023
@sagemaker-bot
sagemaker-bot
commented
Mar 29, 2023

Copy link


Copy Markdown

Collaborator
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: ee93e3f
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
evakravi pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Apr 3, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@evakravi
feature: Support for SageMaker Intelligent Defaults (aws#3757)
fa43a6c
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
doddaspk-amzn pushed a commit
to doddaspk-amzn/sagemaker-python-sdk
that referenced
this pull request
Apr 6, 2023
@rubanh@balajisankar15
Balaji SankarRuban HussainIvy Bazan@doddaspk-amzn
feature: Support for SageMaker Intelligent Defaults (aws#3757)
277ebd7
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang@balajisankar15
Balaji SankarRuban HussainIvy Bazan
feature: Support for SageMaker Intelligent Defaults (aws#3757)
98bc0e3
* feature: Added Config parser for SageMaker Python SDK (aws#840)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* intelligent defaults - tags and encryption (aws#842)
* feature: sagemaker config - support tags for all APIs
* feature: sagemaker config - support EnableInterContainerTrafficEncryption for relevant APIs
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* intelligent defaults - custom parameters and small fixes (aws#845)
* fix: sagemaker-config - S3 session, tuning tags, config schema test side-effects
* feature: sagemaker-config - support for custom parameters in config schema
---------
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
* feature: Added support for VPC Config, EnableNetworkIsolation, KMS Key ID, Volume KMS Key ID, IAM role to be fetched from Config (aws#846)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Make Key, Value as required fields for each "Tags" entry in the config file.
* fix: Make 'role' as Optional for ModelQualityMonitor and DefaultModelMonitor, and fixed PROCESSING_CONFIG_PATH (aws#849)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
* fix: Sagemaker Config - KeyError: 'MonitoringJobDefinition' in model_monitoring
* change: Sagemaker Config - improved readability of print statements and simplified its code
* fix: Sagemaker Config - Reduce duplicate and misleading config-related print statements
* fix: Sagemaker Config - add function description
* fix: Sagemaker Config - Fix failing Integ tests, fix backwards incompatible behavior, and improved some unit tests
* change: new integ test for sagemaker_config
* fix: Sagemaker Config - fleshed out unit tests and fixed bugs
* fix: Sagemaker Config - Removed hard coded config values in the unit tests
* fix: inject from config into existing ProductionVariants inside create_endpoint_config_from_existing
* change: added unit test for verifying yaml safe_load method
* change: addressed PR comments for SageMaker Config
* change: Sagemaker Config - minor clarification
* change: ModelMonitoring and Processing now use helper methods for updating NetworkConfig
* change: Refactoring session.py and added additional schema validation for ValidationProfiles
* update: expand one unit test
* update: new integ test for cross context injection
* change: remove unwanted method and replace it with a different method for config injection
* fix: Address documentation errors and removed unnecessary properties and setters
* fix: moving certain config file helper methods to utils.py
* change: Add a separate helper to merge list of objects
* fix: Documentation updates for SageMakerConfig
* fix: bubble up exceptions from S3 while fetching the Config
* fix: Added additional test cases for config helper methods. Also made minor documentation updates.
* fix: small bug fix to print statements for update_list_of_dicts_with_values_from_config
* fix: Replace SageMakerConfig class with just method invocations
* fix: fix broken unit tests due to refactoring
* fix: bug where a user-provided sagemaker_config wasnt set
* change: rename fetch_sagemaker_config to load_sagemaker_config
* fix: update Schema to match exactly with APIs
* add documentation for default configuration support
* fix linting errors
* fix link lint
* fix lint
---------
Co-authored-by: Balaji Sankar <115105204+balajisankar15@users.noreply.github.com>
Co-authored-by: Balaji Sankar <sankarbs@amazon.com>
Co-authored-by: Ruban Hussain <rubanh@amazon.com>
Co-authored-by: Ivy Bazan <nbbazan@amazon.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@claytonparnellclaytonparnellclaytonparnell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rubanh@sagemaker-bot@balajisankar15@codecov-commenter@claytonparnell