Uh oh!
There was an error while loading. Please reload this page.
feat: Add new Triton DLC URIs#4432
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| { | ||
| "processors": [ | ||
| "cpu", | ||
| "gpu" | ||
| ], | ||
| "scope": [ | ||
| "inference" | ||
| ], | ||
| "versions": { | ||
| "23.12": { | ||
| "registries": { | ||
| "af-south-1": "626614931356", | ||
| "il-central-1": "780543022126", | ||
| "ap-east-1": "871362719292", | ||
| "ap-northeast-1": "763104351884", | ||
| "ap-northeast-2": "763104351884", | ||
| "ap-northeast-3": "364406365360", | ||
| "ap-south-1": "763104351884", | ||
| "ap-southeast-1": "763104351884", | ||
| "ap-southeast-2": "763104351884", | ||
| "ap-southeast-3": "907027046896", | ||
| "ca-central-1": "763104351884", | ||
| "cn-north-1": "727897471807", | ||
| "cn-northwest-1": "727897471807", | ||
| "eu-central-1": "763104351884", | ||
| "eu-north-1": "763104351884", | ||
| "eu-west-1": "763104351884", | ||
| "eu-west-2": "763104351884", | ||
| "eu-west-3": "763104351884", | ||
| "eu-south-1": "692866216735", | ||
| "me-south-1": "217643126080", | ||
| "sa-east-1": "763104351884", | ||
| "us-east-1": "763104351884", | ||
| "us-east-2": "763104351884", | ||
| "us-west-1": "763104351884", | ||
| "us-west-2": "763104351884", | ||
| "ca-west-1": "204538143572" | ||
| }, | ||
| "repository": "sagemaker-tritonserver", | ||
| "tag_prefix": "23.12-py3" | ||
| }, | ||
| "24.01": { | ||
| "registries": { | ||
| "af-south-1": "626614931356", | ||
| "il-central-1": "780543022126", | ||
| "ap-east-1": "871362719292", | ||
| "ap-northeast-1": "763104351884", | ||
| "ap-northeast-2": "763104351884", | ||
| "ap-northeast-3": "364406365360", | ||
| "ap-south-1": "763104351884", | ||
| "ap-southeast-1": "763104351884", | ||
| "ap-southeast-2": "763104351884", | ||
| "ap-southeast-3": "907027046896", | ||
| "ca-central-1": "763104351884", | ||
| "cn-north-1": "727897471807", | ||
| "cn-northwest-1": "727897471807", | ||
| "eu-central-1": "763104351884", | ||
| "eu-north-1": "763104351884", | ||
| "eu-west-1": "763104351884", | ||
| "eu-west-2": "763104351884", | ||
| "eu-west-3": "763104351884", | ||
| "eu-south-1": "692866216735", | ||
| "me-south-1": "217643126080", | ||
| "sa-east-1": "763104351884", | ||
| "us-east-1": "763104351884", | ||
| "us-east-2": "763104351884", | ||
| "us-west-1": "763104351884", | ||
| "us-west-2": "763104351884", | ||
| "ca-west-1": "204538143572" | ||
| }, | ||
| "repository": "sagemaker-tritonserver", | ||
| "tag_prefix": "24.01-py3" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -44,6 +44,7 @@ | ||
| INFERENCE_GRAVITON = "inference_graviton" | ||
| DATA_WRANGLER_FRAMEWORK = "data-wrangler" | ||
| STABILITYAI_FRAMEWORK = "stabilityai" | ||
| SAGEMAKER_TRITONSERVER_FRAMEWORK = "sagemaker-tritonserver" | ||
| @override_pipeline_parameter_var | ||
| @@ -335,6 +336,11 @@ def _get_image_tag( | ||
| if key in container_versions: | ||
| tag = "-".join([tag, container_versions[key]]) | ||
| # Triton images don't have a trailing -gpu tag. Only -cpu images do. | ||
Contributor There was a problem hiding this comment. Because it's default option is gpu? ContributorAuthor There was a problem hiding this comment. @mohanasudhan Hi Mohan, that is correct - the default option is gpu. | ||
| if framework == SAGEMAKER_TRITONSERVER_FRAMEWORK: | ||
| if processor == "gpu": | ||
| tag = tag.rstrip("-gpu") | ||
| return tag | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"). You | ||
| # may not use this file except in compliance with the License. A copy of | ||
| # the License is located at | ||
| # | ||
| # http://aws.amazon.com/apache2.0/ | ||
| # | ||
| # or in the "license" file accompanying this file. This file is | ||
| # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
| # ANY KIND, either express or implied. See the License for the specific | ||
| # language governing permissions and limitations under the License. | ||
| from __future__ import absolute_import | ||
| import pytest | ||
| from sagemaker import image_uris | ||
| from tests.unit.sagemaker.image_uris import expected_uris | ||
| INSTANCE_TYPES = {"cpu": "ml.c4.xlarge", "gpu": "ml.p2.xlarge"} | ||
| @pytest.mark.parametrize( | ||
| "load_config_and_file_name", | ||
| ["sagemaker-tritonserver.json"], | ||
| indirect=True, | ||
| ) | ||
| def test_sagemaker_tritonserver_uris(load_config_and_file_name): | ||
| config, file_name = load_config_and_file_name | ||
| framework = file_name.split(".json")[0] | ||
| VERSIONS = config["versions"] | ||
| processors = config["processors"] | ||
| for version in VERSIONS: | ||
| ACCOUNTS = config["versions"][version]["registries"] | ||
| tag = config["versions"][version]["tag_prefix"] | ||
| for processor in processors: | ||
| instance_type = INSTANCE_TYPES[processor] | ||
| for region in ACCOUNTS.keys(): | ||
| _test_sagemaker_tritonserver_uris( | ||
| ACCOUNTS[region], region, version, tag, framework, instance_type, processor | ||
| ) | ||
| def _test_sagemaker_tritonserver_uris( | ||
| account, region, version, tag, triton_framework, instance_type, processor | ||
| ): | ||
| uri = image_uris.retrieve( | ||
| framework=triton_framework, region=region, version=version, instance_type=instance_type | ||
| ) | ||
| expected = expected_uris.sagemaker_triton_framework_uri( | ||
| "sagemaker-tritonserver", | ||
| account, | ||
| tag, | ||
| processor, | ||
| region, | ||
| ) | ||
| assert expected == uri |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nskool Can your team onboard to PySDK RBA to create this JSON? Please reach out to me for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DLC would be taking the RBA automation of this file on behalf of Large Model Inference/Model Serving team.