fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476

Merged
knikure merged 3 commits into
aws:masterfrom
knikure:fix-extractall
Mar 6, 2024
Merged

fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom
knikure:fix-extractall

Conversation

@knikure

@knikureknikure commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@knikure
knikure requested a review from a team as a code ownerMarch 5, 2024 06:28
@knikure
knikure requested review from liujiaorr and removed request for a teamMarch 5, 2024 06:28
@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure
knikure commented Mar 5, 2024
View reviewed changes

@knikureknikure left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov

codecovBot commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).
Report is 63 commits behind head on master.

FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala
mufaddal-rohawala reviewed Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py Outdated
Comment on lines +1556 to +1560
print(stderr, file_info.name, "is blocked (illegal path)")
elif file_info.issym() and _is_bad_link(file_info, base):
print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
elif file_info.islnk() and _is_bad_link(file_info, base):
print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
else:

@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?

Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen reviewed Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py Outdated
Comment threadsrc/sagemaker/utils.py Outdated
Comment threadsrc/sagemaker/utils.py Outdated
Comment threadsrc/sagemaker/utils.py Outdated
Comment threadsrc/sagemaker/utils.py Outdated
Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py Outdated
qidewenwhen
qidewenwhen reviewed Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 5, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen
qidewenwhen reviewed Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py Outdated
for file_info in members:
if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")

@qidewenwhenqidewenwhenMar 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?
I have not seen this log format so hoping to confirm if it can print out the message as expected.
Usually we use format like :

logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref:

sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494 in 3aa0a56

logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure
knikure commented Mar 6, 2024
View reviewed changes

@knikureknikure left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests

@diggerdan

diggerdan commented Mar 6, 2024

Copy link
Copy Markdown

Hello, and thank you for working on this.

We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image

@mufaddal-rohawala

mufaddal-rohawala commented Mar 6, 2024

Copy link
Copy Markdown
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure
knikure merged commit df2cc4d into aws:masterMar 6, 2024
@johnrwoolley

johnrwoolley commented Mar 7, 2024

Copy link
Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄

bencrabtree pushed a commit to bencrabtree/sagemaker-python-sdk that referenced this pull request Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit that referenced this pull request Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit that referenced this pull request Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks
+1 more reviewer
@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix: Create custom tarfile extractall util to fix backward compatibility issue - #4476
Merged
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Mar 6, 2024
Merged
fix: Create custom tarfile extractall util to fix backward compatibility issue#4476
knikure merged 3 commits into
aws:masterfrom 
knikure:fix-extractall
Conversation
@knikure
@knikureknikure
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available:
Description of changes:

Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General
  •  I have read the CONTRIBUTING doc
  •  I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  •  I used the commit message format described in CONTRIBUTING
  •  I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  •  I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
  •  I have added tests that prove my fix is effective or that my feature works (if appropriate)
  •  I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  •  I have checked that my tests are not configured for a specific region or account (if appropriate)
  •  I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@knikure
knikure
requested a review
from a team
as a code ownerMarch 5, 2024 06:28
@knikure
knikure
requested review from
liujiaorr
and removed request for
a teamMarch 5, 2024 06:28
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 5, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 049e655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@codecov
codecovBot
commented
Mar 5, 2024•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.
Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).

Report is 63 commits behind head on master.
FilesPatch %Lines
src/sagemaker/workflow/_repack_model.py33.33%16 Missing ⚠️
src/sagemaker/utils.py54.16%11 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #4476 +/- ##
==========================================
+ Coverage 86.94% 87.21% +0.27% 
==========================================
Files 1203 388 -815 Lines 107211 36332 -70879 ==========================================
- Hits 93211 31687 -61524 + Misses 14000 4645 -9355 
☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.
mufaddal-rohawala
mufaddal-rohawala
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated


Comment on lines

+1556
 to 
+1560

 print(stderr, file_info.name, "is blocked (illegal path)")
 elif file_info.issym() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
 elif file_info.islnk() and _is_bad_link(file_info, base):
 print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
 else:
@mufaddal-rohawalamufaddal-rohawalaMar 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add coverage for these paths?
Comment threadsrc/sagemaker/workflow/_repack_model.py
qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/utils.py
Outdated

Comment threadsrc/sagemaker/workflow/_repack_model.py
Comment threadsrc/sagemaker/workflow/_repack_model.py
Outdated

qidewenwhen
qidewenwhen
reviewed
Mar 5, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 5, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f758927
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f758927
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
qidewenwhen
qidewenwhen
reviewed
Mar 6, 2024
View reviewed changes
Comment threadsrc/sagemaker/utils.py
Outdated

 for file_info in members:
 if _is_bad_path(file_info.name, base):
print(stderr, file_info.name, "is blocked (illegal path)")
logger.error(stderr, file_info.name, "is blocked (illegal path)")
@qidewenwhenqidewenwhenMar 6, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked the error log in console via unit test?

I have not seen this log format so hoping to confirm if it can print out the message as expected.

Usually we use format like :
logger.debug(
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
inputs.config["InputMode"],
)

Ref: 
sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494
in
3aa0a56
logger.debug( 
"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", 
inputs.config["InputMode"], 
 ) 
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 7a8b6a1
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 7a8b6a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: FAILED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
knikure
knikure
commented
Mar 6, 2024
View reviewed changes
@knikureknikure
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests
@diggerdan
diggerdan
commented
Mar 6, 2024

Copy link


Copy Markdown

Hello, and thank you for working on this.
We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.
image
@mufaddal-rohawala
mufaddal-rohawala
commented
Mar 6, 2024

Copy link


Copy Markdown

Member
AWS CodeBuild CI Report
  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9db0539
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
@knikure
knikure
merged commit df2cc4d
into
aws:masterMar 6, 2024
@johnrwoolley
johnrwoolley
commented
Mar 7, 2024

Copy link


Copy Markdown

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄
bencrabtree pushed a commit
to bencrabtree/sagemaker-python-sdk
that referenced
this pull request
Mar 13, 2024
@knikure@bencrabtree
fix: Create custom tarfile extractall util to fix backward compatibil…
7000f25
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
erickb336 added a commit
that referenced
this pull request
Mar 15, 2024
@bencrabtree@nikhil-sk
@qidewenwhen@repushkoAnton Repushko@saimidu@rohangujarathiRohan Gujarathi@can-sun@jmahlik@evakravi@knikure@gverkes@akrishna1995Ashwin Krishna@samruds@adtian2@sirutBuasai@dbushy727@erickb336@xiongz945Xiong Zeng@martinRenou@mrudulmn@Captainia@liujiaorr@jinyoung-lim@shinglyuShing Lyu@makungaj1Jonathan Makunga@stacicho@tonyhoo
Feat/rebase master (#4498)
d820b28
* prepare release v2.210.0
* update development version to v2.210.1.dev0
* feat: Add new Triton DLC URIs (#4432)
* Add new Triton DLC URIs
* Update according to black and pylint
* feat: Support selective pipeline execution between function step and regular step (#4392)
* feat: Add AutoMLV2 support (#4461)
* Add AutoMLV2 support
* Improvements of the integration tests
---------
Co-authored-by: Anton Repushko <repuanto@amazon.com>
* feature: Add TensorFlow 2.14 image configs (#4446)
* fix: remove enable_network_isolation from the python doc (#4465)
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
* doc: Add doc for new feature processor APIs and classes (#4250)
* fix: properly close sagemaker config file after loading config (#4457)
Closes#4456
* feat: instance specific jumpstart host requirements (#4397)
* feat: instance specific jumpstart host requirements
* chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class
* fix: typing
* fix: pylint
* change: Bump Apache Airflow version to 2.8.2 (#4470)
* Update tox.ini
* Update test_requirements.txt
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421)
* change: bump jinja2 to 3.1.3 in doc/requirments.txt
* Update requirements.txt
* feature: TGI 1.4.0 (#4424)
* documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259)
* documentation: fix the ClarifyCheckStep documentation to mention PDP support
* fix: break the lines to meet pylint requirement
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261)
* documentation: explain the ClarifyCheckStep and QualityCheckStep parameters
* fix: remove trailing space
---------
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
* feat: Telemetry metrics (#4414)
* Emit additional telemetry metrics
* Fix unit tests
* Emit endpoint failure to telemetry
* Address PR Comments
* Emit latency in telemetry
* Address PR Comments
* Addressed PR Comments
* Address PR Comments
* Fix tests
* Fix integ tests
---------
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* documentation: change order of pipelines topics (#4427)
* prepare release v2.208.0
* update development version to v2.208.1.dev0
* feature: AutoGluon 1.0.0 image_uris update (#4426)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: ci <ci>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
* feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438)
* feat: jsch jumpstart estimator support (#4439)
* Master jumpstart curated hub (#4464)
* add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463)
* feature: JumpStart CuratedHub class creation and function definitions (#4448)
* MultiPartCopy with Sync Algorithm (#4475)
* first pass at sync function with util classes
* adding tests and update clases
* linting
* file generator class inheritance
* lint
* multipart copy and algorithm updates
* modularize sync
* reformatting folders
* testing for sync
* do not tolerate vulnerable
* remove prints
* handle multithreading progress bar
* update tests
* optimize function and add hub bucket prefix
* docstrings and linting
* rebase with master
* bad rebase
* trying to fix codecov
* uncomment codebuild-ci
---------
Co-authored-by: ci <ci>
Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
Co-authored-by: Anton Repushko <repuanto@amazon.com>
Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com>
Co-authored-by: Justin <justinm088@hotmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com>
Co-authored-by: Shing Lyu <shing.lyu@gmail.com>
Co-authored-by: Shing Lyu <shinglyu@amazon.nl>
Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com>
Co-authored-by: Jonathan Makunga <makung@amazon.com>
Co-authored-by: stacicho <stacicho@amazon.com>
Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>
erickb336 added a commit
that referenced
this pull request
Mar 19, 2024
@erickb336@gverkes
@akrishna1995Ashwin Krishna@knikure@samruds@adtian2@sirutBuasai@dbushy727@xiongz945Xiong Zeng@martinRenou@qidewenwhen@mrudulmn@Captainia@liujiaorr@evakravi@ruhanprasad@mufaddal-rohawala@repushko
Merge master into master-assets (#4515)
3cdefeb
* fix: make sure gpus are found in local_gpu run (#4384)
* fix: make sure gpus are found in local_gpu run
* fix: black formatting
* fix: adjust unit test
* feat: pin dll version to support python3.11 to the sdk (#4472)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* fix: Skip No Canvas regions for test_deploy_best_candidate (#4477)
* prepare release v2.211.0
* update development version to v2.211.1.dev0
* change: Enhance model builder selection logic to include model size (#4429)
* change: Enhance model builder selection logic to include model size
* Fix conflicts
* Address PR comments
* fix formatting
* fix formatting of test
* Fix token in tasks.json
* Increase coverage for tests
* fix formatting
* Fix requirements
* Import code instead of importing accelerate
* Fix formatting
* Setup dependencies
* change: Upgrade smp to version 2.2 (#4479)
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* upgrading smp to version 2.2
* fixing linting issue
* fixing syntax error with multiline if statement
* fixing formatting
---------
Co-authored-by: Andrew Tian <tinandr@amazon.com>
* feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481)
* update pt2.2 sm training dlc pysdk
* update pt2.2 sm inference dlc pysdk and region list
* fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
* prepare release v2.212.0
* update development version to v2.212.1.dev0
* change: Update tblib constraint (#4452)
* fix: make unit tests compatible with pytest-xdist (#4486)
* fix: make unit tests compatible with pytest-xdist
* fix failing test
* feature: Add overriding logic in ModelBuilder when task is provided (#4460)
* feat: Add Optional task to Model
* Revert "feat: Add Optional task to Model"
This reverts commit fd3e86b.
* Add override logic in ModelBuilder with task provided
* Adjusted formatting
* Add extra unit tests for invalid inputs
* Address PR comments
* Add more test inputs to integration test
* Add model_metadata field to ModelBuilder
* Update doc
* Update doc
* Adjust formatting
---------
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
* feature: Accept user-defined env variables for the entry-point (#4175)
* fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487)
* change: enable github actions for PRs (#4489)
* change: enable github actions for PRs
* Update codebuild-ci.yml
* trigger on pull_request_target
* add source-version-override
* fix permission
* feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492)
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* feat: support JumpStart proprietary models (#4467)
* feat: add proprietary manifest/specs parsing
add unittests for test_cache
small refactoring
address comments and more unittests
fix linting and fix more tests
fix: pylint
feat: JumpStartModel class for prop models
* remove unused imports and fix docstyle
* fix: remove unused args
* fix: remove unused args
* fix: more unused vars
* fix: slow tests
* fix: unittests
* added more tests to cover some lines
* remove estimator warn check
* chore: address comments re performance
* fix: address comments
* complete list experience and other fixes
* fix: pylint
* add doc utils and fix pylint
* fix: docstyle
* fix: doc
* fix: default payloads
* fix: doc and tags and enums
* fix: jumpstart doc
* rename to open_weights and fix filtering
* update filter name
* doc update
* fix: black
* rename to proprietary model and fix unittests
* address comments
* fix: docstyle and flake8
* address more comments and fix doc
* put back doc utils for future refactoring
* add prop model title in doc
* doc update
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485)
* fix: raise exception when no instance specific gated training env var available
* chore: raise client exception if accept_eula flag is not set for gated models
* chore: address flake8 errors
* chore: emit warning when instance type is chosen with no gated training artifacts
* fix: sagemaker session region not being used (#4469)
* fix: sagemaker session region not being used
* chore: add unit tests
* fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments
* chore: use get_region_fallback throughout
* chore: remove unnecessary if statement
* chore: remove unnecessary if statement (2)
---------
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
* fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480)
* Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2
* formatting
* formatting
---------
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* change: split coverage out from testenv in tox.ini (#4495)
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
* change: add ci-health checks (#4493)
* feat: tgi optimum 0.0.19, 0.0.20 releases (#4496)
* feature: Add support for Streaming Inference (#4497)
* feature: Add support for Streaming Inference
* fix: codestyle-docs-test
* fix: codestyle-docs-test
* Add AutoML -> AutoMLV2 mapper (#4500)
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
* Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504)
* Improvement of the tuner documentation (#4506)
* prepare release v2.213.0
* update development version to v2.213.1.dev0
* fix:urge customers to install latest version (#4507)
* fix: list jumpstart models with invalid version strings (#4511)
* fix: list jumpstart models with invalid versions
* docstyle
* docstyle
* pylint
* add more test
* fix
* fix: skip failing pt test (#4512)
* fix: skip failing pt test
* black-format
---------
Co-authored-by: gv <gverkes@users.noreply.github.com>
Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com>
Co-authored-by: Ashwin Krishna <ashwikri@amazon.com>
Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>
Co-authored-by: ci <ci>
Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com>
Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com>
Co-authored-by: Andrew Tian <tinandr@amazon.com>
Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com>
Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com>
Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com>
Co-authored-by: Samrudhi Sharma <samruds@amazon.com>
Co-authored-by: Xiong Zeng <xionzeng@amazon.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com>
Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Co-authored-by: Anton Repushko <repushko.a@gmail.com>
malav-shastri pushed a commit
to malav-shastri/sagemaker-python-sdk
that referenced
this pull request
Jun 20, 2024
@knikureroot
fix: Create custom tarfile extractall util to fix backward compatibil…
4533521
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
jiapinw pushed a commit
to jiapinw/sagemaker-python-sdk
that referenced
this pull request
Jun 25, 2024
@knikure@jiapinw
fix: Create custom tarfile extractall util to fix backward compatibil…
f0eea12
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
@Evan-W-ang
fix: Create custom tarfile extractall util to fix backward compatibil…
d6896a2
…ity issue (aws#4476)
* fix: Create custom tarfile extractall util to fix backward compatibility issue
* Address review comments
* fix logger.error statements
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mufaddal-rohawalamufaddal-rohawalamufaddal-rohawala approved these changes
@liujiaorrliujiaorrAwaiting requested review from liujiaorrliujiaorr was automatically assigned from aws/sagemaker-ml-frameworks

+1 more reviewer

@qidewenwhenqidewenwhenqidewenwhen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@knikure@mufaddal-rohawala@diggerdan@johnrwoolley@qidewenwhen