Feat/gated model support by bencrabtree · Pull Request #4510 · aws/sagemaker-python-sdk

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

bencrabtree · 2024-03-18T13:50:56Z

Issue #, if available:

Description of changes:

Adds support for gated models and models with training unsupported

Testing done:

Added unit tests for all new functions / logic pathways. Manually tested with Llama2-13b and other training unsupported

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…aws#4487)

* feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com>

…art model cache (aws#4438)

…erializers, and predictor (aws#4463)

…aws#4448)

* first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting

codecov · 2024-03-18T14:22:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master-jumpstart-curated-hub@d820b28). Click here to learn what that means.

Additional details and impacted files

@@ Coverage Diff @@## master-jumpstart-curated-hub #4510 +/- ##
===============================================================
Coverage ? 87.18% ===============================================================
Files ? 397 Lines ? 37256 Branches ? 0 ===============================================================
Hits ? 32481 Misses ? 4775 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-18T15:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29733c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-18T18:25:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: aa8e4cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2024-03-18T20:42:26Z

 for dependency in HubContentDependencyType:
 location: S3ObjectLocation = public_model_data_accessor.get_s3_reference(dependency)
+ # Training dependencies will return as None if training is unsupported
+ if not location or is_gated_bucket(location.bucket):


why are we checking for gated?

We don't want to / can't copy any files over from the gated bucket

evakravi · 2024-03-18T20:43:02Z

+ model_version=self.model_specs.version,
+ script_scope=model_scope,
+ )
+ except ValueError:


log something perhaps?

Yeah, we can log something here, though I don't think we'll ever reach this since we're only calling this function if training is supported

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

qidewenwhenand others added 12 commits March 15, 2024 21:27

fix: Move sagemaker pysdk version check after bootstrap in remote job (…
f7677d8
…aws#4487)

feat: add hub and hubcontent support in retrieval function for jumpst…
2973f23
…art model cache (aws#4438)

feat: jsch jumpstart estimator support (aws#4439)
5bc742f

Master jumpstart curated hub (aws#4464)
9210e49

add hub_arn support for accept_types, content_types, serializers, des…
4905cee
…erializers, and predictor (aws#4463)

feature: JumpStart CuratedHub class creation and function definitions (…
82d0d92
…aws#4448)

rebase with master
cb81d11

bad rebase
f50de6b

support for gated and training unsupported
2eff8fb

merge with master-curated-jumpstart
b50c557

bencrabtree requested a review from a team as a code owner March 18, 2024 13:50

bencrabtree requested review from knikure and removed request for a teamMarch 18, 2024 13:50

linting
1af132e

mabunday reviewed Mar 18, 2024
View reviewed changes

Comment threadsrc/sagemaker/jumpstart/curated_hub/accessors/public_model_data.py Outdated

update types
c9f79fd

akozd approved these changes Mar 18, 2024
View reviewed changes

update
29733c8

bencrabtree added 2 commits March 18, 2024 16:34

update bootstrap
352f1ac

fix codecov
aa8e4cb

evakravi reviewed Mar 18, 2024
View reviewed changes

evakravi approved these changes Mar 18, 2024
View reviewed changes

erickb336 self-assigned this Mar 18, 2024

erickb336 approved these changes Mar 18, 2024
View reviewed changes

erickb336 merged commit a632795 into aws:master-jumpstart-curated-hubMar 18, 2024

Uh oh!

Conversation

bencrabtree commented Mar 18, 2024

Merge Checklist

General

Tests

Uh oh!

Uh oh!

codecovBot commented Mar 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mufaddal-rohawala commented Mar 18, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Mar 18, 2024

AWS CodeBuild CI Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bencrabtreeMar 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

bencrabtree commented Mar 18, 2024

Merge Checklist

General

Tests

Uh oh!

Uh oh!

codecovBot commented Mar 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mufaddal-rohawala commented Mar 18, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Mar 18, 2024

AWS CodeBuild CI Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bencrabtreeMar 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

bencrabtree commented Mar 18, 2024

Merge Checklist

General

Tests

Uh oh!

Uh oh!

codecovBot commented Mar 18, 2024•
edited
Loading

bencrabtreeMar 18, 2024•
edited
Loading

codecovBot commented Mar 18, 2024•
edited
Loading

bencrabtreeMar 18, 2024•
edited
Loading

codecovBot commented Mar 18, 2024•
edited
Loading

bencrabtreeMar 18, 2024•
edited
Loading

codecovBot commented Mar 18, 2024•
edited
Loading