Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: support config_name in all JumpStart interfaces#4583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
a576415e8e4a0bb49576b111a85e974ab06825c1d234890f18cedbdcb71946feef6819d8462a5d5e50b8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -77,6 +77,7 @@ def retrieve_default( | ||
| tolerate_deprecated_model: bool = False, | ||
| sagemaker_session: Session = DEFAULT_JUMPSTART_SAGEMAKER_SESSION, | ||
| model_type: JumpStartModelType = JumpStartModelType.OPEN_WEIGHTS, | ||
| config_name: Optional[str] = None, | ||
| ) -> str: | ||
| """Retrieves the default accept type for the model matching the given arguments. | ||
| @@ -98,6 +99,7 @@ def retrieve_default( | ||
| object, used for SageMaker interactions. If not | ||
| specified, one is created using the default AWS configuration | ||
| chain. (Default: sagemaker.jumpstart.constants.DEFAULT_JUMPSTART_SAGEMAKER_SESSION). | ||
| config_name (Optional[str]): Name of the JumpStart Model config to apply. (Default: None). | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check with @judyheflin about how to describe this | ||
| Returns: | ||
| str: The default accept type to use for the model. | ||
| @@ -117,4 +119,5 @@ def retrieve_default( | ||
| tolerate_deprecated_model, | ||
| sagemaker_session=sagemaker_session, | ||
| model_type=model_type, | ||
| config_name=config_name, | ||
| ) | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future, we should think of a way to consolidate all these JS related fields perhaps into a dataclass or kwargs, so we don't need to update all these function prototypes whenever a new feature is added.