Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,12 @@
CHANGELOG
=========

1.13.1.dev
==========

* feature: Estimator: make input channels optional


1.13.0
======

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,7 +53,7 @@ def read(fname):
],

# Declare minimal set for installation
install_requires=['boto3>=1.4.8', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
install_requires=['boto3>=1.9.38', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3 >=1.21, <1.23',
'PyYAML>=3.2', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.21.0'],

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -176,7 +176,7 @@ def _prepare_for_training(self, job_name=None):
else:
self.output_path = 's3://{}/'.format(self.sagemaker_session.default_bucket())

def fit(self, inputs, wait=True, logs=True, job_name=None):
def fit(self, inputs=None, wait=True, logs=True, job_name=None):
"""Train a model using the input training dataset.

The API calls the Amazon SageMaker CreateTrainingJob API to start model training.
Expand Down
11 changes: 8 additions & 3 deletions src/sagemaker/job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,7 @@ def _load_config(inputs, estimator):

model_channel = _Job._prepare_model_channel(input_config, estimator.model_uri, estimator.model_channel_name)
if model_channel:
input_config = [] if input_config is None else input_config
input_config.append(model_channel)

return {'input_config': input_config,
Expand All@@ -75,6 +76,9 @@ def _load_config(inputs, estimator):

@staticmethod
def _format_inputs_to_input_config(inputs):
if inputs is None:
return None

# Deferred import due to circular dependency
from sagemaker.amazon.amazon_estimator import RecordSet
if isinstance(inputs, RecordSet):
Expand DownExpand Up@@ -130,9 +134,10 @@ def _prepare_model_channel(input_config, model_uri=None, model_channel_name=None
elif not model_channel_name:
raise ValueError('Expected a pre-trained model channel name if a model URL is specified.')

for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')
if input_config:
for channel in input_config:
if channel['ChannelName'] == model_channel_name:
raise ValueError('Duplicate channels not allowed.')

model_input = _Job._format_model_uri_input(model_uri)
model_channel = _Job._convert_input_to_channel(model_channel_name, model_input)
Expand Down
4 changes: 3 additions & 1 deletion src/sagemaker/session.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,14 +257,16 @@ def train(self, image, input_mode, input_config, role, job_name, output_config,
'TrainingImage': image,
'TrainingInputMode': input_mode
},
'InputDataConfig': input_config,
'OutputDataConfig': output_config,
'TrainingJobName': job_name,
'StoppingCondition': stop_condition,
'ResourceConfig': resource_config,
'RoleArn': role,
}

if input_config is not None:
train_request['InputDataConfig'] = input_config

if hyperparameters and len(hyperparameters) > 0:
train_request['HyperParameters'] = hyperparameters

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/tensorflow/estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,7 +207,7 @@ def _validate_requirements_file(self, requirements_file):
if not os.path.exists(os.path.join(self.source_dir, requirements_file)):
raise ValueError('Requirements file {} does not exist.'.format(requirements_file))

def fit(self, inputs, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
def fit(self, inputs=None, wait=True, logs=True, job_name=None, run_tensorboard_locally=False):
"""Train a model using the input training dataset.

See :func:`~sagemaker.estimator.EstimatorBase.fit` for more details.
Expand Down
9 changes: 3 additions & 6 deletions tests/integ/test_chainer_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,18 +105,15 @@ def test_async_fit(sagemaker_session):
def test_failed_training_job(sagemaker_session, chainer_full_version):
with timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
script_path = os.path.join(DATA_DIR, 'chainer_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'chainer_mnist')

chainer = Chainer(entry_point=script_path, role='SageMakerRole',
framework_version=chainer_full_version, py_version=PYTHON_VERSION,
train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = chainer.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/chainer_mnist/train')

with pytest.raises(ValueError):
chainer.fit(train_input)
with pytest.raises(ValueError) as e:
chainer.fit()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this test have an assert?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that ValueError is raised, but i can add and assert for error message text.

assert 'This failure is expected' in str(e.value)


def _run_mnist_training_job(sagemaker_session, instance_type, instance_count,
Expand Down
6 changes: 1 addition & 5 deletions tests/integ/test_mxnet_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,15 +105,11 @@ def test_async_fit(sagemaker_session, mxnet_full_version):
def test_failed_training_job(sagemaker_session, mxnet_full_version):
with timeout():
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'failure_script.py')
data_path = os.path.join(DATA_DIR, 'mxnet_mnist')

mx = MXNet(entry_point=script_path, role='SageMakerRole', framework_version=mxnet_full_version,
py_version=PYTHON_VERSION, train_instance_count=1, train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

train_input = mx.sagemaker_session.upload_data(path=os.path.join(data_path, 'train'),
key_prefix='integ-test-data/mxnet_mnist/train-failure')

with pytest.raises(ValueError) as e:
mx.fit(train_input)
mx.fit()
assert 'This failure is expected' in str(e.value)
2 changes: 1 addition & 1 deletion tests/integ/test_pytorch_train.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ def test_failed_training_job(sagemaker_session, pytorch_full_version):
pytorch = _get_pytorch_estimator(sagemaker_session, pytorch_full_version, entry_point=script_path)

with pytest.raises(ValueError) as e:
pytorch.fit(_upload_training_data(pytorch))
pytorch.fit()
assert 'This failure is expected' in str(e.value)


Expand Down
4 changes: 1 addition & 3 deletions tests/integ/test_tf.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,8 +160,6 @@ def test_failed_tf_training(sagemaker_session, tf_full_version):
train_instance_type='ml.c4.xlarge',
sagemaker_session=sagemaker_session)

inputs = estimator.sagemaker_session.upload_data(path=DATA_PATH, key_prefix='integ-test-data/tf-failure')

with pytest.raises(ValueError) as e:
estimator.fit(inputs)
estimator.fit()
assert 'This failure is expected' in str(e.value)
44 changes: 33 additions & 11 deletions tests/unit/test_estimator.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -706,19 +706,10 @@ def test_unsupported_type_in_dict():
#################################################################################
# Tests for the generic Estimator class

BASE_TRAIN_CALL = {
NO_INPUT_TRAIN_CALL = {
'hyperparameters': {},
'image': IMAGE_NAME,
'input_config': [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}],
'input_config': None,
'input_mode': 'File',
'output_config': {'S3OutputPath': OUTPUT_PATH},
'resource_config': {
Expand All@@ -731,12 +722,43 @@ def test_unsupported_type_in_dict():
'vpc_config': None
}

INPUT_CONFIG = [{
'DataSource': {
'S3DataSource': {
'S3DataDistributionType': 'FullyReplicated',
'S3DataType': 'S3Prefix',
'S3Uri': 's3://bucket/training-prefix'
}
},
'ChannelName': 'train'
}]

BASE_TRAIN_CALL = dict(NO_INPUT_TRAIN_CALL)
BASE_TRAIN_CALL.update({'input_config': INPUT_CONFIG})

HYPERPARAMS = {'x': 1, 'y': 'hello'}
STRINGIFIED_HYPERPARAMS = dict([(x, str(y)) for x, y in HYPERPARAMS.items()])
HP_TRAIN_CALL = dict(BASE_TRAIN_CALL)
HP_TRAIN_CALL.update({'hyperparameters': STRINGIFIED_HYPERPARAMS})


def test_generic_to_fit_no_input(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)

e.fit()

sagemaker_session.train.assert_called_once()
assert len(sagemaker_session.train.call_args[0]) == 0
args = sagemaker_session.train.call_args[1]
assert args['job_name'].startswith(IMAGE_NAME)

args.pop('job_name')
args.pop('role')

assert args == NO_INPUT_TRAIN_CALL


def test_generic_to_fit_no_hps(sagemaker_session):
e = Estimator(IMAGE_NAME, ROLE, INSTANCE_COUNT, INSTANCE_TYPE, output_path=OUTPUT_PATH,
sagemaker_session=sagemaker_session)
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/test_job.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,29 @@ def test_load_config_with_model_channel(estimator):
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_load_config_with_model_channel_no_inputs(estimator):
estimator.model_uri = MODEL_URI
estimator.model_channel_name = CHANNEL_NAME

config = _Job._load_config(inputs=None, estimator=estimator)

assert config['input_config'][0]['DataSource']['S3DataSource']['S3Uri'] == MODEL_URI
assert config['input_config'][0]['ChannelName'] == CHANNEL_NAME
assert config['role'] == ROLE
assert config['output_config']['S3OutputPath'] == S3_OUTPUT_PATH
assert 'KmsKeyId' not in config['output_config']
assert config['resource_config']['InstanceCount'] == INSTANCE_COUNT
assert config['resource_config']['InstanceType'] == INSTANCE_TYPE
assert config['resource_config']['VolumeSizeInGB'] == VOLUME_SIZE
assert config['stop_condition']['MaxRuntimeInSeconds'] == MAX_RUNTIME


def test_format_inputs_none():
channels = _Job._format_inputs_to_input_config(inputs=None)

assert channels is None


def test_format_inputs_to_input_config_string():
inputs = BUCKET_NAME

Expand Down