Uh oh!
There was an error while loading. Please reload this page.
Add Pylint - #465
Conversation
Codecov Report
@@ Coverage Diff @@## master #465 +/- ##
==========================================
+ Coverage 94% 94.13% +0.12%
==========================================
Files 57 57 Lines 4284 4259 -25 ==========================================
- Hits 4027 4009 -18 + Misses 257 250 -7
Continue to review full report at Codecov.
|
| signature-differs | ||
There was a problem hiding this comment.
is the inconsistent number of newlines between sections intentional?
Uh oh!
There was an error while loading. Please reload this page.
| [TYPECHECK] | ||
| # Tells whether missing members accessed in mixin class should be ignored. A | ||
| # mixin class is detected if its name ends with "mixin" (case insensitive). | ||
| #ignore-mixin-members=yes |
There was a problem hiding this comment.
is it worth keeping around these commented-out config lines?
| #class-rgx=[A-Z_][a-zA-Z0-9]+$ | ||
| # Regular expression which should only match correct function names | ||
| # | ||
| # |
There was a problem hiding this comment.
do we need these empty comment lines?
| [LOGGING] | ||
| # Apply logging string format checks to calls on these modules. | ||
| logging-modules= | ||
| logging No newline at end of file |
There was a problem hiding this comment.
add a newline to the end of the file
| 1.14.1dev | ||
| ========= | ||
| * bug-fix: rename MXNet argument from accelerators -> accelerator |
There was a problem hiding this comment.
- add a newline between ll. 6-7
- also don't you mean
distributions->distribution? - does this count as a breaking change?
| class _TrainingJob(_Job): | ||
| def __init__(self, sagemaker_session, training_job_name): | ||
| def __init__(self, sagemaker_session, training_job_name): # pylint: disable=useless-super-delegation |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| # Maximum number of lines in a module | ||
| #max-module-lines=1000 | ||
| # String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 | ||
| # tab). |
There was a problem hiding this comment.
do we really need to break the line on this comment?
Add Pylint checking. Fixed all the current errors and warnings, any future PRs will fail if they introduce any pylint error/warnings.
This adds pylint to the build process - will fail for any Warning/Error on the main codebase. Tests are no included yet.
The handling of the MXNet distribution parameter was being done in Framework instead of MXNet. Pylint flagged this so this PR also fixes that. distributions is now also called distribution which is what was originally intended.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.