Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/sagemaker/model.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,7 @@
ModelCard,
ModelPackageModelCard,
)
from sagemaker.model_card.helpers import _hash_content_str
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.session import Session
from sagemaker.model_metrics import ModelMetrics
Expand DownExpand Up@@ -2426,3 +2427,44 @@ def add_inference_specification(
)

sagemaker_session.sagemaker_client.update_model_package(**model_package_update_args)

def update_model_card(self, model_card: Union[ModelCard, ModelPackageModelCard]):
"""Updates Created model card content which created with model package

Args:
model_card (ModelCard | ModelPackageModelCard): Updated Model Card content
"""

sagemaker_session = self.sagemaker_session or sagemaker.Session()
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=self.model_package_arn
)
update_model_card_req = model_card._create_request_args()
if update_model_card_req["ModelCardStatus"] is not None:
if (
desc_model_package["ModelCard"]["ModelCardStatus"]
== update_model_card_req["ModelCardStatus"]
):
del update_model_card_req["ModelCardStatus"]

if update_model_card_req.get("ModelCardName") is not None:
del update_model_card_req["ModelCardName"]
if update_model_card_req.get("Content") is not None:
previous_content_hash = _hash_content_str(
desc_model_package["ModelCard"]["ModelCardContent"]
)
current_content_hash = _hash_content_str(update_model_card_req["Content"])
if (
previous_content_hash == current_content_hash
or update_model_card_req.get("Content") == "{}"
or update_model_card_req.get("Content") == "null"
):
del update_model_card_req["Content"]
Comment thread
selvask-aws marked this conversation as resolved.
else:
update_model_card_req["ModelCardContent"] = update_model_card_req["Content"]
del update_model_card_req["Content"]
update_model_package_args = {
"ModelPackageArn": self.model_package_arn,
"ModelCard": update_model_card_req,
}
sagemaker_session.sagemaker_client.update_model_package(**update_model_package_args)
4 changes: 2 additions & 2 deletions src/sagemaker/model_card/model_card.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1890,8 +1890,8 @@ class ModelPackageModelCard(object):

def __init__(
self,
model_card_content: Dict[str, Any],
model_card_status: str,
model_card_content: Optional[Dict[str, Any]] = None,
model_card_status: Optional[str] = None,
):

self.model_card_content = model_card_content
Expand Down
221 changes: 220 additions & 1 deletion tests/integ/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,8 +12,17 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import json
import os
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import (
AdditionalInformation,
BusinessDetails,
IntendedUses,
ModelCard,
ModelOverview,
ModelPackageModelCard,
)
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum
from sagemaker.utils import unique_name_from_base
from tests.integ import DATA_DIR
from sagemaker.xgboost import XGBoostModel
Expand DownExpand Up@@ -183,6 +192,216 @@ def test_update_source_uri(sagemaker_session):
assert desc_model_package["SourceUri"] == source_uri


def test_update_model_card_with_model_card_object(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
intended_uses = IntendedUses(
purpose_of_model="Test model card.",
intended_uses="Not used except this test.",
factors_affecting_model_efficiency="No.",
risk_rating="Low",
explanations_for_risk_rating="Just an example.",
)
business_details = BusinessDetails(
business_problem="The business problem that your model is used to solve.",
business_stakeholders="The stakeholders who have the interest in the business that your model is used for.",
line_of_business="Services that the business is offering.",
)
additional_information = AdditionalInformation(
ethical_considerations="Your model ethical consideration.",
caveats_and_recommendations="Your model's caveats and recommendations.",
custom_details={"custom details1": "details value"},
)

model_overview = ModelOverview(model_creator="TestCreator")

my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
intended_uses=intended_uses,
business_details=business_details,
additional_information=additional_information,
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_overview = ModelOverview(model_creator="updatedCreator")
updated_intended_uses = IntendedUses(
purpose_of_model="Updated Test model card.",
)
updated_my_card = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
model_overview=updated_model_overview,
intended_uses=updated_intended_uses,
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelCard(
name="TestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_update_model_card_with_model_card_json(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")
model_card_content = {
"model_overview": {
"model_creator": "TestCreator",
},
"intended_uses": {
"purpose_of_model": "Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=model_card_content
)

sagemaker_session.sagemaker_client.create_model_package_group(
ModelPackageGroupName=model_group_name
)

xgb_model_data_s3 = sagemaker_session.upload_data(
path=os.path.join(_XGBOOST_PATH, "xgb_model.tar.gz"),
key_prefix="integ-test-data/xgboost/model",
)
model = XGBoostModel(
model_data=xgb_model_data_s3, framework_version="1.3-1", sagemaker_session=sagemaker_session
)

model_package = model.register(
content_types=["text/csv"],
response_types=["text/csv"],
inference_instances=["ml.m5.large"],
transform_instances=["ml.m5.large"],
model_package_group_name=model_group_name,
model_card=my_card,
)

desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

updated_model_card_content = {
"model_overview": {
"model_creator": "updatedCreator",
},
"intended_uses": {
"purpose_of_model": "Updated Test model card.",
"intended_uses": "Not used except this test.",
"factors_affecting_model_efficiency": "No.",
"risk_rating": "Low",
"explanations_for_risk_rating": "Just an example.",
},
"business_details": {
"business_problem": "The business problem that your model is used to solve.",
"business_stakeholders": "The stakeholders who have the interest in the business.",
"line_of_business": "Services that the business is offering.",
},
"evaluation_details": [
{
"name": "Example evaluation job",
"evaluation_observation": "Evaluation observations.",
"metric_groups": [
{
"name": "binary classification metrics",
"metric_data": [{"name": "accuracy", "type": "number", "value": 0.5}],
}
],
}
],
"additional_information": {
"ethical_considerations": "Your model ethical consideration.",
"caveats_and_recommendations": 'Your model"s caveats and recommendations.',
"custom_details": {"custom details1": "details value"},
},
}
updated_my_card = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.DRAFT, model_card_content=updated_model_card_content
)
model_package.update_model_card(updated_my_card)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

model_card_content = json.loads(desc_model_package["ModelCard"]["ModelCardContent"])
assert model_card_content["intended_uses"]["purpose_of_model"] == "Updated Test model card."
assert model_card_content["model_overview"]["model_creator"] == "updatedCreator"
updated_my_card_status = ModelPackageModelCard(
model_card_status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(updated_my_card_status)
desc_model_package = sagemaker_session.sagemaker_client.describe_model_package(
ModelPackageName=model_package.model_package_arn
)

assert desc_model_package["ModelCard"]["ModelCardStatus"] == ModelCardStatusEnum.PENDING_REVIEW


def test_clone_model_package_using_source_uri(sagemaker_session):
model_group_name = unique_name_from_base("test-model-group")

Expand Down
52 changes: 51 additions & 1 deletion tests/unit/sagemaker/model/test_model_package.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,8 @@

import sagemaker
from sagemaker.model import ModelPackage
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum
from sagemaker.model_card.model_card import ModelCard, ModelOverview
from sagemaker.model_card.schema_constraints import ModelApprovalStatusEnum, ModelCardStatusEnum

MODEL_PACKAGE_VERSIONED_ARN = (
"arn:aws:sagemaker:us-west-2:001234567890:model-package/testmodelgroup/1"
Expand DownExpand Up@@ -56,6 +57,10 @@
"ModelPackageStatus": "Completed",
"ModelPackageName": "mp-scikit-decision-trees-1542410022-2018-11-20-22-13-56-502",
"CertifyForMarketplace": False,
"ModelCard": {
"ModelCardStatus": "Draft",
"ModelCardContent": '{"model_overview": {"model_creator": "updatedCreator", "model_artifact": []}}',
},
}

MODEL_DATA = {
Expand DownExpand Up@@ -442,3 +447,48 @@ def test_update_source_uri(sagemaker_session):
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, SourceUri=source_uri
)


def test_update_model_card(sagemaker_session):
model_package_response = copy.deepcopy(DESCRIBE_MODEL_PACKAGE_RESPONSE)

sagemaker_session.sagemaker_client.describe_model_package = Mock(
return_value=model_package_response
)
model_package = ModelPackage(
role="role",
model_package_arn=MODEL_PACKAGE_VERSIONED_ARN,
sagemaker_session=sagemaker_session,
)

update_my_card = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.PENDING_REVIEW,
)
model_package.update_model_card(update_my_card)
update_my_card_req = update_my_card._create_request_args()
del update_my_card_req["ModelCardName"]
del update_my_card_req["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req
)

model_overview = ModelOverview(
model_creator="UpdatedNewCreator",
)
update_my_card_1 = ModelCard(
name="UpdateTestName",
sagemaker_session=sagemaker_session,
status=ModelCardStatusEnum.DRAFT,
model_overview=model_overview,
)
model_package.update_model_card(update_my_card_1)
update_my_card_req_1 = update_my_card_1._create_request_args()
del update_my_card_req_1["ModelCardName"]
del update_my_card_req_1["ModelCardStatus"]
update_my_card_req_1["ModelCardContent"] = update_my_card_req_1["Content"]
del update_my_card_req_1["Content"]
sagemaker_session.sagemaker_client.update_model_package.assert_called_with(
ModelPackageArn=MODEL_PACKAGE_VERSIONED_ARN, ModelCard=update_my_card_req_1
)