Fixing container path for source files when using local_session by bearpelican · Pull Request #499 · aws/sagemaker-python-sdk

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican · 2018-11-19T05:57:02Z

Issue #, if available:
Fixes: No such file or directory error when running estimator fit/predict with a local sagemaker session and a local script.

When running sagemaker in local mode, sagemaker_submit_directory is set to the the local environment path (Ex: file:///home/ec2-user/mnist/src'), when it should be set to the container path - '/opt/ml/code'. The container path is mounted in src/local/image.py.
The container does not have access to the local environment path, which is why a No such file or directory error happens.

Minimal example that breaks:
https://gist.github.com/bearpelican/440d10f28003c3653c7866c129418ad7

This was taken directly from the sagemaker example notebook:
https://github.com/awslabs/amazon-sagemaker-examples/tree/master/sagemaker-python-sdk/pytorch_mnist

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated the changelog with a description of my changes (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2018-11-19T06:00:44Z

Codecov Report

Merging #499 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #499 +/- ##
==========================================
+ Coverage 92.77% 92.79% +0.01% 
==========================================
Files 71 71 Lines 5359 5371 +12 ==========================================
+ Hits 4972 4984 +12 
Misses 387 387

Impacted Files	Coverage Δ
src/sagemaker/local/image.py	`88.53% <100%> (+0.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bac185...81cdfd4. Read the comment docs.

bearpelican · 2018-11-19T08:39:25Z

Not sure if this is the best way to fix the bug, but I wanted to put this here as an issue and proposed fix. If anyone has any other ideas, please feel free to submit a new PR and close this one!

laurenyu

Thanks for the contribution! Would you mind adding some tests?

bearpelican · 2018-11-22T04:56:47Z

Yup will do

bearpelican · 2018-12-11T00:19:20Z

Updated commit - 5f54934 with extended unit tests

laurenyu · 2018-12-11T00:56:22Z

Thanks for updating! There are a couple flake8 errors:

flake8 runtests: commands[0] | flake8
./src/sagemaker/local/image.py:111:1: W293 blank line contains whitespace
./src/sagemaker/local/image.py:338:1: W293 blank line contains whitespace

bearpelican · 2018-12-11T19:24:36Z

Cool. Should be fixed now!

laurenyu · 2018-12-11T21:21:01Z

 volumes = self._prepare_training_volumes(data_dir, input_data_config, output_data_config,
 hyperparameters)
+ # If local, source directory needs to be updated to mounted /opt/ml/code path
+ hyperparameters = self._update_local_src_path(hyperparameters, key=sagemaker.estimator.DIR_PARAM_NAME)


an integ test is failing because it expects this hyperparameter to be JSON (at least for the SageMaker deep learning framework images)

Ah good catch! Updated hyperparameters with json conversion

Unable to run integration tests on my machine, so please let me know if there are any more errors on those tests

Copying env variable instead Adding tests forl local code

laurenyu · 2018-12-13T22:49:30Z

@bearpelican the integ tests look fine now, but could you add the changelog entry to a new 1.16.3 section? (1.16.2 got released yesterday)

…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

bearpelican mentioned this pull request Nov 19, 2018
Running from local source file mattmcclean/sagemaker-reinvent-chalktalk-2018#1
Merged

laurenyu reviewed Nov 19, 2018
View reviewed changes

bearpelican force-pushed the local_code branch 2 times, most recently from 4118b9d to 5f54934Compare December 11, 2018 00:18

bearpelican force-pushed the local_code branch from 5f54934 to fb7269dCompare December 11, 2018 00:24

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 94da7e6December 11, 2018 01:37

bearpelican force-pushed the local_code branch from fb7269d to 94da7e6Compare December 11, 2018 01:37

bearpelican mentioned this pull request Dec 11, 2018
Fixing rmtree error when uri and path is the same aws/sagemaker-containers#151
Merged

laurenyu previously approved these changes Dec 11, 2018
View reviewed changes

laurenyu reviewed Dec 11, 2018
View reviewed changes

bearpelican dismissed laurenyu’s stale review via 516ffb4December 12, 2018 00:38

bearpelican force-pushed the local_code branch from 63c43c7 to 516ffb4Compare December 12, 2018 00:38

Fixing container path for source files when using local_session
6a73652
Copying env variable instead Adding tests forl local code

bearpelican force-pushed the local_code branch from 516ffb4 to 6a73652Compare December 12, 2018 01:01

ChoiByungWook added 2 commits December 12, 2018 16:44

Merge branch 'master' into local_code
a39eccc

Merge branch 'master' into local_code
e614e73

Updating changelog with 1.16.3
81cdfd4

laurenyu approved these changes Dec 14, 2018
View reviewed changes

jesterhazy merged commit 9174d5b into aws:masterDec 14, 2018

metrizable pushed a commit to metrizable/sagemaker-python-sdk that referenced this pull request Dec 1, 2020
documentation: add pipeline rst docs and address grammatical issues (a…
560de69
…ws#499)

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
Fix container path for source files when using local_session (aws#499)
2773633

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
documentation: add pipeline rst docs and address grammatical issues (a…
20e7b83
…ws#499)

Uh oh!

Conversation

bearpelican commented Nov 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

Uh oh!

codecov-io commented Nov 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bearpelican commented Nov 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laurenyu left a comment

Choose a reason for hiding this comment

Uh oh!

bearpelican commented Nov 22, 2018

Uh oh!

bearpelican commented Dec 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laurenyu commented Dec 11, 2018

Uh oh!

bearpelican commented Dec 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laurenyu commented Dec 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

bearpelican commented Nov 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

Uh oh!

codecov-io commented Nov 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bearpelican commented Nov 19, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laurenyu left a comment

Choose a reason for hiding this comment

Uh oh!

bearpelican commented Nov 22, 2018

Uh oh!

bearpelican commented Dec 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laurenyu commented Dec 11, 2018

Uh oh!

bearpelican commented Dec 11, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laurenyu commented Dec 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

bearpelican commented Nov 19, 2018•
edited
Loading

codecov-io commented Nov 19, 2018•
edited
Loading

bearpelican commented Nov 19, 2018•
edited
Loading

bearpelican commented Dec 11, 2018•
edited
Loading

bearpelican commented Nov 19, 2018•
edited
Loading

codecov-io commented Nov 19, 2018•
edited
Loading

bearpelican commented Nov 19, 2018•
edited
Loading

bearpelican commented Dec 11, 2018•
edited
Loading

bearpelican commented Nov 19, 2018•
edited
Loading

codecov-io commented Nov 19, 2018•
edited
Loading

bearpelican commented Nov 19, 2018•
edited
Loading

bearpelican commented Dec 11, 2018•
edited
Loading