fix: Replace HMAC with SHA based integrity checks in model builder. by pravali96 · Pull Request #5656 · aws/sagemaker-python-sdk

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 · 2026-03-19T22:58:46Z

Issue #, if available:

Description of changes:
Replace HMAC with SHA based integrity checks in model builder.

Issue

Fix

Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)

Changes

check_integrity.py

Removed generate_secret_key() — no longer needed
compute_hash() now uses hashlib.sha256() instead of hmac.new()
perform_integrity_check() no longer reads SAGEMAKER_SERVE_SECRET_KEY from environment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nargokul

Please fix integ test failures.

nargokul · 2026-03-31T20:48:07Z

 metadata.write(_MetaData(hash_value).to_json())

- return secret_key
+ return ""


Nit: We need not return anything here

The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?

it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.

Removed the return statements.

…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.

pravali96 requested a review from a team as a code owner March 19, 2026 22:58

pravali96 requested a review from mollyheamazon March 19, 2026 22:58

pravali96 temporarily deployed to auto-approve March 19, 2026 22:58 — with GitHub Actions Inactive

pravali96 temporarily deployed to auto-approve March 19, 2026 23:10 — with GitHub Actions Inactive

pravali96 force-pushed the fix/triton-hmac-security-v2-all-bugs branch from 6e9283e to 8fe96c8Compare March 20, 2026 17:48

pravali96 temporarily deployed to auto-approve March 20, 2026 17:48 — with GitHub Actions Inactive

pravali96 temporarily deployed to auto-approve March 20, 2026 17:49 — with GitHub Actions Inactive

pravali96 force-pushed the fix/triton-hmac-security-v2-all-bugs branch from c8d05ec to 079e1f2Compare March 20, 2026 19:08

pravali96 temporarily deployed to auto-approve March 20, 2026 19:08 — with GitHub Actions Inactive

pravali96 temporarily deployed to auto-approve March 20, 2026 19:20 — with GitHub Actions Inactive

pravali96 temporarily deployed to auto-approve March 31, 2026 16:32 — with GitHub Actions Inactive

pravali96 changed the title ~~fix: Security fixes for Triton HMAC key exposure and missing integrit…~~fix: fixes for Triton HMAC key exposure and missing integrit…Mar 31, 2026

pravali96 changed the title ~~fix: fixes for Triton HMAC key exposure and missing integrit…~~fix: Replace HMAC with SHA based integrity checks in model builder.Mar 31, 2026

nargokul requested changes Mar 31, 2026
View reviewed changes

gwang111 approved these changes Mar 31, 2026
View reviewed changes

pravali96 force-pushed the fix/triton-hmac-security-v2-all-bugs branch 2 times, most recently from 079e1f2 to 334346aCompare March 31, 2026 22:15

pravali96 temporarily deployed to auto-approve March 31, 2026 22:15 — with GitHub Actions Inactive

pravali96 temporarily deployed to auto-approve March 31, 2026 22:18 — with GitHub Actions Inactive

pravali96 force-pushed the fix/triton-hmac-security-v2-all-bugs branch from 95dc333 to a809727Compare March 31, 2026 22:47

pravali96 temporarily deployed to auto-approve March 31, 2026 22:47 — with GitHub Actions Inactive

pravali96 temporarily deployed to auto-approve March 31, 2026 22:50 — with GitHub Actions Inactive

pravali96 force-pushed the fix/triton-hmac-security-v2-all-bugs branch from 032f58f to d10bf43Compare April 1, 2026 00:01

pravali96 temporarily deployed to auto-approve April 1, 2026 00:01 — with GitHub Actions Inactive

nargokul approved these changes Apr 1, 2026
View reviewed changes

nargokul merged commit 48f45da into aws:master-v2Apr 1, 2026
9 of 11 checks passed

pravali96 deleted the fix/triton-hmac-security-v2-all-bugs branch April 1, 2026 17:00