Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mujtaba1747 merged 3 commits into from
Mar 30, 2026
Merged

Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name. #5692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7ae22d
Fix lambda function handler name
mollyheamazon Mar 27, 2026
a7bdf55
Add integ test
mollyheamazon Mar 27, 2026
b7be9b9
Update integ test to wait for lambda call
mollyheamazon Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-train/src/sagemaker/ai_registry/evaluator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
# Create Lambda function
lambda_client = boto3.client("lambda")
function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
handler_name = "lambda_function.lambda_handler"

@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.

Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.


try:
lambda_response = lambda_client.create_function(
Expand Down
16 changes: 16 additions & 0 deletions sagemaker-train/tests/integ/ai_registry/conftest.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
"""Create a raw Python Lambda file with a non-default filename to test handler derivation."""
code = '''import json
def lambda_handler(event, context):
return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
f.write(code)
f.flush()
os.fsync(f.fileno())
fname = f.name
yield fname
os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
"""Create sample Lambda function code as zip."""
Expand Down
41 changes: 41 additions & 0 deletions sagemaker-train/tests/integ/ai_registry/test_evaluator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
assert evaluator.method == EvaluatorMethod.BYOC
assert evaluator.reference is not None

def test_create_reward_function_from_local_py_file_and_invoke(
self, unique_name, sample_lambda_py_file, test_role, cleanup_list
):
"""End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

Regression test for the handler name bug where the Lambda was created with an incorrect
handler derived from the source filename instead of 'lambda_function.lambda_handler'.
"""
import json
import boto3

evaluator = Evaluator.create(
name=unique_name,
type=REWARD_FUNCTION,
source=sample_lambda_py_file,
role=test_role,
wait=True, # wait for Lambda to be active
)
cleanup_list.append(evaluator)
assert evaluator.method == EvaluatorMethod.BYOC
assert evaluator.reference is not None

# Wait for Lambda to become Active before invoking
lambda_client = boto3.client("lambda")
waiter = lambda_client.get_waiter("function_active_v2")
waiter.wait(FunctionName=evaluator.reference)

# Invoke the Lambda directly to verify the handler is correct
lambda_client = boto3.client("lambda")
response = lambda_client.invoke(
FunctionName=evaluator.reference,
InvocationType="RequestResponse",
Payload=json.dumps({"input": "test"}).encode(),
)
assert response["StatusCode"] == 200
assert "FunctionError" not in response, (
f"Lambda invocation failed with error: {response.get('FunctionError')}"
)
result = json.loads(response["Payload"].read())
assert result.get("statusCode") == 200

def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
"""Test retrieving evaluator by name."""
try:
Expand Down
3 changes: 3 additions & 0 deletions sagemaker-train/tests/unit/ai_registry/test_evaluator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

assert evaluator.method == EvaluatorMethod.BYOC
mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.
mock_lambda_client.create_function.assert_called_once()
call_kwargs = mock_lambda_client.create_function.call_args[1]
assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

@patch('sagemaker.ai_registry.evaluator.AIRHub')
def test_get_all(self, mock_air_hub):
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.#5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mujtaba1747
merged 3 commits into

from

Mar 30, 2026
 Merged


Fix: hardcode handler_name = "lambda_function.lambda_handler" to match the zip entry name.
#5692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c7ae22d

Fix lambda function handler name


mollyheamazon Mar 27, 2026
a7bdf55

Add integ test


mollyheamazon Mar 27, 2026
b7be9b9

Update integ test to wait for lambda call


mollyheamazon Mar 27, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
sagemaker-train/src/sagemaker/ai_registry/evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -382,7 +382,7 @@ def _create_lambda_function(cls, name: str, source_file: str, role: Optional[str
 # Create Lambda function
 lambda_client = boto3.client("lambda")
 function_name = f"SageMaker-evaluator-{name}-{datetime.now().strftime('%Y%m%d_%H%M%S')}"
 handler_name = f"{os.path.splitext(os.path.basename(source_file))[0]}.lambda_handler"
 handler_name = "lambda_function.lambda_handler"
@mufaddal-rohawalamufaddal-rohawalaMar 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself makes sense if the zip archive always packages the source file as lambda_function.py regardless of the original filename. However, this introduces a subtle coupling — the hardcoded string "lambda_function.lambda_handler" must match whatever entry name is used when building the zip. Consider extracting this as a module-level constant (e.g., LAMBDA_HANDLER_NAME = "lambda_function.lambda_handler") and adding a comment explaining why it's hardcoded (i.e., the zip archive always renames the source to lambda_function.py). This will prevent future contributors from "fixing" it back to the dynamic version.
Also, as a pre-existing issue: this method calls boto3.client("lambda") directly (line 383). Per V3 architecture tenets, all AWS API interactions should go through sagemaker-core rather than calling boto3 directly. This is out of scope for this PR, but worth tracking.

 try:
 lambda_response = lambda_client.create_function(
Expand Down

16 changes: 16 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,22 @@ def sample_jsonl_file():
 os.unlink(f.name)


@pytest.fixture
def sample_lambda_py_file():
 """Create a raw Python Lambda file with a non-default filename to test handler derivation."""
 code = '''import json
def lambda_handler(event, context):
 return {"statusCode": 200, "body": json.dumps({"score": 0.9})}
'''
 with tempfile.NamedTemporaryFile(mode='w', suffix='.py', prefix='my_custom_evaluator_', delete=False) as f:
 f.write(code)
 f.flush()
 os.fsync(f.fileno())
 fname = f.name
 yield fname
 os.unlink(fname)


@pytest.fixture
def sample_lambda_code():
 """Create sample Lambda function code as zip."""
Expand Down

41 changes: 41 additions & 0 deletions
sagemaker-train/tests/integ/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -81,6 +81,47 @@ def test_create_reward_function_from_local_code(self, unique_name, sample_lambda
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 def test_create_reward_function_from_local_py_file_and_invoke(
 self, unique_name, sample_lambda_py_file, test_role, cleanup_list
 ):
 """End-to-end test: create evaluator from a raw .py file with non-default name and invoke it.

 Regression test for the handler name bug where the Lambda was created with an incorrect
 handler derived from the source filename instead of 'lambda_function.lambda_handler'.
 """
 import json
 import boto3

 evaluator = Evaluator.create(
 name=unique_name,
 type=REWARD_FUNCTION,
 source=sample_lambda_py_file,
 role=test_role,
 wait=True, # wait for Lambda to be active
 )
 cleanup_list.append(evaluator)
 assert evaluator.method == EvaluatorMethod.BYOC
 assert evaluator.reference is not None

 # Wait for Lambda to become Active before invoking
 lambda_client = boto3.client("lambda")
 waiter = lambda_client.get_waiter("function_active_v2")
 waiter.wait(FunctionName=evaluator.reference)

 # Invoke the Lambda directly to verify the handler is correct
 lambda_client = boto3.client("lambda")
 response = lambda_client.invoke(
 FunctionName=evaluator.reference,
 InvocationType="RequestResponse",
 Payload=json.dumps({"input": "test"}).encode(),
 )
 assert response["StatusCode"] == 200
 assert "FunctionError" not in response, (
 f"Lambda invocation failed with error: {response.get('FunctionError')}"
 )
 result = json.loads(response["Payload"].read())
 assert result.get("statusCode") == 200

 def test_get_evaluator(self, unique_name, sample_prompt_file, cleanup_list):
 """Test retrieving evaluator by name."""
 try:
Expand Down

3 changes: 3 additions & 0 deletions
sagemaker-train/tests/unit/ai_registry/test_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,6 +77,9 @@ def test_create_with_byoc(self, mock_air_hub, mock_boto3):

 assert evaluator.method == EvaluatorMethod.BYOC
 mock_air_hub.upload_to_s3.assert_called_once()
Comment thread
mollyheamazon marked this conversation as resolved.

 mock_lambda_client.create_function.assert_called_once()
 call_kwargs = mock_lambda_client.create_function.call_args[1]
 assert call_kwargs["Handler"] == "lambda_function.lambda_handler"

 @patch('sagemaker.ai_registry.evaluator.AIRHub')
 def test_get_all(self, mock_air_hub):
Expand Down
Loading