fix(integ): remove module-level env var from MTRL tests by lucasjia-aws · Pull Request #5929 · aws/sagemaker-python-sdk

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T00:00:12Z

The 4 MTRL test files added in #5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1.

Changes:

Remove os.environ.setdefault() calls from module level in all 4 files
Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects)
Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage)
Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management

Affected files:

test_mtrl_evaluator.py
test_mtrl_evaluator_3p_agent.py
test_mtrl_trainer_integration.py
test_multi_turn_rl_trainer_integration.py

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws · 2026-06-05T01:40:08Z

gpu-integ-test-us-east-1 succeeds on this commit: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/784379639078/projects/sagemaker-python-sdk-ci-health-gpu-integ-tests/build/sagemaker-python-sdk-ci-health-gpu-integ-tests%3Af2cf97ea-7864-4b10-a27a-f536dfbd4297/log?region=us-east-1

The 4 MTRL test files added in aws#5919 set SAGEMAKER_REGION=us-west-2 at module level via os.environ.setdefault(). When pytest collects tests, it imports all modules in the directory—including these files—even when filtering by mark (e.g. -m "gpu_intensive and us_east_1"). This poisons the SageMakerClient singleton's region for the entire process, causing the Nova us-east-1 integ tests (SFT, RLVR, BenchmarkEvaluator) to fail with "ModelPackageGroup does not exist" because API calls land in us-west-2 instead of us-east-1. Changes: - Remove os.environ.setdefault() calls from module level in all 4 files - Move _ACCOUNT_ID resolution from module-level boto3 calls into lazy fixtures/functions (avoids import-time side effects) - Use boto3.Session().client() pattern instead of boto3.client() to follow SDK conventions (wrapper over boto, not direct boto usage) - Align with existing test patterns (DPO, SFT, RLVR) that rely on conftest fixtures for session management Affected files: - test_mtrl_evaluator.py - test_mtrl_evaluator_3p_agent.py - test_mtrl_trainer_integration.py - test_multi_turn_rl_trainer_integration.py

lucasjia-aws temporarily deployed to auto-approve June 5, 2026 00:00 — with GitHub Actions Inactive