Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsareddy0329 merged 2 commits into from
Jul 22, 2026
Merged

Fix role issue in mtrl integ tests #6070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92bb181
Fix role issue in mtrl integ tests
Jul 21, 2026
e13958d
Fix role issue in mtrl integ tests
Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions sagemaker-train/tests/integ/train/test_mtrl_evaluator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
"""Build test configuration lazily (only when tests actually run)."""
boto_session = boto3.Session(region_name=_REGION)
account_id = boto_session.client("sts").get_caller_identity()["Account"]
from sagemaker.core.helper.session_helper import Session
from sagemaker.train.defaults import TrainDefaults
sagemaker_session = Session(boto_session=boto_session)
role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
return {
"base_model": "mock-oss-test",
"agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
"dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
"s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
"mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
"model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
"role": f"arn:aws:iam::{account_id}:role/Admin",
"role": role_arn,
"region": _REGION,
"account_id": account_id,
}
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
dataset=test_config["dataset"],
s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
agent_config=test_config["agent_arn"],
agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
evaluator._resolve_agent_arn()

ctx = evaluator._build_template_context(
aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
"role_arn": test_config["role"]},
aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
artifacts={},
model_package_group_arn=test_config["model_package_group"],
)
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
dataset=test_config["dataset"],
s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
agent_config=lambda_arn,
)
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
evaluator._resolve_agent_arn()

ctx = evaluator._build_template_context(
aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
"role_arn": test_config["role"]},
aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
artifacts={},
model_package_group_arn=test_config["model_package_group"],
)
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
dataset=test_config["dataset"],
s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
agent_config=test_config["agent_arn"],
)
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
evaluator._resolve_agent_arn()

ctx = evaluator._build_template_context(
aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
"role_arn": test_config["role"]},
aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
artifacts={},
model_package_group_arn=test_config["model_package_group"],
)
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
dataset=test_config["dataset"],
s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
agent_config=test_config["agent_arn"],
)
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
agent_config=test_config["agent_arn"],
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
)

Expand Down
7 changes: 0 additions & 7 deletions sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
"MTRL_3P_MLFLOW_ARN",
f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
),
"role": os.environ.get(
"MTRL_3P_ROLE",
f"arn:aws:iam::{account_id}:role/Admin",
),
"region": os.environ.get("MTRL_3P_REGION", _REGION),
"account_id": account_id,
}
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
agent_config=lambda_agent_arn,
s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
accept_eula=True,
)
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
agent_config=agent,
s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
accept_eula=True,
)
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
agent_config=lambda_agent_arn,
s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
mlflow_resource_arn=test_config["mlflow_resource_arn"],
role=test_config["role"],
region=test_config["region"],
accept_eula=True,
)
Expand Down
8 changes: 1 addition & 7 deletions sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
boto_session = boto3.Session(region_name=_REGION)
return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
"s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
"mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
"model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
"role": "arn:aws:iam::729646638167:role/Admin",
},
# PREPROD — Staging account (391266019386)
"391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
"s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
"mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
"model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
"role": "arn:aws:iam::391266019386:role/Admin",
},
# BETA — Dev/test account (742774200982)
"742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
"s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
"mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
"model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
"role": "arn:aws:iam::742774200982:role/Admin",
},
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
output_model_package_group=config["model_package_group"],
mlflow_app_arn=config["mlflow_resource_arn"],
s3_output_path=config["s3_output_path"],
role=config["role"],
accept_eula=True,
)
trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
dataset=config["dataset"],
s3_output_path=f'{config["s3_output_path"]}finetuned/',
mlflow_resource_arn=config["mlflow_resource_arn"],
role=config["role"],
region=_REGION,
)

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
agent_config=config["agent_core_arn"],
s3_output_path=f'{config["s3_output_path"]}basemodel/',
mlflow_resource_arn=config["mlflow_resource_arn"],
role=config["role"],
region=_REGION,
)

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
dataset=config["dataset"],
s3_output_path=f'{config["s3_output_path"]}comparison/',
mlflow_resource_arn=config["mlflow_resource_arn"],
role=config["role"],
region=_REGION,
evaluate_base_model=True,
)
Expand Down
4 changes: 0 additions & 4 deletions sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
"""Resolve account-specific resource ARNs lazily."""
account_id = _get_account_id()
return {
"role_arn": f"arn:aws:iam::{account_id}:role/Admin",
"mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
"s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
"s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
training_dataset=test_resources["s3_input_path"],
mlflow_app_arn=test_resources["mlflow_arn"],
s3_output_path=test_resources["s3_output_path"],
role=test_resources["role_arn"],
accept_eula=True,
sagemaker_session=sagemaker_session,
)
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
agent_env=AGENT_RUNTIME_ID,
training_dataset=test_resources["s3_input_path"],
mlflow_app_arn=test_resources["mlflow_arn"],
role=test_resources["role_arn"],
accept_eula=True,
sagemaker_session=sagemaker_session,
)
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
mlflow_app_arn=test_resources["mlflow_arn"],
s3_output_path=test_resources["s3_output_path"],
accept_eula=True,
role=test_resources["role_arn"],
sagemaker_session=sagemaker_session,
)
trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix role issue in mtrl integ tests#6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rsareddy0329
merged 2 commits into

from

Jul 22, 2026
 Merged


Fix role issue in mtrl integ tests
#6070
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
92bb181

Fix role issue in mtrl integ tests

Jul 21, 2026
e13958d

Fix role issue in mtrl integ tests

Jul 22, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 8 additions & 12 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -40,14 +40,18 @@ def _get_test_config():
 """Build test configuration lazily (only when tests actually run)."""
 boto_session = boto3.Session(region_name=_REGION)
 account_id = boto_session.client("sts").get_caller_identity()["Account"]
 from sagemaker.core.helper.session_helper import Session
 from sagemaker.train.defaults import TrainDefaults
 sagemaker_session = Session(boto_session=boto_session)
 role_arn = TrainDefaults.get_role(role=None, sagemaker_session=sagemaker_session)
 return {
 "base_model": "mock-oss-test",
 "agent_arn": f"arn:aws:bedrock-agentcore:{_REGION}:{account_id}:runtime/sagemaker_rft_prod_gsm8k_streaming-Yk6O377mUS",
 "dataset": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/output-artifacts/",
 "mlflow_resource_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": f"arn:aws:sagemaker:{_REGION}:{account_id}:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": f"arn:aws:iam::{account_id}:role/Admin",
 "role": role_arn,
 "region": _REGION,
 "account_id": account_id,
 }
Expand DownExpand Up@@ -172,7 +176,6 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-bedrock/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 agent_qualifier="PROD",
Expand All@@ -182,8 +185,7 @@ def test_bedrock_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -208,7 +210,6 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-lambda/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=lambda_arn,
 )
Expand All@@ -217,8 +218,7 @@ def test_lambda_agent_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand All@@ -239,7 +239,6 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-fields-mpc/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -248,8 +247,7 @@ def test_model_package_config_fields(self, mtrl_trainer, test_config):
 evaluator._resolve_agent_arn()

 ctx = evaluator._build_template_context(
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"],
 "role_arn": test_config["role"]},
 aws_context={"region": test_config["region"], "account_id": test_config["account_id"], "role_arn": test_config["role"]},
 artifacts={},
 model_package_group_arn=test_config["model_package_group"],
 )
Expand DownExpand Up@@ -280,7 +278,6 @@ def test_evaluator_construction_with_trainer(self, mtrl_trainer, test_config):
 dataset=test_config["dataset"],
 s3_output_path=f'{test_config["s3_output_path"]}integ-construct/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 agent_config=test_config["agent_arn"],
 )
Expand All@@ -298,7 +295,6 @@ def test_evaluator_construction_with_base_model(self, test_config):
 s3_output_path=f'{test_config["s3_output_path"]}integ-base/',
 agent_config=test_config["agent_arn"],
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 )

Expand Down

7 changes: 0 additions & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_evaluator_3p_agent.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,10 +161,6 @@ def _get_3p_test_config():
 "MTRL_3P_MLFLOW_ARN",
 f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 ),
 "role": os.environ.get(
 "MTRL_3P_ROLE",
 f"arn:aws:iam::{account_id}:role/Admin",
 ),
 "region": os.environ.get("MTRL_3P_REGION", _REGION),
 "account_id": account_id,
 }
Expand DownExpand Up@@ -258,7 +254,6 @@ def test_evaluate_with_lambda_agent_wait_for_completion(self, lambda_agent_arn,
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-e2e/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -304,7 +299,6 @@ def test_evaluate_base_model_with_agent_lambda_object(self, lambda_agent_arn, te
 agent_config=agent,
 s3_output_path=f'{test_config["s3_output_path"]}lambda-object/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand DownExpand Up@@ -332,7 +326,6 @@ def test_evaluate_with_attached_trainer(self, lambda_agent_arn, test_config):
 agent_config=lambda_agent_arn,
 s3_output_path=f'{test_config["s3_output_path"]}attached-trainer/',
 mlflow_resource_arn=test_config["mlflow_resource_arn"],
 role=test_config["role"],
 region=test_config["region"],
 accept_eula=True,
 )
Expand Down

8 changes: 1 addition & 7 deletions
sagemaker-train/tests/integ/train/test_mtrl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@ def _get_account_id():
 boto_session = boto3.Session(region_name=_REGION)
 return boto_session.client("sts").get_caller_identity()["Account"]


# ============================================================
# Per-account resource configuration
# ============================================================
Expand All@@ -60,7 +61,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-729646638167/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:729646638167:mlflow-app/app-TTAUWUNMUHH6",
 "model_package_group": "arn:aws:sagemaker:us-west-2:729646638167:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::729646638167:role/Admin",
 },
 # PREPROD — Staging account (391266019386)
 "391266019386": {
Expand All@@ -72,7 +72,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-391266019386/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:391266019386:mlflow-app/app-P3FRQFRQTNGI",
 "model_package_group": "arn:aws:sagemaker:us-west-2:391266019386:model-package-group/mtrl-integ-gpt-oss-agentcore",
 "role": "arn:aws:iam::391266019386:role/Admin",
 },
 # BETA — Dev/test account (742774200982)
 "742774200982": {
Expand All@@ -84,7 +83,6 @@ def _get_account_id():
 "s3_output_path": "s3://sagemaker-us-west-2-742774200982/mtrl-integ/eval-output/",
 "mlflow_resource_arn": "arn:aws:sagemaker:us-west-2:742774200982:mlflow-app/app-6ZU5TXXH2GUX",
 "model_package_group": "arn:aws:sagemaker:us-west-2:742774200982:model-package-group/openai-reasoning-gpt-oss-20b-mtrl-mpg",
 "role": "arn:aws:iam::742774200982:role/Admin",
 },
}

Expand DownExpand Up@@ -133,7 +131,6 @@ def attached_trainer(config):
 output_model_package_group=config["model_package_group"],
 mlflow_app_arn=config["mlflow_resource_arn"],
 s3_output_path=config["s3_output_path"],
 role=config["role"],
 accept_eula=True,
 )
 trainer._latest_job = job
Expand DownExpand Up@@ -165,7 +162,6 @@ def test_evaluate_finetuned_model(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}finetuned/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -195,7 +191,6 @@ def test_evaluate_base_model(self, config):
 agent_config=config["agent_core_arn"],
 s3_output_path=f'{config["s3_output_path"]}basemodel/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 )

Expand DownExpand Up@@ -225,7 +220,6 @@ def test_evaluate_comparison(self, attached_trainer, config):
 dataset=config["dataset"],
 s3_output_path=f'{config["s3_output_path"]}comparison/',
 mlflow_resource_arn=config["mlflow_resource_arn"],
 role=config["role"],
 region=_REGION,
 evaluate_base_model=True,
 )
Expand Down

4 changes: 0 additions & 4 deletions
sagemaker-train/tests/integ/train/test_multi_turn_rl_trainer_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,6 @@ def test_resources():
 """Resolve account-specific resource ARNs lazily."""
 account_id = _get_account_id()
 return {
 "role_arn": f"arn:aws:iam::{account_id}:role/Admin",
 "mlflow_arn": f"arn:aws:sagemaker:{_REGION}:{account_id}:mlflow-app/app-TTAUWUNMUHH6",
 "s3_input_path": f"s3://sagemaker-rft-{account_id}/prompts/gsm8k_small/prompts.parquet",
 "s3_output_path": f"s3://sagemaker-{_REGION}-{account_id}/model-evaluation/mtrl-trainer-integ/",
Expand All@@ -77,7 +76,6 @@ def test_train_and_wait(self, sagemaker_session, test_resources):
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand All@@ -101,7 +99,6 @@ def test_train_and_stop(self, sagemaker_session, test_resources):
 agent_env=AGENT_RUNTIME_ID,
 training_dataset=test_resources["s3_input_path"],
 mlflow_app_arn=test_resources["mlflow_arn"],
 role=test_resources["role_arn"],
 accept_eula=True,
 sagemaker_session=sagemaker_session,
 )
Expand DownExpand Up@@ -132,7 +129,6 @@ def test_train_with_lambda_arn(self, sagemaker_session, test_resources):
 mlflow_app_arn=test_resources["mlflow_arn"],
 s3_output_path=test_resources["s3_output_path"],
 accept_eula=True,
 role=test_resources["role_arn"],
 sagemaker_session=sagemaker_session,
 )
 trainer.hyperparameters.global_batch_size = 32
Expand Down
Loading