fix: Fixing EULA check, relying on HostingEulaUri field by langyn · Pull Request #6077 · aws/sagemaker-python-sdk

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

langyn · 2026-07-22T14:53:34Z

Summary
As of sagemaker 3.15.1, ModelBuilder.deploy() refuses to proceed without accept_eula=True for JumpStart models that declare no HostingEulaUri in their hub content document. This blocks deployment of Apache-2.0 models such as huggingface-llm-qwen2-5-7b-instruct and forces users (and downstream agents) to prompt for and "accept" an EULA that doesn't exist. Meta / Llama models — which do have a real HostingEulaUri — are correctly gated. The gate should key off the model metadata; today it appears to apply universally.
Environment

sagemaker 3.15.1 (also 3.12.0, upgraded to 3.15.1 mid-session in one repro)
Region: us-west-2
Python 3.12
Path: sagemaker.serve.bedrock_model_builder.BedrockModelBuilder and the JumpStart ModelBuilder(...).deploy() path
Expected behavior
The SDK's EULA gate should be driven by the model's hub content:
If HostingEulaUri is present in the HubContentDocument → require accept_eula=True.
If it's absent → no acceptance required, deploy() proceeds without the flag.
Actual behavior
deploy() requires accept_eula=True regardless of whether the model declares a HostingEulaUri. The message surfaces to callers as an SDK-level check on all JumpStart models. In two independent test runs, the agent driving deployment concluded (correctly, from what it observed):
"The ModelBuilder requires accept_eula=True for all JumpStart models regardless of license type (this is an SDK-level gate, not just for Meta models)."

mohamedzeidan2021

failing tests unrelated to change

aviruthen · 2026-07-23T18:03:56Z

- if not accept_eula:
+ # Only models that declare a hosting EULA (gated models such as
+ # Meta Llama) require explicit acceptance. Ungated models
+ # (Apache-2.0, MIT, etc.) carry no HostingEulaUri and must deploy


Nit: there's a bit too many comments here! Maybe we can make them shorter so that the code is a bit cleaner...?

aviruthen · 2026-07-23T18:05:13Z

Were you able to test that acceptance/denial of EULA is working correctly post-fix? It's okay if this was tested locally (and not a full integ test)!

fix: Fixing EULA check, relying on HostingEulaUri field
485e50d

langyn had a problem deploying to manual-approval July 22, 2026 14:53 — with GitHub Actions Error

langyn temporarily deployed to manual-approval July 22, 2026 14:53 — with GitHub Actions Inactive

mohamedzeidan2021 approved these changes Jul 23, 2026
View reviewed changes

Merge branch 'master' into fix/eula-gate-hosting-eula-uri
5af52cb

mohamedzeidan2021 temporarily deployed to manual-approval July 23, 2026 17:59 — with GitHub Actions Inactive

aviruthen reviewed Jul 23, 2026
View reviewed changes

aviruthen approved these changes Jul 24, 2026
View reviewed changes

mohamedzeidan2021 merged commit 0e226bb into aws:masterJul 24, 2026
13 of 19 checks passed

github-actionsBot mentioned this pull request Jul 24, 2026
Release 3.17.0 #6099
Merged