Uh oh!
There was an error while loading. Please reload this page.
change: make start time, end time and period configurable in sagemaker.analytics.TrainingJobAnalytics - #730
Merged
Conversation
…ngJobAnalytics Creating an TrainingJobAnalytics object fails if the training job has too many data points in the specified metrics. Make start time, end time and period configurable so the caller can get around this limit - https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_GetMetricStatistics.html Original issue: aws#701
jesterhazy
commented
Mar 29, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jesterhazy
commented
Mar 29, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jesterhazy
commented
Mar 29, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
left a comment
Contributor
There was a problem hiding this comment.
don't forget to add the correct prefix to your PR title
| self._training_job_name = training_job_name | ||
| self._start_time = start_time | ||
| self._end_time = end_time | ||
| self._period = period if period else 60 |
Contributor
There was a problem hiding this comment.
should we make the default a constant?
| start_time = datetime.datetime(2018, 5, 16, 1, 3, 4) | ||
| end_time = datetime.datetime(2018, 5, 16, 5, 1, 1) | ||
| period = 300 | ||
| trainer = TrainingJobAnalytics("my-training-job", ["metric"], |
jesterhazy
commented
Apr 1, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jesterhazy
commented
Apr 1, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jesterhazy
commented
Apr 1, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
reviewed
Apr 1, 2019
| self._training_job_name = training_job_name | ||
| self._start_time = start_time | ||
| self._end_time = end_time | ||
| self._period = period if period else METRICS_PERIOD_DEFAULT |
Contributor
There was a problem hiding this comment.
I think you could also do period or METRICS_PERIOD_DEFAULT?
Uh oh!
There was an error while loading. Please reload this page.
| sagemaker_session=sagemaker_session, | ||
| py_version='py3', | ||
| framework_version=TensorFlow.LATEST_VERSION, | ||
| metric_definitions=[{'Name': 'train:global_steps', 'Regex': 'global_step\/sec:\s(.*)'}], # noqa |
Contributor
There was a problem hiding this comment.
does flake no longer enforce two spaces before the "#" on an inline comment? also, what's the noqa for?
ContributorAuthor
There was a problem hiding this comment.
flake8 doesn't like the \s and /
Contributor
There was a problem hiding this comment.
does it go away if you do r'global_step\/sec:\s(.*)'?
jesterhazy
commented
Apr 2, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
commented
Apr 2, 2019
Contributor
don't forget to make the PR title match the guidelines in https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md#commit-message-guidlines |
laurenyu
approved these changes
Apr 2, 2019
laurenyu
left a comment
Contributor
There was a problem hiding this comment.
I labeled this as a "change" in the PR title, but wasn't sure if you thought "feature" might be more appropriate
jesterhazy
commented
Apr 2, 2019
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
qidewenwhen added a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
qidewenwhen added a commit
to qidewenwhen/sagemaker-python-sdk
that referenced
this pull request
Dec 14, 2022
Co-authored-by: Dewen Qi <qidewen@amazon.com>
navinsoni pushed a commit
that referenced
this pull request
Dec 14, 2022
* feature: Add experiment plus Run class (#691) * feature: Add Experiment helper classes (#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (#696) * change: Update Run init and add Run load and _RunContext (#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (#754) * fix flaky metrics test (#753) * change: Change Run.init and Run.load to constructor and module method respectively (#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (#767) * Change: Minimize use of lower case tc name (#769) * change: Clean up test resources to remove model files (#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
claytonparnell pushed a commit
to claytonparnell/sagemaker-python-sdk
that referenced
this pull request
Dec 16, 2022
* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
mufaddal-rohawala pushed a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 19, 2022
* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
mufaddal-rohawala pushed a commit
that referenced
this pull request
Dec 20, 2022
* feature: Add experiment plus Run class (#691) * feature: Add Experiment helper classes (#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (#696) * change: Update Run init and add Run load and _RunContext (#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (#754) * fix flaky metrics test (#753) * change: Change Run.init and Run.load to constructor and module method respectively (#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (#767) * Change: Minimize use of lower case tc name (#769) * change: Clean up test resources to remove model files (#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
JoseJuan98 pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
nmadan pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
…r.analytics.TrainingJobAnalytics (aws#730) * Make start time, end time and period configurable in analytics.TrainingJobAnalytics Creating an TrainingJobAnalytics object fails if the training job has too many data points in the specified metrics. Make start time, end time and period configurable so the caller can get around this limit - https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_GetMetricStatistics.html Original issue: aws#701 * Add analytics integ test to the TensorFlow script mode minist test * Minor changes due to PR comments and to make flake8 happy * More minor changes * One more minor change
Evan-W-ang added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ngJobAnalytics
Creating an TrainingJobAnalytics object fails if the training job has too many
data points in the specified metrics. Make start time, end time and period
configurable so the caller can get around this limit -
https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_GetMetricStatistics.html
Original issue:
#701
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.