change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knakad merged 2 commits into from
Jul 15, 2019
Merged

change: enable attribute-defined-outside-init Pylint check #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9705ea
change: enable attribute-defined-outside-init Pylint check
knakad Jul 15, 2019
66cbcc2
Merge branch 'master' into 20190715-lint-attribute-defined-outside-init
knakad Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pylintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
import-error, # Since we run Pylint before any of our builds in tox, this will always fail
attribute-defined-outside-init, # TODO: Fix scope
protected-access, # TODO: Fix access
abstract-method, # TODO: Fix abstract methods
wrong-import-order, # TODO: Fix import order
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/amazon/amazon_estimator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
self.sagemaker_session.default_bucket()
)
self.data_location = data_location
self._data_location = data_location

@knakadknakadJul 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo


def train_image(self):
return get_image_uri(
Expand Down
8 changes: 8 additions & 0 deletions src/sagemaker/analytics.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
Understands common functionality like persistence and caching.
"""

def __init__(self):
self._dataframe = None

def export_csv(self, filename):
"""Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
sagemaker_session = sagemaker_session or Session()
self._sage_client = sagemaker_session.sagemaker_client
self._tuning_job_name = hyperparameter_tuning_job_name
self._tuning_job_describe_result = None
self._training_job_summaries = None
super(HyperparameterTuningJobAnalytics, self).__init__()
self.clear_cache()

@property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
self._metric_names = metric_names
else:
self._metric_names = self._metric_names_for_training_job()

super(TrainingJobAnalytics, self).__init__()
self.clear_cache()

@property
Expand Down
3 changes: 3 additions & 0 deletions src/sagemaker/estimator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
self.output_path = output_path
self.output_kms_key = output_kms_key
self.latest_training_job = None
self.deploy_instance_type = None

self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
self.image_name = image_name
self._enable_network_isolation = enable_network_isolation

self.uploaded_code = None

self._hyperparameters = hyperparameters or {}

def enable_network_isolation(self):
Expand Down
5 changes: 4 additions & 1 deletion src/sagemaker/local/entities.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
self.model_artifacts = self.container.train(
input_data_config, output_data_config, hyperparameters, job_name
)
self.end = datetime.datetime.now()
self.end_time = datetime.datetime.now()

@knakadknakadJul 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

self.state = self._COMPLETED

def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
self.start_time = None
self.end_time = None
self.batch_strategy = None
self.transform_resources = None
self.input_data = None
self.output_data = None
self.environment = {}
self.state = _LocalTransformJob._CREATING

Expand Down
1 change: 1 addition & 0 deletions src/sagemaker/model.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
self.vpc_config = vpc_config
self.sagemaker_session = sagemaker_session
self._model_name = None
self.endpoint_name = None
self._is_compiled_model = False
self._enable_network_isolation = enable_network_isolation

Expand Down
1 change: 1 addition & 0 deletions src/sagemaker/pipeline.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
self.vpc_config = vpc_config
self.sagemaker_session = sagemaker_session
self._model_name = None
self.endpoint_name = None

def pipeline_container_def(self, instance_type):
"""Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down
1 change: 1 addition & 0 deletions src/sagemaker/tuner.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
self.latest_tuning_job = None
self.warm_start_config = warm_start_config
self.early_stopping_type = early_stopping_type
self.static_hyperparameters = None

def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
if job_name is not None:
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
change: enable attribute-defined-outside-init Pylint check#933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

knakad
merged 2 commits into

from

Jul 15, 2019
 Merged


change: enable attribute-defined-outside-init Pylint check
#933
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d9705ea

change: enable attribute-defined-outside-init Pylint check


knakad Jul 15, 2019
66cbcc2

Merge branch 'master' into 20190715-lint-attribute-defined-outside-init


knakad Jul 15, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
.pylintrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,6 @@ disable=
 line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
 len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
 import-error, # Since we run Pylint before any of our builds in tox, this will always fail
 attribute-defined-outside-init, # TODO: Fix scope
 protected-access, # TODO: Fix access
 abstract-method, # TODO: Fix abstract methods
 wrong-import-order, # TODO: Fix import order
Expand Down

2 changes: 1 addition & 1 deletion
src/sagemaker/amazon/amazon_estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def __init__(
 data_location = data_location or "s3://{}/sagemaker-record-sets/".format(
 self.sagemaker_session.default_bucket()
 )
 self.data_location = data_location
 self._data_location = data_location
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo

 def train_image(self):
 return get_image_uri(
Expand Down

8 changes: 8 additions & 0 deletions
src/sagemaker/analytics.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,9 @@ class AnalyticsMetricsBase(with_metaclass(ABCMeta, object)):
 Understands common functionality like persistence and caching.
 """

 def __init__(self):
 self._dataframe = None

 def export_csv(self, filename):
 """Persists the analytics dataframe to a file.

Expand DownExpand Up@@ -88,6 +91,9 @@ def __init__(self, hyperparameter_tuning_job_name, sagemaker_session=None):
 sagemaker_session = sagemaker_session or Session()
 self._sage_client = sagemaker_session.sagemaker_client
 self._tuning_job_name = hyperparameter_tuning_job_name
 self._tuning_job_describe_result = None
 self._training_job_summaries = None
 super(HyperparameterTuningJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand DownExpand Up@@ -240,6 +246,8 @@ def __init__(
 self._metric_names = metric_names
 else:
 self._metric_names = self._metric_names_for_training_job()

 super(TrainingJobAnalytics, self).__init__()
 self.clear_cache()

 @property
Expand Down

3 changes: 3 additions & 0 deletions
src/sagemaker/estimator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -166,6 +166,7 @@ def __init__(
 self.output_path = output_path
 self.output_kms_key = output_kms_key
 self.latest_training_job = None
 self.deploy_instance_type = None

 self._compiled_models = {}

Expand DownExpand Up@@ -1086,6 +1087,8 @@ def __init__(
 self.image_name = image_name
 self._enable_network_isolation = enable_network_isolation

 self.uploaded_code = None

 self._hyperparameters = hyperparameters or {}

 def enable_network_isolation(self):
Expand Down

5 changes: 4 additions & 1 deletion
src/sagemaker/local/entities.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ def start(self, input_data_config, output_data_config, hyperparameters, job_name
 self.model_artifacts = self.container.train(
 input_data_config, output_data_config, hyperparameters, job_name
 )
 self.end = datetime.datetime.now()
 self.end_time = datetime.datetime.now()
@knakadknakadJul 15, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relatively confident this was a typo
 self.state = self._COMPLETED

 def describe(self):
Expand DownExpand Up@@ -110,6 +110,9 @@ def __init__(self, transform_job_name, model_name, local_session=None):
 self.start_time = None
 self.end_time = None
 self.batch_strategy = None
 self.transform_resources = None
 self.input_data = None
 self.output_data = None
 self.environment = {}
 self.state = _LocalTransformJob._CREATING

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/model.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -100,6 +100,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None
 self._is_compiled_model = False
 self._enable_network_isolation = enable_network_isolation

Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/pipeline.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@ def __init__(
 self.vpc_config = vpc_config
 self.sagemaker_session = sagemaker_session
 self._model_name = None
 self.endpoint_name = None

 def pipeline_container_def(self, instance_type):
 """Return a dict created by ``sagemaker.pipeline_container_def()`` for deploying this model to a specified
Expand Down

1 change: 1 addition & 0 deletions
src/sagemaker/tuner.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -247,6 +247,7 @@ def __init__(
 self.latest_tuning_job = None
 self.warm_start_config = warm_start_config
 self.early_stopping_type = early_stopping_type
 self.static_hyperparameters = None

 def _prepare_for_training(self, job_name=None, include_cls_metadata=False):
 if job_name is not None:
Expand Down