Skip to content

test(capacity-provider): add integration test for ManagedResourceTags - #3983

Merged
vicheey merged 4 commits into
developfrom
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged

test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom
add-managed-resource-tags-integ-test

Conversation

@vicheey

@vicheeyvicheey commented Aug 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available

N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.

Description of changes

  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:

    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs

  2. Simplify ManagedResourceTags to Tags-only interface:

    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface

Description of how you validated changes

  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:
    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline

Checklist

Testing

Integration test

dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot reviewed Aug 24, 2026
View reviewed changes

@aws-sam-tooling-botaws-sam-tooling-botBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: bbc6a9a..5bb8346
Files: 16
Comments: 2

Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot reviewed Aug 24, 2026
View reviewed changes

@aws-sam-tooling-botaws-sam-tooling-botBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: bbc6a9a..7797cde
Files: 16
Comments: 2

Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view

@vicheey

vicheey commented Aug 24, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I removed CpNoManagedResourceTags

@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view

@vicheey
vicheey marked this pull request as ready for review August 24, 2026 18:51
@vicheey
vicheey requested a review from a team as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey merged commit b794d0a into developAug 24, 2026
9 checks passed
@vicheey
vicheey deleted the add-managed-resource-tags-integ-test branch August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test(capacity-provider): add integration test for ManagedResourceTags by vicheey · Pull Request #3983 · aws/serverless-application-model · GitHub
Skip to content
test(capacity-provider): add integration test for ManagedResourceTags - #3983
Merged
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged
test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Conversation
@vicheey
@vicheeyvicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available
N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.
Description of changes
  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:
    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs
  2. Simplify ManagedResourceTags to Tags-only interface:
    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface
Description of how you validated changes
  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:

    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline
Checklist
Testing
Integration test
dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..5bb8346

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..7797cde

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws
deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view
@vicheey
vicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I removed CpNoManagedResourceTags
@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view
@vicheey
vicheey
marked this pull request as ready for review
August 24, 2026 18:51
@vicheey
vicheey
requested a review
from a team
as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey
merged commit b794d0a
into
developAug 24, 2026

9 checks passed

@vicheey
vicheey
deleted the

add-managed-resource-tags-integ-test

branch
August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(capacity-provider): add integration test for ManagedResourceTags by vicheey · Pull Request #3983 · aws/serverless-application-model · GitHub
Skip to content
test(capacity-provider): add integration test for ManagedResourceTags - #3983
Merged
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged
test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Conversation
@vicheey
@vicheeyvicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available
N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.
Description of changes
  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:
    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs
  2. Simplify ManagedResourceTags to Tags-only interface:
    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface
Description of how you validated changes
  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:

    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline
Checklist
Testing
Integration test
dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..5bb8346

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..7797cde

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws
deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view
@vicheey
vicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I removed CpNoManagedResourceTags
@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view
@vicheey
vicheey
marked this pull request as ready for review
August 24, 2026 18:51
@vicheey
vicheey
requested a review
from a team
as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey
merged commit b794d0a
into
developAug 24, 2026

9 checks passed

@vicheey
vicheey
deleted the

add-managed-resource-tags-integ-test

branch
August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(capacity-provider): add integration test for ManagedResourceTags by vicheey · Pull Request #3983 · aws/serverless-application-model · GitHub
Skip to content
test(capacity-provider): add integration test for ManagedResourceTags - #3983
Merged
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged
test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Conversation
@vicheey
@vicheeyvicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available
N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.
Description of changes
  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:
    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs
  2. Simplify ManagedResourceTags to Tags-only interface:
    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface
Description of how you validated changes
  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:

    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline
Checklist
Testing
Integration test
dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..5bb8346

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..7797cde

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws
deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view
@vicheey
vicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I removed CpNoManagedResourceTags
@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view
@vicheey
vicheey
marked this pull request as ready for review
August 24, 2026 18:51
@vicheey
vicheey
requested a review
from a team
as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey
merged commit b794d0a
into
developAug 24, 2026

9 checks passed

@vicheey
vicheey
deleted the

add-managed-resource-tags-integ-test

branch
August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
test(capacity-provider): add integration test for ManagedResourceTags by vicheey · Pull Request #3983 · aws/serverless-application-model · GitHub
Skip to content
test(capacity-provider): add integration test for ManagedResourceTags - #3983
Merged
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged
test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Conversation
@vicheey
@vicheeyvicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available
N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.
Description of changes
  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:
    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs
  2. Simplify ManagedResourceTags to Tags-only interface:
    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface
Description of how you validated changes
  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:

    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline
Checklist
Testing
Integration test
dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..5bb8346

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..7797cde

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws
deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view
@vicheey
vicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I removed CpNoManagedResourceTags
@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view
@vicheey
vicheey
marked this pull request as ready for review
August 24, 2026 18:51
@vicheey
vicheey
requested a review
from a team
as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey
merged commit b794d0a
into
developAug 24, 2026

9 checks passed

@vicheey
vicheey
deleted the

add-managed-resource-tags-integ-test

branch
August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(capacity-provider): add integration test for ManagedResourceTags by vicheey · Pull Request #3983 · aws/serverless-application-model · GitHub
Skip to content
test(capacity-provider): add integration test for ManagedResourceTags - #3983
Merged
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged
test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Conversation
@vicheey
@vicheeyvicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available
N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.
Description of changes
  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:
    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs
  2. Simplify ManagedResourceTags to Tags-only interface:
    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface
Description of how you validated changes
  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:

    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline
Checklist
Testing
Integration test
dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..5bb8346

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..7797cde

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws
deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view
@vicheey
vicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I removed CpNoManagedResourceTags
@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view
@vicheey
vicheey
marked this pull request as ready for review
August 24, 2026 18:51
@vicheey
vicheey
requested a review
from a team
as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey
merged commit b794d0a
into
developAug 24, 2026

9 checks passed

@vicheey
vicheey
deleted the

add-managed-resource-tags-integ-test

branch
August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
test(capacity-provider): add integration test for ManagedResourceTags by vicheey · Pull Request #3983 · aws/serverless-application-model · GitHub
Skip to content
test(capacity-provider): add integration test for ManagedResourceTags - #3983
Merged
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Aug 24, 2026
Merged
test(capacity-provider): add integration test for ManagedResourceTags#3983
vicheey merged 4 commits into
developfrom 
add-managed-resource-tags-integ-test
Conversation
@vicheey
@vicheeyvicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Issue #, if available
N/A — test coverage improvement for ManagedResourceTags on AWS::Serverless::CapacityProvider.
Description of changes
  1. Add integration test for ManagedResourceTags.Tags on CapacityProvider:
    • Adds ManagedResourceTags: { Tags: { Environment: Production, Team: Lambda-Tooling } } to the existing AdvancedCapacityProvider in function_lmi_default.yaml
    • Asserts GetCapacityProvider returns PropagateTags.Mode: Explicit and ExplicitTags map with correct key-value pairs
  2. Simplify ManagedResourceTags to Tags-only interface:
    • Remove unused Propagate sub-property from schema source
    • Remove unused validation rule and generator path
    • Regenerate schema
    • Update unit test fixtures to reflect Tags-only interface
Description of how you validated changes
  • Unit tests: 789 passing (pytest with AWS_DEFAULT_REGION=us-east-1)
  • Schema tests: 728 passing (test_validate_schema.py)
  • Integration test: Deployed to personal account (us-east-1), verified GetCapacityProvider returns expected PropagateTags configuration:

    • Mode: Explicit ✅
    • ExplicitTags: { Environment: Production, Team: Lambda-Tooling } ✅
  • Pipeline: Existing CI passes on SamTranslatorLambda pipeline
Checklist
Testing
Integration test
dev-dsk-vichym % AWS_DEFAULT_REGION=us-east-1 pytest --no-cov integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role -v
===================== test session starts =====================
platform linux -- Python 3.12.13, pytest-7.4.4, pluggy-1.6.0 -- /local/home/vichym/.local/share/mise/installs/python/3.12.13/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default'
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /local/home/vichym/.meshclaw/workspace/Projects/lmi-capacity-provider-tags-propagation/code/sam-t
configfile: pytest.ini
plugins: xdist-3.8.0, rerunfailures-11.1.2, env-0.8.2, cov-4.1.0, hypothesis-6.156.6, random-order-1.2.0, localserver-0.10.0
collected 1 item
integration/combination/test_function_with_capacity_provider.py::TestFunctionWithCapacityProvider::test_function_with_capacity_provider_default_role
---------------------------- live log setup ----------------------------
INFO botocore.credentials:credentials.py:1392 Found credentials in shared credentials file: ~/.aws/credentials
PASSED [100%]
===================== 1 passed in 159.33s (0:02:39) =====================

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@vicheey
test(capacity-provider): add integration test for ManagedResourceTags
5bb8346
Add integration test verifying ManagedResourceTags with explicit tags
and Globals inheritance. Simplify ManagedResourceTags to Tags-only
interface (Mode: Explicit + ExplicitTags).
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..5bb8346

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
Comment threadintegration/resources/templates/combination/function_lmi_default.yaml
@vicheey
test: add Globals.CapacityProvider.ManagedResourceTags inheritance an…
7797cde
…d override assertions
- Add Globals.CapacityProvider.ManagedResourceTags.Tags with GlobalTag in template
- Assert SimpleCapacityProvider inherits GlobalTag from Globals
- Assert AdvancedCapacityProvider overrides GlobalTag at resource level
- Validates PRUNE_AND_MERGE behavior end-to-end via Lambda API
aws-sam-tooling-bot[bot]
aws-sam-tooling-botBot
reviewed
Aug 24, 2026
View reviewed changes
@aws-sam-tooling-botaws-sam-tooling-botBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results
Reviewed: bbc6a9a..7797cde

Files: 16

Comments: 2
Comment threadintegration/combination/test_function_with_capacity_provider.py
@awsaws
deleted a comment from aws-sam-tooling-botBotAug 24, 2026
aws-sam-tooling-bot[bot]

This comment was marked as outdated.

Sign in to view
@vicheey
vicheey
commented
Aug 24, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I removed CpNoManagedResourceTags
@vicheey
test: remove redundant CpNoManagedResourceTags fixture
cc4c6d3
CpNoManagedResourceTags was functionally identical to CpInheritsGlobal —
both inherit from Globals with no resource-level override. Removed from
input template and all partition outputs (aws, aws-cn, aws-us-gov).
Clean up orphaned doc entry in sam-docs.json.
aws-sam-tooling-bot[bot]

This comment was marked as duplicate.

Sign in to view
@vicheey
vicheey
marked this pull request as ready for review
August 24, 2026 18:51
@vicheey
vicheey
requested a review
from a team
as a code ownerAugust 24, 2026 18:51
@vicheey
vicheey
merged commit b794d0a
into
developAug 24, 2026

9 checks passed

@vicheey
vicheey
deleted the

add-managed-resource-tags-integ-test

branch
August 24, 2026 22:37
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aws-sam-tooling-botaws-sam-tooling-bot[bot]aws-sam-tooling-bot[bot] left review comments
@roger-zhanggroger-zhanggroger-zhangg approved these changes
@ckawlckawlckawl approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@vicheey@roger-zhangg@ckawl