Uh oh!
There was an error while loading. Please reload this page.
fix(deploy-on-aws): repair defusedxml diagram fixers - #259
Open
shakirjames wants to merge 1 commit into
Open
Conversation
shakirjames
requested review from
a team, arnewouters, krokoko and theagenticguyAugust 25, 2026 06:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defusedxml.ElementTreeremains the parser without resolving exports it does not provideET.indentcall with a small parser-free formatter and make the dynamic loader safe for postponed dataclass annotationsmise run validatepath, with no new dependencyProblem
With the declared
defusedxml>=0.7.1dependency, the shipped diagram entrypoints fail at import time becausedefusedxml.ElementTreedoes not exposeElement,ElementTree, orindent. This makes the deploy-on-aws post-processing hook fail before it can validate a generated diagram.This addresses the runtime failure described in #154 and #167 and supersedes the closed approach in #172 without monkeypatching parser exports or reintroducing an unsafe parser import.
Verification
mise run validatemise run lintmise run fmt:checkdefusedxml==0.7.1A complete local
mise run buildcould not start because the temporary Mise bootstrap rejected its uv release attestation. The exact lint, validation, formatting, focused security, and real-diagram checks above were run directly; canonical GitHub CI remains the package-wide build authority.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.