skip md5 check if hash value is empty - #144
Merged
Merged
Conversation
azhon
commented
Feb 16, 2023
Owner
I think check if hash value empty is unnecessary, finally |
thinhbuzz
commented
Feb 16, 2023
ContributorAuthor
@azhon in the current behavior we still need the cost to generate the md5 hash for comparison. with this PR we don't need to generate md5 hash |
azhon
commented
Feb 16, 2023
Owner
@thinhbuzz sure. add this PR in the next version |
azhon added a commit
that referenced
this pull request
Mar 6, 2023
azhon added a commit
that referenced
this pull request
Mar 6, 2023
azhon added a commit
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save the cost of checking md5 when the hash is empty.