Uh oh!
There was an error while loading. Please reload this page.
feat: add no comment flow - #951
Merged
Merged
Conversation
- Convert use-controllable to TypeScript with proper generics (was a plain .js file, causing type-check errors across 5 consumers) - Add type argument to useControllable calls in dialog/drawer - Fix prettier formatting in rules.test.mjs - Freeze pre-existing comment-discipline debt into authoring-baseline.json
guilherme-santana-azion
approved these changes
Sep 1, 2026
robson-junior-azion
approved these changes
Sep 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verbose-comment-block(blocks comment blocks longer than 5 lines) andcomment-heavy-file(blocks files that are ≥20% prose comments) — enforcingcomments.md: comments should be rare and objective, not narration.authoring-baseline.jsonso the ratchet lands without forcing a full-repo rewrite in this PR; new code is held to the rule immediately.use-controllablewas a plain.jsfile with no generics, which madevue-tscreject everyuseControllable<T>(...)call site (accordion, dropdown, dialog, drawer, popover, tooltip). Converted it to typed TypeScript (use-controllable.ts+index.ts) and added the missing type argument indialog.vue/drawer.vue.How to test
pnpm --filter @aziontech/webkit run authoring— construction-standard ratchet passes with0 newviolations.pnpm --filter @aziontech/webkit run type-check—vue-tsc --noEmitpasses (previously failed with 10 errors across accordion/dropdown/dialog/drawer/popover/tooltip).pnpm --filter @aziontech/webkit run test:toolkit— the newcomment-heavy-file/verbose-comment-blockchecks are covered.pnpm run governance— full local gate (lint, stylelint, format, type-check, type-coverage, audit) is green.Notes
None — no breaking change, no new dependency.
authoring-baseline.jsonrecords pre-existing debt only; it does not grandfather anything introduced by this PR.