Skip to content

Throw error if credit attempted on non-creditable card#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rserna2010 wants to merge 2 commits into
base:master
Choose a base branch
from
Open

Throw error if credit attempted on non-creditable card #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f178c
Throw error if credit attempted on non-creditable card
rserna2010 Oct 9, 2014
f87956b
Edit comment
rserna2010 Oct 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/balanced.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,14 @@ function associate_to_customer(customer) {

balanced.registerType('card', {
debit: transaction_create('debit'),
credit: transaction_create('credit'),
// function below confirms card is creditable before attempting
credit: function() {
if (this.can_credit) {
transaction_create('credit')
} else {
throw new BalancedError('FundingInstrumentNotCreditable');
}
},
hold: transaction_create('card_hold'),
associate_to_customer: associate_to_customer,

Expand DownExpand Up@@ -190,3 +197,9 @@ balanced.registerType('dispute', {
events: '_',
transaction: '_'
});

function BalancedError(message) {
this.name = this.constructor.name;
this.message = message;
this.stack = (new Error()).stack;
}
22 changes: 13 additions & 9 deletions test/test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -380,17 +380,21 @@ test('credit_card', function (cb, assert, marketplace, debit_card) {
});
});

test('credit_card_can_credit_false', function (cb, assert, marketplace, debit_card) {
balanced.marketplace.credits.create({
amount: 250000,
destination: fixtures.card_non_creditable
}).then(function (credit) {
test('credit_card_can_credit_false', function(cb, assert, marketplace) {
balanced.marketplace.cards.create({
'number': '4111111111111111',
'expiration_month': '05',
'expiration_year': '2016'
}).then(function (card) {
card.credit({
"amount": 1000,
"description": "Credit"
}).then(function (customer) {
assert(false);
}, function(err) {
var error = JSON.parse(err.message).errors[0];
assert(error.status_code == 409);
assert(error.category_code == 'funding-destination-not-creditable');
}, function (err) {
assert(err.message == 'FundingInstrumentNotCreditable');
cb();
});
});
});

Expand Down