JavaScript style guide draft by aalin · Pull Request #61 · barsoom/devbook

aalin · 2020-12-22T11:26:10Z

No description provided.

olleolleolle

Love that we are getting a document home for this.

olleolleolle · 2020-12-22T11:32:54Z

+
+Since then, npm has improved a lot and nowadays there isn't really any reason to use yarn over npm.
+
+[Why Are You Still Using Yarn in 2018?](https://iamturns.com/yarn-vs-npm-2018/)


One feature in yarn that I use is resolutions, and I don't know of a way to control that in npm.

Never used it myself!
I guess if we have a situation where we need to use that feature we could switch to yarn for that project. After all, this is just a guideline. But I feel like it's better to use npm which comes with most nodejs-installs instead of using a third-party package manager that does 99% of the same things.

https://stackoverflow.com/questions/52416312/npm-equivalent-of-yarn-resolutions

Co-authored-by: Olle Jonsson <olle.jonsson@auctionet.com>

henrik · 2021-01-11T16:25:25Z

We should link to this file from styleguide/README.md under the JavaScript section (and remove its "Prefer CoffeeScript" stuff).

henrik

As the starting-off point for a living document this seems fine to me – it's quite far from where we are today (with a lot of CoffeeScript and jQuery) but I like that it's aspirational, and we can always tweak it as we go.

It would be good if we could edit/remove those old CoffeeScripty parts of the styleguide though so we don't have two mutually exclusive recommendations living side by side :)

henrik · 2021-01-11T16:30:00Z

+
+#### Dependencies
+
+In the npm repository, you can find packages for almost anything.


This phrasing of this section reads a bit weird to me – I feel like a more prescriptive style makes sense in a styleguide – more like "Avoid adding npm dependencies for simple things [reasons and examples given here]".

Good point :)

henrik · 2021-01-11T16:32:00Z

+
+## React
+
+The other guide is written for CoffeeScript so here's one for JavaScript.


Maybe remove the other guide?

Co-authored-by: Henrik Nyh <henrik@nyh.se>

tskogberg

Nice!

aalin · 2021-01-18T18:40:20Z

We should link to this file from styleguide/README.md under the JavaScript section (and remove its "Prefer CoffeeScript" stuff).

@henrik f162fc2

This reverts commit 335b0f4, reversing changes made to a2bfb55.

This reverts commit bf882c5. We are interested in the JS styleguide. Re-opening the PR.

JavaScript style guide draft
9e9af9c

aalin requested review from henrik, joakimk, olleolleolle, p-wall, soma and tskogberg December 22, 2020 11:26

olleolleolle reviewed Dec 22, 2020
View reviewed changes

aalinand others added 4 commits December 22, 2020 12:50

Update styleguide/javascript/README.md
98c4de7
Co-authored-by: Olle Jonsson <olle.jonsson@auctionet.com>

Fix link title in styleguide/javascript/README.md
3d47251
Co-authored-by: Olle Jonsson <olle.jonsson@auctionet.com>

Fix typo
4c57368

Use a better example file/component name
e2570ed

soma approved these changes Jan 11, 2021
View reviewed changes

henrik approved these changes Jan 11, 2021
View reviewed changes

aalinand others added 5 commits January 14, 2021 00:22

Fix header levels
dac5ad5

Update phrasing in dependencies-section
def8a38

Explain why to use for named functions
d2c399c

"arrow-functions" -> "arrow functions"
c8a4c6d
Co-authored-by: Henrik Nyh <henrik@nyh.se>

"ok" -> "OK"
6fd4e1e
Co-authored-by: Henrik Nyh <henrik@nyh.se>

tskogberg approved these changes Jan 18, 2021
View reviewed changes

Link to JavaScript styleguide
f162fc2

tskogberg merged commit 335b0f4 into masterJan 28, 2021

tskogberg deleted the javascript branch January 28, 2021 14:56

aalin added a commit that referenced this pull request Jan 29, 2021
Revert "Merge pull request#61from barsoom/javascript"
bf882c5
This reverts commit 335b0f4, reversing changes made to a2bfb55.

olleolleolle added a commit that referenced this pull request Mar 12, 2021
Revert "Revert "Merge pull request#61from barsoom/javascript""
4d7d137
This reverts commit bf882c5. We are interested in the JS styleguide. Re-opening the PR.


		Since then, npm has improved a lot and nowadays there isn't really any reason to use yarn over npm.

		[Why Are You Still Using Yarn in 2018?](https://iamturns.com/yarn-vs-npm-2018/)


		#### Dependencies

		In the npm repository, you can find packages for almost anything.


		## React

		The other guide is written for CoffeeScript so here's one for JavaScript.

Uh oh!

Conversation

aalin commented Dec 22, 2020

Uh oh!

olleolleolle left a comment

Choose a reason for hiding this comment

Uh oh!

olleolleolleDec 22, 2020

Choose a reason for hiding this comment

Uh oh!

aalinDec 22, 2020

Choose a reason for hiding this comment

Uh oh!

tskogbergJan 29, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

henrik commented Jan 11, 2021

Uh oh!

henrik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

henrikJan 11, 2021

Choose a reason for hiding this comment

Uh oh!

aalinJan 14, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

henrikJan 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tskogberg left a comment

Choose a reason for hiding this comment

Uh oh!

aalin commented Jan 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aalin commented Jan 18, 2021•
edited
Loading