feat(Async): StartTaskImmediate - #1
Closed
bartelink wants to merge 7 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends Microsoft.FSharp.Control.Async in FSharp.Core with Async.StartTaskImmediate, a helper that captures the ambient CancellationToken, passes it to a task/value-task factory, and awaits the result using the newer Async.Await semantics (notably exception unwrapping).
Changes:
- Add
Async.StartTaskImmediateoverloads forTask,Task<'T>, and (on NETSTANDARD2_1)ValueTask,ValueTask<'T>. - Add unit tests covering result flow, cancellation token flow, exception unwrapping, and cancellation behavior.
- Update FSharp.Core surface area baselines (netstandard2.1) and add a release-notes entry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs | Adds coverage for StartTaskImmediate across Task/ValueTask scenarios. |
| tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard21.release.bsl | Records new public API entries for netstandard2.1 release surface-area validation. |
| tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard21.debug.bsl | Records new public API entries for netstandard2.1 debug surface-area validation. |
| src/FSharp.Core/async.fsi | Declares the new StartTaskImmediate overloads with XML docs. |
| src/FSharp.Core/async.fs | Implements StartTaskImmediate via Async.CancellationToken + Async.Await. |
| docs/release-notes/.FSharp.Core/11.0.100.md | Notes the new API addition in release notes. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bartelinkforce-pushed
the
async-await
branch
3 times, most recently
from
May 22, 2026 17:18
430f0d8 to
e1a34f0Comparebartelinkforce-pushed
the
async-sti
branch
2 times, most recently
from
May 22, 2026 17:56
9a9977a to
8cd3e4eComparebartelinkforce-pushed
the
async-sti
branch
4 times, most recently
from
May 22, 2026 22:00
ee01fe6 to
6db3977Comparebartelinkforce-pushed
the
async-await
branch
2 times, most recently
from
May 25, 2026 12:03
93badc9 to
50814f5Comparebartelinkforce-pushed
the
async-sti
branch
3 times, most recently
from
May 25, 2026 17:40
1ca22cf to
9becd19Comparebartelinkforce-pushed
the
async-sti
branch
2 times, most recently
from
May 25, 2026 17:50
52f8576 to
87675b1Comparebartelink
commented
May 26, 2026
| AwaitUnitTask true (task.AsTask()) | ||
| #endif | ||
| static member StartTaskImmediate(createTask: CancellationToken -> Task<'T>) : Async<'T> = |
OwnerAuthor
There was a problem hiding this comment.
is startTask a better parameter name?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
bartelinkforce-pushed
the
async-await
branch
3 times, most recently
from
August 12, 2026 21:54
2317986 to
c8eda9fCompare6 tasks
# Conflicts: # tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs
bartelink
commented
Aug 13, 2026
OwnerAuthor
Closing; reposted as dotnet/fsharp PR 20258 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the task start+await aspect of fsharp/fslang-suggestions#1284
See also fsharp/fslang-suggestions#1467