fix(auth): deploy auth config with workspace keys - #565
Merged
Conversation
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.1.3-pr.565.21ee30ePrefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.1.3-pr.565.21ee30e"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.1.3-pr.565.21ee30e"
}
}
Preview published to npm registry — try new features instantly! |
ImriKochWix
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Description
When deploying with a workspace API key (
BASE44_API_KEY), the auth config was being pushed through the generic app-update endpoint (PUT api/apps/:id), which workspace keys are not authorized to use. This PR routes auth-config pushes through the dedicated deployment endpoint (PUT api/apps/:id/deployment/auth-configuration) whenever workspace API key auth is in effect, so auth config deploys correctly in CI/automation contexts.Related Issue
None
Type of Change
Changes Made
pushAuthConfigToApinow checkshasWorkspaceApiKeyAuth()and, when true, sends the auth-config payload to thedeployment/auth-configurationendpoint instead of the genericapi/apps/:idupdate route.payloadvariable reused across both code paths.{ auth_config: ... }) for non-workspace-key auth.api_keyheader), the payload is snake_cased and not wrapped inauth_config, and the generic app-update route is never called.Testing
Checklist
Additional Notes
The workspace-key path returns the original config object (not the API response) since the deployment endpoint returns a lightweight status payload rather than the full auth config. Error handling mirrors the existing path via `ApiError.fromHttpError`.
🤖 Generated by Claude | 2026-07-13 08:06 UTC | 21ee30e