Keep refreshing opencode's other spelling

[jeremy]

#624's central claim was wrong, and I shipped it. This corrects the record and the regression it introduced.

What #624 said

opencode reads skills/, plural — it has never read either path we wrote.

What opencode actually does

From the shipped 1.18.4 binary's own docs table — not the docs site:

| Global skills | `~/.config/opencode/skill(s)/<name>/SKILL.md` |
| Project skills | `.opencode/skill(s)/<name>/SKILL.md` |
| Project agents | `.opencode/agent/<name>.md` or `.opencode/agents/<name>.md` |

skill(s) — the same optional plural opencode uses for agent(s) and command(s). Both spellings work. The singular paths were fine.

I asserted that negative from a summarizing fetch of https://opencode.ai/docs/skills/, which rendered the parenthetical as plain skills. A negative claim deserved a primary source, and the binary was available the whole time.

The regression

skillLocations is both the wizard's install targets and the refresh set. #624 moved it wholly to plural, so anyone who picked OpenCode in basecamp skillbefore#624 now has a file that:

• opencode still loads — it works
• the refresh loop no longer visits — it never updates again

Working and silently frozen at the version that installed it. That is worse than broken, because nothing reports it, and it is the exact failure mode #624 claimed to be fixing.

The fix

Separate the two roles the list was playing:

• skillLocations — wizard install targets. Unchanged, still plural.
• legacySkillLocations — paths an agent still reads that we no longer suggest. Refreshed, never offered.

refreshAllInstalledSkills walks both. Refresh updates in place and does not create the new path, so nobody ends up with two copies drifting apart — asserted in the test.

Verification

TestRefreshAllInstalledSkills_LegacyOpenCodePath fails against the pre-fix loop:

-- API coverage: See API-COVERAGE.md in the CLI repo
+old
a pre-#624 opencode install must keep getting refreshed

and passes after it. bin/ci green (EXIT=0).

What from #624 still holds

• ~/.agents/skills/<name>/SKILL.md is auto-loaded by opencode — confirmed in the same table — so the skill has always worked there regardless of the wizard. That claim was right.
• Plural install targets are valid, so the new default is fine; this is additive.
• Pinning path literals in a test rather than deriving them was right, and that test's comment is corrected here too.

#617 gets a correction as well, since I told the requester the wizard was broken for them.

---

Summary by cubic

Restores refresh for OpenCode skills installed at the singular skill path so pre-#624 installs keep updating. Keeps plural install targets and updates legacy installs in place without creating duplicates.

• Bug Fixes
  • Added legacySkillLocations for OpenCode skill paths (global and project).
  • refreshAllInstalledSkills now walks both install and legacy paths; no new files are created.
  • Confirmed OpenCode accepts skill(s); added regression test to ensure legacy paths keep refreshing.

^{Written for commit 6cc509f. Summary will update on new commits.}

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[jeremy]

Correcting the scope claim in this PR, since it is broader than what actually shipped.

The description says the fix covers "anyone who picked OpenCode in the wizard" (and the comment at internal/commands/skill.go:44-46 says the same). Only the global legacy path is actually refreshed.refreshAllInstalledSkills skips any location that is not ~-prefixed or absolute:

// Skip project-relative paths — no reliable project root in PostRunE.if!strings.HasPrefix(loc.Path, "~") &&!filepath.IsAbs(loc.Path) {
continue
}

So of the two rows this PR added, ~/.config/opencode/skill/basecamp/SKILL.md is refreshed and .opencode/skill/basecamp/SKILL.md is inert. Someone whose OpenCode skill lives at the legacy project path is still silently frozen — and, because legacy paths are "refreshed, never suggested," they are not an install target either, so nothing writes that file at all.

That guard is pre-existing and not a regression here. It applies equally to the non-legacy project rows already in skillLocations — .claude/skills/basecamp/SKILL.md and .opencode/skills/basecamp/SKILL.md — which are also never auto-refreshed, for the stated reason that PostRunE has no reliable project root. Those two do at least get written by an explicit basecamp skill install.

Whether project-local installs should ever be auto-refreshed is a separate decision — it needs a project-root resolution strategy and a test of its own — so I am not widening this fix. Recording the correction only, so the claim doesn't get read as coverage it doesn't have.