Uh oh!
There was an error while loading. Please reload this page.
Fix stale comments in ensureDeleteConfirmable - #668
Conversation
The force-flag work merged in #654 at 7ea0be6, before two comment revisions landed on the feature branch. The historical paragraph now speaks of the old gate in the past tense, and the closing note says what actually happened to isNonInteractiveCommand: the delete path bypasses it — machineReadsThisOutput asks the narrower question — and it is left untouched for its other callers, not "read, never widened".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Pull request overview
Updates stale historical comments around delete confirmation logic; runtime behavior is unchanged.
Changes:
- Describes the former confirmation gate in past tense.
- Clarifies why
isNonInteractiveCommandis bypassed.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
#654 merged at 7ea0be6, before two comment-only revisions landed on the feature branch. This applies just those 16 lines — no code changes.
isNonInteractiveCommandsaid "read, never widened", but the delete path no longer consults it at all: it is deliberately bypassed —machineReadsThisOutputasks the narrower question this needs — and left untouched for its other callers (missingArg,noChanges), where widening would move behavior across many commands.bin/cigreen.Summary by cubic
Fixes two stale comments in
ensureDeleteConfirmablethat were left behind when the force-flag work merged in #654. No code behavior changes; this is comment text only.isNonInteractiveCommandis deliberately bypassed—machineReadsThisOutputasks the narrower question—and left untouched for its other callers (missingArg,noChanges), not "read, never widened".Written for commit 27af253. Summary will update on new commits.