Refresh the Nix vendorHash for the go-dependencies bump - #701
Conversation
#697 changed go.sum this morning and the Nix vendorHash in nix/package.nix stayed at the previous value, so `nix build` fails with a hash mismatch. Main's own Test run did not show it: the Nix job only builds when a flake-relevant path changes, and the merge commit that landed on main touched none, so the job reported success with the build skipped. Any branch that touches go.sum, flake.*, nix/ or test.yml now fails on it. The hash is the one CI computed on two independent runs of the build.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
The hash is validly encoded, and the changed path triggers the Nix build verification.
Pull request overview
Refreshes the Nix dependency hash after the Go dependency update.
Changes:
- Updates
vendorHashto the CI-computed SHA-256 value.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
nix/package.nix |
Refreshes the Nix Go dependency hash. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…endor-hash * origin/main: ci: bump zizmorcore/zizmor-action in the github-actions group (#698) Reference in-repo workflows with GitHub's self-repository syntax (#700) Kill the Codex probe's process group when its deadline expires (#694) Refresh the Nix vendorHash for the go-dependencies bump (#701)
#697 changed
go.sumthis morning and the NixvendorHashinnix/package.nixstayed at the previous value, sonix buildnow fails with a hash mismatch. Main's own Test run did not show it: the Nix job builds only when a flake-relevant path changes, and the merge commit that landed on main touched none of them, so the job reported success with the build skipped. Any branch that touchesgo.sum,flake.*,nix/, ortest.ymlfails on it; #700 hit it by editingtest.yml.The new hash is the value CI computed on two independent runs. This PR touches
nix/package.nix, so its own Nix job runs the build and is the verification.Worth noting for the filter: a Dependabot Go bump changes
go.sum, so the bump PR's own run does build the flake, but the stale hash only fails there if that check is required. This one merged with it red or skipped; theNix flake buildscheck may be worth marking required so the next one cannot.Summary by cubic
Refreshes the Nix
vendorHashinnix/package.nixto match the recentgo.sumupdate, fixingnix buildhash mismatches on branches that touchgo.sum,flake.*,nix/, ortest.yml. The new hash is from two independent CI runs, and this PR's Nix job verifies the build because it changesnix/package.nix.Written for commit 5a9cfcc. Summary will update on new commits.