Adopt self-repository workflow references - #74
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
There was a problem hiding this comment.
🟡 Changes recommended
The lint suppression is overly broad, and generated workflows retain unpinned tool installations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Pins CI tools for reproducibility and adopts GitHub’s self-repository workflow syntax.
Changes:
- Pins govulncheck and benchstat versions.
- Uses
$/for reusable security workflows. - Adds a temporary actionlint suppression.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
.github/actionlint.yaml |
Suppresses unsupported $/ diagnostics. |
.github/workflows/release.yml |
Pins govulncheck and adopts $/. |
.github/workflows/test.yml |
Pins govulncheck and benchstat. |
seed/.github/workflows/release.yml |
Adopts $/ in generated releases. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| security: | ||
| name: Security scan | ||
| uses: ./.github/workflows/security.yml | ||
| uses: $/.github/workflows/security.yml |
There was a problem hiding this comment.
Good catch, and it changes the PR. The seed's comment (# @latest intentional — pinning delays scanning improvements and new Go version support for no meaningful reproducibility gain) is this repo's documented policy from #3, and the evidence backs it: govulncheck fetches its vulnerability database live regardless of the binary version, and the sibling repos that did pin have rotted (hey-sdk and fizzy-sdk sit on govulncheck v1.1.4 against a current v1.8.0). Pinning here while the seed says the opposite would be inconsistency for Scorecard's benefit. So eae7766 drops the pins from this repo's workflows rather than propagating them into the seed; the three Scorecard Pinned-Dependencies alerts are dismissed as won't-fix citing that policy, and the PR is retitled to what is left: the $/ self-repository change.
Adopt GitHub's
$/self-repository syntax for the reusable-workflow calls in.github/workflows/release.ymlandseed/.github/workflows/release.yml.zizmor 1.30.0 (released 2026-08-30) added a
self-repositoryaudit that flags the./.github/workflows/security.ymlform, andzizmorcore/zizmor-actionfloatsversion: latest, so the GitHub Actions audit job already fails on main for any run after that date — it is what turns #73 red, independent of the bump there. Same adaptation fizzy-cli made in basecamp/fizzy-cli#210: switch to$/, and add.github/actionlint.yamlignoring actionlint 1.7.12's not-yet-updatedworkflow-callformat check for this one call (rhysd/actionlint#711, fix in rhysd/actionlint#732; fizzy-cli tracks removing the suppression in basecamp/fizzy-cli#211).Two things to know about
$/:Not done:
actionlint.yamlinseed/— the seed's workflows and Makefile do not run actionlint, so it would configure a tool the seeded repo does not have.go install govulncheck@latest/benchstat@latestlines to clear Scorecard #17, #18, #19; review pointed out that the seed documents@latestas intentional (pinning delays scanner improvements and new-Go support for no reproducibility gain — the vulnerability database is fetched live either way, and the sibling repos that pinned have rotted at v1.1.4). The second commit reverts those pins and the three alerts are dismissed as won't-fix citing that policy.make checkandmake lint-actions(actionlint + zizmor 1.30.0) pass locally. After this merges,@dependabot rebaseon #73 turns it green.