Skip to content

Render nested Action Text attachment content - #335

Open
nitrnitr wants to merge 1 commit into
basecamp:mainfrom
nitrnitr:fix/nested-action-text-attachment-content
Open

Render nested Action Text attachment content#335
nitrnitr wants to merge 1 commit into
basecamp:mainfrom
nitrnitr:fix/nested-action-text-attachment-content

Conversation

@nitrnitr

Copy link
Copy Markdown

What changed

Handle bare <action-text-attachment> elements whose HTML is stored in a content attribute.

HEY can nest this element inside a Trix HTML attachment. Previously, ToMarkdown treated it as a file attachment and rendered 📎 attachment, dropping the embedded text and links.

Unnamed elements with non-empty content are now rendered through the existing bounded embedded-HTML path. Named elements remain file attachments.

Added regression coverage for both the nested HTML case and filename precedence.

Testing

  • make check
  • make build

@nitrnitr
nitrnitr marked this pull request as ready for review August 26, 2026 01:33
@nitrnitr
nitrnitr requested a review from a team as a code ownerAugust 26, 2026 01:33
CopilotAI balanced review requested due to automatic review settings August 26, 2026 01:33

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renders unnamed nested Action Text attachment HTML through the existing bounded Markdown path while preserving named file attachments.

Changes:

  • Added nested attachment-content rendering.
  • Added regression and filename-precedence tests.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
internal/htmlutil/markdown.goHandles embedded Action Text attachment content.
internal/htmlutil/markdown_test.goTests nested HTML and filename precedence.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment threadinternal/htmlutil/markdown.go
@nitrnitr
nitrnitrforce-pushed the fix/nested-action-text-attachment-content branch from 2b6d4f3 to f33596eCompareAugust 26, 2026 01:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nitrnitr