docs: drop the internal author pre-merge checklist from the PR template - #318
Merged
Merged
Conversation
The author pre-merge checklist has a canonical copy in PR_MERGE_POLICY.md §5, linked from the Checklist section. Keeping a duplicate in the template caused it to be pre-filled into (and published in) every PR body. Replaced with an invisible reminder comment pointing to §5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the "PR Merge Policy Contract" author checklist section from
.github/PULL_REQUEST_TEMPLATE.md. That author-side gate has a canonical copy inPR_MERGE_POLICY.md§5 (already linked from the## Checklistsection), so the template kept a duplicate. Replaced it with an invisible reminder comment.Motivation
The template pre-fills every PR body with that internal author checklist, so contributors end up publishing it — with §-numbered policy internals and shell commands — into public PR bodies. The checklist is meant to be run locally before "Ready for review", not shipped in the PR description. Keeping it only in
PR_MERGE_POLICY.md§5 removes the duplication and the accidental exposure while preserving the reference via the existing Checklist link.Type of Change
model— add/extend model support (models/**+ registration seam + model kernels only)kernel— add/optimize a compute kernel (batchgen_kernels/**+ in-tree kernel dirs)core— change scheduling/serving/runtime scaffolding (the only type that may)fix— narrow bug fix (+ a regression test)infra— build / CI / packaging / scripts / Dockerdocs— documentation onlyFile changes
.github/PULL_REQUEST_TEMPLATE.mdChecklist