Uh oh!
There was an error while loading. Please reload this page.
Avoid a NullPointerException in NetServer.onError - #427
Open
simonlindholm wants to merge 1 commit into
Open
Conversation
jbloxham
commented
Jan 22, 2017
Contributor
How did you obtain this error? I was able to reproduce this exception by starting two instances of the server simultaneously, but this produces fairly seriously erroneous behavior across the server, and is in general not supported. |
simonlindholm
commented
Jan 22, 2017
Author
Yeah, I think I got that from running two servers at the same time (trying to parallelize testing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the following stack trace:
and indeed the first argument to
onErrorcan sometimes be null, so this seems like a reasonable fix.